[Bug 10572] New: Add phone to message_transport_types table for new installs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572 Bug ID: 10572 Summary: Add phone to message_transport_types table for new installs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: m.de.rooy@rijksmuseum.nl Reporter: m.de.rooy@rijksmuseum.nl CC: gmcharlt@gmail.com In connection to bug 4246 commit 591bae324d77d285b27dfa6e10dc7001671f53cc added phone to the message_transport_types table in updatedatabase.pl This should be done also for new installs via the .sql files of the web installer. I am adding it only to English now, basing this change upon the work in reports 10509 and 10520. (I discovered this tiny omission there too.) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572 --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 19548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19548&action=edit Bug 10572: Add phone to message_transport_types table for new installs In connection to bug 4246 commit 591bae324d77d285b27dfa6e10dc7001671f53cc added phone to the message_transport_types table in updatedatabase.pl This should be done also for new installs via the .sql files of the web installer. I am adding it only to English now, basing this change upon the work in reports 10509 and 10520. (I discovered this tiny omission there too.) Test plan: Apply patches 10509/10520. Run new install or run this particular sql file from command line. Note: If you only run this particular file, you do not need patch 10509. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10520 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=4246 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19548|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20075&action=edit Bug 10572: Add phone to message_transport_types table for new installs In connection to bug 4246 commit 591bae324d77d285b27dfa6e10dc7001671f53cc added phone to the message_transport_types table in updatedatabase.pl This should be done also for new installs via the .sql files of the web installer. I am adding it only to English now, basing this change upon the work in reports 10509 and 10520. (I discovered this tiny omission there too.) Test plan: Apply patches 10509/10520. Run new install or run this particular sql file from command line. Note: If you only run this particular file, you do not need patch 10509. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, this could go in as a bugfix to earlier versions as well, but the new web installer translations probably can't. Could you provide a follow-up please? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Also, I think to fix this properly we shoudl include a database update. It looks like 4246 has been released with 3.10, so there is a good chance of people installing 3.10 or 3.12 will have missed the database update and will have the problem. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572 --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 20142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20142&action=edit Bug 10572: Followup: dbrev for phone message_transport_type Test plan: Run the updatestructure step of web installer. Check if you have a phone message_transport_type. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Back to Signed off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Kyle, could you address comment 3 please? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #7)
Kyle, could you address comment 3 please?
Is not it fixed with the second patch? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 21051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21051&action=edit Bug 10572 - Add phone to message_transport_types table for new installs- QA Followup -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20075|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 21052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21052&action=edit Bug 10572: Add phone to message_transport_types table for new installs In connection to bug 4246 commit 591bae324d77d285b27dfa6e10dc7001671f53cc added phone to the message_transport_types table in updatedatabase.pl This should be done also for new installs via the .sql files of the web installer. I am adding it only to English now, basing this change upon the work in reports 10509 and 10520. (I discovered this tiny omission there too.) Test plan: Apply patches 10509/10520. Run new install or run this particular sql file from command line. Note: If you only run this particular file, you do not need patch 10509. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20142|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 21053 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21053&action=edit Bug 10572: Followup: dbrev for phone message_transport_type Test plan: Run the updatestructure step of web installer. Check if you have a phone message_transport_type. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21051|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 21054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21054&action=edit Bug 10572 - Add phone to message_transport_types table for new installs- QA Followup Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Marcel! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572 Bug 10572 depends on bug 10520, which changed state. Bug 10520 Summary: Add i18n function to English mysql files for webinstaller http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520 What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org