https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41440 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 190466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190466&action=edit Bug 41440: Add caching to language_get_description and get_rfc4646_from_iso639 This should have no visible effect, just internal caching To test: 1 - Do a search, check the language facets 2 - Apply patch, restart all 3 - Do a search, check the language facets 4 - No change 5 - Sign off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41440 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190466|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 190477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190477&action=edit Bug 41440: Add caching to language_get_description and get_rfc4646_from_iso639 This should have no visible effect, just internal caching To test: 1 - Do a search, check the language facets 2 - Apply patch, restart all 3 - Do a search, check the language facets 4 - No change 5 - Sign off Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41440 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41440 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41440 --- Comment #5 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 196628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196628&action=edit Bug 41440 (follow-up): Handle undef "script" This silences warnings about undefinved values in the cache key This seems to come from some calls in _build_languages_arrayref where we might not have all variants of a language - the call could be prevented, but I am not sure what the effects would be, so I simply convert undef (null value) to "undef" (string) and use that as the cache key -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41440 --- Comment #6 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 196820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196820&action=edit Bug 41440: Add caching to language_get_description and get_rfc4646_from_iso639 This should have no visible effect, just internal caching To test: 1 - Do a search, check the language facets 2 - Apply patch, restart all 3 - Do a search, check the language facets 4 - No change 5 - Sign off Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41440 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196628|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41440 --- Comment #8 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 196822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196822&action=edit Bug 41440: (QA follow-up) Add unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41440 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41440 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41440 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #12 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Enhancement - not backporting to 25.05 -- You are receiving this mail because: You are watching all bug changes.