[Bug 15215] New: Remove Depreciation Errors due to misuse of UNIVERSAL in SIP/Sip/MsgType.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15215 Bug ID: 15215 Summary: Remove Depreciation Errors due to misuse of UNIVERSAL in SIP/Sip/MsgType.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: colin.campbell@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com Compiling C4/SIP/Sip/MsgType.pm generates the warning UNIVERSAL->import is deprecated and will be removed in a future perl in perl 5.22 this is now a fatal error causing compilation to abort with the message 'UNIVERSAL does not export anything'. (And e.g. crashing Koha's test suite fairly early on) replace invalid call to UNIVERSAL with a use UNIVERSAL::can to avoid this -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15215 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |colin.campbell@ptfs-europe. |ity.org |com --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 44992 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44992&action=edit Proposed patch Easy to test Without patch compiling MsgType.pm (perl -wc C4/SIP/Sip/MsgType.pm) will give a depreciation warning about calling UNIVERSAL's methods or with perl 5.22 will abort compilation with message that UNIVERSAL does not export any methods With patch applied module should compile without the warning/error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15215 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15215 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44992|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 45037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45037&action=edit [SIGNED-OFF] Bug 15215: Remove warning due to misuse of UNIVERSAL Calling UNIVERSAL's internal methods will cause a depreciation warning in perls less that 5.22 as of 5.22 the warning is a fatal error causing compilation to abort Replace the use UNIVERSAL with UNIVERSAL::can to work around the buggy construct perldoc UNIVERSAL::can for more info Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No more worning/error No qa errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15215 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15215 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45037|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 45043 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45043&action=edit [PASSED QA] Bug 15215: Remove warning due to misuse of UNIVERSAL Calling UNIVERSAL's internal methods will cause a depreciation warning in perls less that 5.22 as of 5.22 the warning is a fatal error causing compilation to abort Replace the use UNIVERSAL with UNIVERSAL::can to work around the buggy construct perldoc UNIVERSAL::can for more info Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No more worning/error No qa errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15215 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Colin! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15215 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org