[Bug 25942] New: Batch biblio operations on report results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Bug ID: 25942 Summary: Batch biblio operations on report results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Bug 24886 cleaned up the templates and removed a new line in the recordnumber_list textarea loop Now if one tries to send biblionumbers from a report to batch operations they are all sent as a single string -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24886 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886 [Bug 24886] Reports template should be reindented -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Cardnumbers do the same. Itemnumbers do not. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Batch biblio operations on |Batch biblio and borrower |report results |operations on report | |results should not | |concatenate | |biblio/cardnumbers into a | |single string -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- This bug completely breaks a relatively new and rather popular feature. It'd be great to see it fixed sooner rather than later. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com --- Comment #3 from Kelly McElligott <kelly@bywatersolutions.com> --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 113782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113782&action=edit Bug 25942: Fix batch report operations for cardnumbers and biblionumbers This patch moves the processing for these to a block and adds a comment in place of whitespace and uses template directives to chomp newlines to improve readability To test: 1 - Create a report like: SELECT biblionumber FROM biblios 2 - Run it 3 - Try the various options from the 'Batch operations' button (You will need to define a marc modification template) 4 - The operations don't find the biblios 5 - Create a report like: SELECT cardnumber FROM borrowers 6 - Run it 7 - Test the batch operations 8 - They fail 9 - Apply patch 10 - Run each report again and test batch operations 11 - They work! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113782|0 |1 is obsolete| | --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 113783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113783&action=edit Bug 25942: Fix batch report operations for cardnumbers and biblionumbers This patch moves the processing for these to a block and adds a comment in place of whitespace and uses template directives to chomp newlines to improve readability To test: 1 - Create a report like: SELECT biblionumber FROM biblios 2 - Run it 3 - Try the various options from the 'Batch operations' button (You will need to define a marc modification template) 4 - The operations don't find the biblios 5 - Create a report like: SELECT cardnumber FROM borrowers 6 - Run it 7 - Test the batch operations 8 - They fail 9 - Apply patch 10 - Run each report again and test batch operations 11 - They work! Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_11_target CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113783|0 |1 is obsolete| | --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 113916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113916&action=edit Bug 25942: Fix batch report operations for cardnumbers and biblionumbers This patch moves the processing for these to a block and adds a comment in place of whitespace and uses template directives to chomp newlines to improve readability To test: 1 - Create a report like: SELECT biblionumber FROM biblio 2 - Run it 3 - Try the various options from the 'Batch operations' button (You will need to define a marc modification template) 4 - The operations don't find the biblios 5 - Create a report like: SELECT cardnumber FROM borrowers 6 - Run it 7 - Test the batch operations 8 - They fail 9 - Apply patch 10 - Run each report again and test batch operations 11 - They work! Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- As a step towards QA, here is another signoff. However, the QA script reports this: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt FAIL filters missing_filter at line 873 ( [%- recordnumbers = PROCESS batch_list results=results batch_type='biblionumber' | trim %][% IF recordnumbers %][% SET batch_biblionumbers = 1 %][% recordnumbers %][% END -%]) missing_filter at line 873 ( [%- recordnumbers = PROCESS batch_list results=results batch_type='biblionumber' | trim %][% IF recordnumbers %][% SET batch_biblionumbers = 1 %][% recordnumbers %][% END -%]) missing_filter at line 882 ( [%- recordnumbers = PROCESS batch_list results=results batch_type='biblionumber' | trim %][% IF recordnumbers %][% SET batch_biblionumbers = 1 %][% recordnumbers %][% END -%]) missing_filter at line 882 ( [%- recordnumbers = PROCESS batch_list results=results batch_type='biblionumber' | trim %][% IF recordnumbers %][% SET batch_biblionumbers = 1 %][% recordnumbers %][% END -%]) missing_filter at line 935 ( [%- cardnumbers = PROCESS batch_list results=results batch_type='cardnumber' | trim %][% IF cardnumbers %][% SET batch_cardnumbers = 1 %][% cardnumbers %][% END -%]) missing_filter at line 935 ( [%- cardnumbers = PROCESS batch_list results=results batch_type='cardnumber' | trim %][% IF cardnumbers %][% SET batch_cardnumbers = 1 %][% cardnumbers %][% END -%]) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 113924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113924&action=edit Bug 25942: (follow-up) fix filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113916|0 |1 is obsolete| | --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 113931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113931&action=edit Bug 25942: Fix batch report operations for cardnumbers and biblionumbers This patch moves the processing for these to a block and adds a comment in place of whitespace and uses template directives to chomp newlines to improve readability To test: 1 - Create a report like: SELECT biblionumber FROM biblio 2 - Run it 3 - Try the various options from the 'Batch operations' button (You will need to define a marc modification template) 4 - The operations don't find the biblios 5 - Create a report like: SELECT cardnumber FROM borrowers 6 - Run it 7 - Test the batch operations 8 - They fail 9 - Apply patch 10 - Run each report again and test batch operations 11 - They work! Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113924|0 |1 is obsolete| | --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 113932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113932&action=edit Bug 25942: (follow-up) fix filters Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Thanks, QA script ok :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (and it works ^^) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113931|0 |1 is obsolete| | Attachment #113932|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 113972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113972&action=edit Bug 25942: Fix batch report operations for cardnumbers and biblionumbers This patch moves the processing for these to a block and adds a comment in place of whitespace and uses template directives to chomp newlines to improve readability To test: 1 - Create a report like: SELECT biblionumber FROM biblio 2 - Run it 3 - Try the various options from the 'Batch operations' button (You will need to define a marc modification template) 4 - The operations don't find the biblios 5 - Create a report like: SELECT cardnumber FROM borrowers 6 - Run it 7 - Test the batch operations 8 - They fail 9 - Apply patch 10 - Run each report again and test batch operations 11 - They work! Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Bug 25942: (follow-up) fix filters Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- This doesn't seem to have correctly addressed batch patron modifications: Bug 27142 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27142 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27142 [Bug 27142] Patron batch update from report module - no patrons loaded into view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Martha Fuerst <mfuerst@hmcpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mfuerst@hmcpl.org --- Comment #16 from Martha Fuerst <mfuerst@hmcpl.org> --- Any chance at a backport to 20.05? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.07 released in| | Status|Pushed to master |Pushed to stable --- Comment #17 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- backported to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #18 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Missing dependencies for 19.11.x, no backport. 19.11.x shouldn't be affected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eugenegf@yahoo.com --- Comment #19 from Magnus Enger <magnus@libriotech.no> --- *** Bug 27902 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org