[Bug 17775] New: blocker of bug 7172
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Bug ID: 17775 Summary: blocker of bug 7172 Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: gmcharlt@gmail.com Reporter: mnashbat@alfaisal.edu QA Contact: testopia@bugs.koha-community.org CC: dpavlin@rot13.org Koha & ldap authentication fail authenticating new users when enabling plack, it works fine only if plack is desabled. Ldap authentication works fine with old registered users. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Mohammed Nashbat <mnashbat@alfaisal.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Who signed the| |Jonathan Druart patch off| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |blocker Blocks| |7172 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172 [Bug 7172] Omnibus for Plack variable scoping problems -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Summary|blocker of bug 7172 |Add new user with LDAP not | |works under Plack Who signed the|Jonathan Druart | patch off| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 --- Comment #1 from Zeno Tajoli <z.tajoli@cineca.it> --- More on this bug: the problem is add new user from LDAP, using the automatic population of Koha borrower table by LDAP. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.11 |unspecified CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is a rather bad bug, can we do something about it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud@biblibre.com --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Is anybody interested in fixing this bad bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz Assignee|gmcharlt@gmail.com |liz@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 --- Comment #4 from Alex Arnaud <alex.arnaud@biblibre.com> --- Hello Jonathan, We plan to work on this bug with Fridolin during our tech camp (30/01 -> 03/02). I'm comfortable with LDAP things and Fridolin with plack. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 --- Comment #5 from Liz Rea <liz@catalyst.net.nz> --- A slightly more concerning part of this, is after you fix the more obvious problem of C4::AddMember being undefined (even though it's technically there), there is a problem with the sessions between the OPAC and the intranet - i.e. the next action a logged in staff user will make is "permission denied" requiring them to log in again. I'm still testing to see if this is specifically to do with "replicate" or if it happens with LDAP logins generally. Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 --- Comment #6 from Liz Rea <liz@catalyst.net.nz> --- and when that ldap user logs out, the staff user, no matter who it is, is logged out as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Medium patch |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 --- Comment #7 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 59644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59644&action=edit Bug 17775 - Add new user with LDAP not works under Plack This patch fixes internal server error: Undefined subroutine &C4::Auth_with_ldap::AddMember called at /srv/koha_ffzg/C4/Auth_with_ldap.pm line 213. It occurs only under plack, and it's strange since C4::Members does EXPORT AddMember and we are importing it into Auth_with_ldap.pm (and it does work under CGI). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 --- Comment #8 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Alex, sorry to steal this one from you, but we hit this one when we deploy master in production, so here if fix for it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 --- Comment #9 from Liz Rea <liz@catalyst.net.nz> --- Hi, I thought this was the problem too - but there is another problem. Sessions created for the LDAP created user hijack any sessions from the same IP, including staff ones. I don't think of it as a separate bug - I think symptoms of the same problem. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 --- Comment #10 from Liz Rea <liz@catalyst.net.nz> --- Actually never mind, this sessions thing is a problem generally with plack, with or without LDAP. I only wish I had submitted my identical patch 2 weeks ago >.< Thanks for fixing this, Dobrica! Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59644|0 |1 is obsolete| | --- Comment #11 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 59662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59662&action=edit y# Attachment to Bug 17775 - Add new user with LDAP not works under Plack Bug 17775 - Add new user with LDAP not works under Plack This patch fixes internal server error: Undefined subroutine &C4::Auth_with_ldap::AddMember called at /srv/koha_ffzg/C4/Auth_with_ldap.pm line 213. It occurs only under plack, and it's strange since C4::Members does EXPORT AddMember and we are importing it into Auth_with_ldap.pm (and it does work under CGI). Signed-off-by: Liz Rea <liz@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Having a quick look at C4::Auth_with_ldap I am pretty sure there are other bugs under plack. Variable scoping in this module is very bad, have a look at $ldap, $prefhost, $base,... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 --- Comment #13 from Dobrica Pavlinusic <dpavlin@rot13.org> --- (In reply to Liz Rea from comment #9)
Hi, I thought this was the problem too - but there is another problem. Sessions created for the LDAP created user hijack any sessions from the same IP, including staff ones. I don't think of it as a separate bug - I think symptoms of the same problem.
Cheers, Liz
Liz, can you expand on this a little bit more? I know that login into OPAC or Intranet will be transferred between then (so if you login into intranet you will also be logged into opac). Is that what you are having problem with? This behavior is because we are registering cookies on hostname (whole hostname) so if OPAC and intranet are on the same hostname (but different path or ports) they will share session. If they are on different hostnames, they will not share sessions. Does this make sense? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 --- Comment #14 from Dobrica Pavlinusic <dpavlin@rot13.org> --- (In reply to Jonathan Druart from comment #12)
Having a quick look at C4::Auth_with_ldap I am pretty sure there are other bugs under plack. Variable scoping in this module is very bad, have a look at $ldap, $prefhost, $base,...
Yes, it's very bad code but we haven't hit any bugs in it (yet) and we'll need to rewrite it for DBIx anyway. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 --- Comment #15 from Liz Rea <liz@catalyst.net.nz> --- Just forget I said anything at all. Patch fixes the issue, and it's quite a bad one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59662|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59722&action=edit Bug 17775 - Add new user with LDAP not works under Plack This patch fixes internal server error: Undefined subroutine &C4::Auth_with_ldap::AddMember called at /srv/koha_ffzg/C4/Auth_with_ldap.pm line 213. It occurs only under plack, and it's strange since C4::Members does EXPORT AddMember and we are importing it into Auth_with_ldap.pm (and it does work under CGI). Signed-off-by: Liz Rea <liz@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> I did not test but trust author and signoffer. The change cannot hurt. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Claudio <costalc@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |costalc@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Dobrica! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.04. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #19 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x for 3.22.17 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #20 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.10 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|Oldversions |--- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29560 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29560 | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org