[Bug 26576] New: Subfield descriptions on authority detail view are cut off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26576 Bug ID: 26576 Summary: Subfield descriptions on authority detail view are cut off Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org When looking at the details of a MARC authority record on the staff interface, the descriptions of the subfields are cut off. The title attribute has the full description, but in the span it's cut off in the middle: /cgi-bin/koha/authorities/detail.pl?authid=... The field descriptions display fully. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26576 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26576 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 111000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111000&action=edit Bug 26576: Subfield descriptions on authority detail view are cut off This patch corrects the authority detail view on the staff interface so that subfield descriptions are not longer output as truncated strings. For instance, before this patch the subfield description for 035$a would be "System control numbe" After the patch it should be "System control number." Based on the assumption that the subfield descriptions were truncated at some point for readability reasons I've also made some style changes intended to improve the readability of the page. To test, apply the patch and go to Authorities. - Search for and view the details for an authority. - On the authority detail page, confirm that subfield descriptions are shown in full. - Confirm that the style changes look good and make the data more readable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26576 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26576 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111000|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 111044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111044&action=edit Bug 26576: Subfield descriptions on authority detail view are cut off This patch corrects the authority detail view on the staff interface so that subfield descriptions are not longer output as truncated strings. For instance, before this patch the subfield description for 035$a would be "System control numbe" After the patch it should be "System control number." Based on the assumption that the subfield descriptions were truncated at some point for readability reasons I've also made some style changes intended to improve the readability of the page. To test, apply the patch and go to Authorities. - Search for and view the details for an authority. - On the authority detail page, confirm that subfield descriptions are shown in full. - Confirm that the style changes look good and make the data more readable. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26576 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I like the visual improvements. My only minor quibble (and I don't have any suggestions) is that the italic text in blue - people may think it is a link. Everywhere else in the staff interface, such as the catalog, thinks you can click on such as the subjects or authors are in blue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26576 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26576 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111044|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111535&action=edit Bug 26576: Subfield descriptions on authority detail view are cut off This patch corrects the authority detail view on the staff interface so that subfield descriptions are not longer output as truncated strings. For instance, before this patch the subfield description for 035$a would be "System control numbe" After the patch it should be "System control number." Based on the assumption that the subfield descriptions were truncated at some point for readability reasons I've also made some style changes intended to improve the readability of the page. To test, apply the patch and go to Authorities. - Search for and view the details for an authority. - On the authority detail page, confirm that subfield descriptions are shown in full. - Confirm that the style changes look good and make the data more readable. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26576 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Nind from comment #3)
I like the visual improvements.
My only minor quibble (and I don't have any suggestions) is that the italic text in blue - people may think it is a link.
Everywhere else in the staff interface, such as the catalog, thinks you can click on such as the subjects or authors are in blue.
I talked to Owen and he pointed out that the color is the same as is used for the subfield descriptions in the basic editor. I think that means we could deal with working out a different color scheme on a separate bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26576 --- Comment #6 from David Nind <david@davidnind.com> --- +1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26576 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26576 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26576 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- does not apply cleanly to 20.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org