[Bug 41172] New: Checkouts table does not have the sort icon indicator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41172 Bug ID: 41172 Summary: Checkouts table does not have the sort icon indicator Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41172 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 188977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188977&action=edit Bug 41172: Fix sort indicator display on the checkouts table -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41172 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 188978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188978&action=edit Bug 41172: Same for the other occurrence -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41172 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- I don't have test to continue right now. We should now remove the 2 extra columns that are no longer needed (and remove from columns_settings.yml?) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41172 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197691&action=edit Bug 41172: Improve grouping and ordering on the checkouts table Patch from commit a156836 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41172 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24533 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24533 [Bug 24533] Improved sorting in checkouts table -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41172 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | Summary|Checkouts table does not |Improve grouping and |have the sort icon |sorting on the checkouts |indicator |table Status|NEW |In Discussion Severity|normal |enhancement CC| |martin.renvoize@openfifth.c | |o.uk --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- I was back to this bug and noticed that the sorting indicator was now correct. However I have noticed several things that could be improved using the original idea of the first patches: 1. Do not use orderData so we don't have to keep the ID of the columns in sync 2. Remove the 2 columns used for sorting dates (not needed with data: {_,sort}) 3. Keep the grouping on Today/Previous using orderFixed 4. Do not use ID of the due_date column to hide/show the grouping feature. Martin, can you have a quick look please? If you agree I can apply this change to the other tables in this file. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41172 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41172 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- There is a behaviour change but I think it makes sense: Today's checkouts are always at the top. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org