https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16459 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16459 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger@foundations.ed |jonathan.druart@bugs.koha-c |u |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16459 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #2)

The patron card creator link on the tools home page uses: CAN_user_tools_label_creator I think that would make sense to me overall.

Yes but it's the only script in this directory, others use catalogue. Moreover patroncards/edit-batch.pl, which calls add_user_search.pl, uses catalogue also, it would not make sense to have different perms. If we need to fix the whole module, it should be done on another bug report. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16459 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #5 from Marc Véron <veron@veron.ch> --- Tested with patch: - Set permissions 'catalogue' and 'label_creator' - Go to Home > Tools > Patron card creator - New card batch - Add patrons - Search windows pops up. Do a search. Result: Endless "Processing" - Set addtitionally permission 'borrowers' Result: Search window works as expected, patrons are found and can be selected. I think there should be two separate permissions for '...creator', one for labels ('label_creator') and one for patron cards ('patroncard_creator'). The latter would then additionally need 'borrowers' (with a hint in the description) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16459 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51295|0 |1 is obsolete| | --- Comment #6 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 51704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51704&action=edit [SIGNED-OFF] Bug 16459: Add patron to a patron card requires catalogue permission Currently, serials => 'routing' is required, which does not make any sense. It's a copy/paste error when this file has been created (you can blame me). Note that I am not sure catalogue is the correct permission, but it's the one used almost everywhere in this module Test plan: Confirm that catalogue is enough to search for patrons to add to a patron card. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16459 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51704|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 52814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52814&action=edit Bug 16459: Add patron to a patron card requires catalogue permission Currently, serials => 'routing' is required, which does not make any sense. It's a copy/paste error when this file has been created (you can blame me). Note that I am not sure catalogue is the correct permission, but it's the one used almost everywhere in this module Test plan: Confirm that catalogue is enough to search for patrons to add to a patron card. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16459 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #9 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.02. -- You are receiving this mail because: You are watching all bug changes.