[Bug 13767] New: Readonly::XS (1:02) is not installed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 Bug ID: 13767 Summary: Readonly::XS (1:02) is not installed Change sponsored?: --- Product: Koha Version: 3.18 Hardware: PC OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: isabelaterra@cp2.g12.br QA Contact: testopia@bugs.koha-community.org I'm really looking for some help here, please, my brain (whatever is left!) Is swimming in Perl code. All perl modules are present (except tells me que Readonly :: XS (1:02) is not installed, but I have 1.05), permissions Have Been verified, ps -u koha shows the daemon and zebrasrv running, mysqlcheck is clean, etc. Searches return empty and analytical reports report that is registered in the database. I'm using Debian 7 u3 and Koha 3.18. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mtompset@hotmail.com Assignee|gmcharlt@gmail.com |mtompset@hotmail.com --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- It has been annoying me too, Isabela. However, this is not a problem to really worry about if: $ dpkg -l libreadonly-xs-perl displays a version higher than 1.02, which you (and I) both have. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38521&action=edit Bug 13767: Fix Readonly::XS version detection The about.pl screen is unable to see that version 1.05-1+b1 is installed because eval "require Readonly::XS" returns an error message telling you that you can't use Readonly::XS directly. Since it is the only one, we attempt to use /usr/bin/dpkg to determine the version number. TEST PLAN --------- 1) $ dpkg -l libreadonly-xs-perl -- note the version number 2) Log in to staff client 3) About Koha -> Perl modules -- note it says Readonly::XS is not installed. -- note the versions and colours of the other modules. 4) Apply patch 5) Reload page and go to Perl modules tab -- Readonly::XS should list the version noted in step 1. -- the other modules' output should be unchanged. 6) Run koha qa test tools For non-debian systems lacking a /usr/bin/dpkg, the output would be identical since the version number variable is left undefined, which is true for the criteria used for the missing logic. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #3 from Marc Véron <veron@veron.ch> --- dpkg -l libreadonly-xs-perl Gewünscht=Unbekannt/Installieren/R=Entfernen/P=Vollständig Löschen/Halten | Status=Nicht/Installiert/Config/U=Entpackt/halb konFiguriert/ Halb installiert/Trigger erWartet/Trigger anhängig |/ Fehler?=(kein)/R=Neuinstallation notwendig (Status, Fehler: GROSS=schlecht) ||/ Name Version Architektur Beschreibung +++-==================================-======================-======================-========================================================================= ii libreadonly-xs-perl 1.04-2+b3 amd64 Faster Readonly implementation Staff client > About Koha without patch: Koha : About without patch: Readonly::XS (1.02) 1.04 Staff client > About Koha with patch: Readonly::XS (1.02) Not Installed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38521|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38526&action=edit Bug 13767: Fix Readonly::XS version detection The about.pl screen is unable to see that version 1.05-1+b1 is installed because eval "require Readonly::XS" returns an error message telling you that you can't use Readonly::XS directly. Since it is the only one, we attempt to use /usr/bin/dpkg to determine the version number. TEST PLAN --------- 1) $ dpkg -l libreadonly-xs-perl -- note the version number 2) Log in to staff client 3) About Koha -> Perl modules -- note it says Readonly::XS is not installed. -- note the versions and colours of the other modules. 4) Apply patch 5) Reload page and go to Perl modules tab -- Readonly::XS should list the version noted in step 1. -- the other modules' output should be unchanged. 6) Run koha qa test tools For non-debian systems lacking a /usr/bin/dpkg, the output would be identical since the version number variable is left undefined, which is true for the criteria used for the missing logic. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38526|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38527&action=edit Bug 13767: Fix Readonly::XS version detection The about.pl screen is unable to see that version 1.05-1+b1 is installed because eval "require Readonly::XS" returns an error message telling you that you can't use Readonly::XS directly. Since it is the only one, we attempt to use /usr/bin/dpkg to determine the version number. TEST PLAN --------- 1) $ dpkg -l libreadonly-xs-perl -- note the version number 2) Log in to staff client 3) About Koha -> Perl modules -- note it says Readonly::XS is not installed. -- note the versions and colours of the other modules. 4) Apply patch 5) Reload page and go to Perl modules tab -- Readonly::XS should list the version noted in step 1. -- the other modules' output should be unchanged. 6) Run koha qa test tools For non-debian systems lacking a /usr/bin/dpkg, the output would be identical since the version number variable is left undefined, which is true for the criteria used for the missing logic. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 --- Comment #6 from Marc Véron <veron@veron.ch> --- Results with new patch: dpkg -l libreadonly-xs-perl Result: ii libreadonly-xs-perl 1.04-2+b3 amd64 Faster Readonly implementation Staff client > About Koha without patch Readonly::XS (1.02) 1.04 Staff client > About Koha with patch Readonly::XS (1.02) 1.04 The result is now the same with and without patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 --- Comment #7 from Marc Véron <veron@veron.ch> --- To test what happens if libreadonly-xs-perl is not installed, I did: apt-get remove libreadonly-xs-perl On the about page, I get now: Readonly::XS (1.02) | [nothing in column for version number] I would expect: Readonly::XS (1.02) | Not installed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Still looking for a nicer way. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38527|0 |1 is obsolete| | --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38528 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38528&action=edit Bug 13767: Fix Readonly::XS version detection The about.pl screen is unable to see that version 1.05-1+b1 is installed because eval "require Readonly::XS" returns an error message telling you that you can't use Readonly::XS directly. Since it is the only one, we attempt to use /usr/bin/dpkg to determine the version number. TEST PLAN --------- 1) $ dpkg -l libreadonly-xs-perl -- note the version number 2) Log in to staff client 3) About Koha -> Perl modules -- note it says Readonly::XS is not installed. -- note the versions and colours of the other modules. 4) Apply patch 5) Reload page and go to Perl modules tab -- Readonly::XS should list the version noted in step 1. -- the other modules' output should be unchanged. 6) Run koha qa test tools For non-debian systems lacking a /usr/bin/dpkg, the output would be identical since the version number variable is left undefined, which is true for the criteria used for the missing logic. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.18 |master Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38528|0 |1 is obsolete| | --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38531 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38531&action=edit Bug 13767: Fix Readonly::XS version detection The about.pl screen is unable to see that version 1.05-1+b1 is installed because eval "require Readonly::XS" returns an error message telling you that you can't use Readonly::XS directly. Since it is the only one, we attempt to use /usr/bin/dpkg to determine the version number. TEST PLAN --------- 1) $ dpkg -l libreadonly-xs-perl -- note the version number 2) Log in to staff client 3) About Koha -> Perl modules -- note it says Readonly::XS is not installed. -- note the versions and colours of the other modules. 4) Apply patch 5) Reload page and go to Perl modules tab -- Readonly::XS should list the version noted in step 1. -- the other modules' output should be unchanged. 6) Run koha qa test tools All systems running Koha will have perldoc installed. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 --- Comment #11 from Marc Véron <veron@veron.ch> --- Created attachment 38532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38532&action=edit [Signed-off] Bug 13767: Fix Readonly::XS version detection The about.pl screen is unable to see that version 1.05-1+b1 is installed because eval "require Readonly::XS" returns an error message telling you that you can't use Readonly::XS directly. Since it is the only one, we attempt to use /usr/bin/dpkg to determine the version number. TEST PLAN --------- 1) $ dpkg -l libreadonly-xs-perl -- note the version number 2) Log in to staff client 3) About Koha -> Perl modules -- note it says Readonly::XS is not installed. -- note the versions and colours of the other modules. 4) Apply patch 5) Reload page and go to Perl modules tab -- Readonly::XS should list the version noted in step 1. -- the other modules' output should be unchanged. 6) Run koha qa test tools All systems running Koha will have perldoc installed. :) ---- Tested with an without Readonly::XS 1.04 installed. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38531|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |jonathan.druart@biblibre.co | |m --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- When QAing this patch, I was wondering why we used Readonly and Readonly::XS. And actually I did not find valid reasons. I have opened bug 14066 to remove these packages. If valided, it will invalid this one. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14066 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 --- Comment #13 from M. Tompsett <mtompset@hotmail.com> --- I think Jonathan's solution of removing the dependency is better. :) I just tweaked up his solution on bug 14066. Feel free to test it and sign off. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 --- Comment #14 from M. Tompsett <mtompset@hotmail.com> --- Bug 14066 passed QA, and I believe Katrin has gotten the remaining tiny pieces we missed all cleaned up. Once pushed to master, this should be resolved/closed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|In Discussion |RESOLVED --- Comment #15 from M. Tompsett <mtompset@hotmail.com> --- This was properly fixed and pushed to master by bug 14066. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org