[Bug 42454] New: Terminology: Use "and" instead of "&" for curbside pickups "Staged & ready (0)" tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42454 Bug ID: 42454 Summary: Terminology: Use "and" instead of "&" for curbside pickups "Staged & ready (0)" tab Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com The "Staged & ready (0)" tab for curbside pickups (Circulation > Holds and bookings > Curbside pickup) should use "and" instead of "&". See terminology guidelines for "& (ampersand)" - Only use "&" when part of a proper noun or a common abbreviation,... Otherwise, use "and": https://wiki.koha-community.org/wiki/Terminology#characters To reproduce: 1. Enable the CurbsidePickup system preference. 2. Configure curbside pickup for Centerville: - Go to Administration > Patrons and circulation > Curbside pickup - Set values: . Enable: selected . Pickup interval: 5 . Maximum patrons per interval: 1 . Patron-scheduled pickup: selected . Enable for waiting holds only: selected . Curbside pickup hours: add from and to hours for some days . Click Save configuration 3. Go to Circulation > Holds and bookings > Curbside pickup. 4. Note that there is an '&' in the "Staged & ready (0)" tab title. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42454 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Assignee|koha-bugs@lists.koha-commun |david@davidnind.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42454 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42454 --- Comment #1 from David Nind <david@davidnind.com> --- Created attachment 198074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198074&action=edit Bug 42454: Terminology: Use "and" instead of "&" for curbside pickups tab The "Staged & ready (0)" tab for curbside pickups (Circulation > Holds and bookings > Curbside pickup) should use "and" instead of "&". See terminology guidelines for "& (ampersand)" - Only use "&" when part of a proper noun or a common abbreviation,... Otherwise, use "and": https://wiki.koha-community.org/wiki/Terminology#characters Test plan: 1. Enable the CurbsidePickup system preference. 2. Configure curbside pickup for Centerville: - Go to Administration > Patrons and circulation > Curbside pickup - Set values: . Enable: selected . Pickup interval: 5 . Maximum patrons per interval: 1 . Patron-scheduled pickup: selected . Enable for waiting holds only: selected . Curbside pickup hours: add from and to hours for some days . Click Save configuration 3. Go to Circulation > Holds and bookings > Curbside pickup. 4. Note that there is an '&' in the "Staged & ready (0)" tab title. 5. Apply the patch. 6. Refresh the page. 7. Note that and is spelt in full "Stage and ready (0)". Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42454 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the "Staged & release notes| |ready (0)" tab for curbside | |pickups (Circulation > | |Holds and bookings > | |Curbside pickup) so that it | |uses "and" instead of "&" | |in the table title, as per | |the terminology guidelines | |(when CurbsidePickup is | |enabled). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42454 Alex Carver [Acerock7] <alex@rcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #2 from Alex Carver [Acerock7] <alex@rcls.org> --- Works as described. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42454 Alex Carver [Acerock7] <alex@rcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198074|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42454 --- Comment #3 from Alex Carver [Acerock7] <alex@rcls.org> --- Created attachment 198157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198157&action=edit Bug 42454: Terminology: Use "and" instead of "&" for curbside pickups tab The "Staged & ready (0)" tab for curbside pickups (Circulation > Holds and bookings > Curbside pickup) should use "and" instead of "&". See terminology guidelines for "& (ampersand)" - Only use "&" when part of a proper noun or a common abbreviation,... Otherwise, use "and": https://wiki.koha-community.org/wiki/Terminology#characters Test plan: 1. Enable the CurbsidePickup system preference. 2. Configure curbside pickup for Centerville: - Go to Administration > Patrons and circulation > Curbside pickup - Set values: . Enable: selected . Pickup interval: 5 . Maximum patrons per interval: 1 . Patron-scheduled pickup: selected . Enable for waiting holds only: selected . Curbside pickup hours: add from and to hours for some days . Click Save configuration 3. Go to Circulation > Holds and bookings > Curbside pickup. 4. Note that there is an '&' in the "Staged & ready (0)" tab title. 5. Apply the patch. 6. Refresh the page. 7. Note that and is spelt in full "Stage and ready (0)". Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Alex Carver [Acerock7] <alex@rcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42454 --- Comment #4 from David Nind <david@davidnind.com> --- Thanks for the signoff Alex! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42454 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |Laura.escamilla@bywatersolu |y.org |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42454 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198157|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42454 --- Comment #5 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 199712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199712&action=edit Bug 42454: Terminology: Use "and" instead of "&" for curbside pickups tab The "Staged & ready (0)" tab for curbside pickups (Circulation > Holds and bookings > Curbside pickup) should use "and" instead of "&". See terminology guidelines for "& (ampersand)" - Only use "&" when part of a proper noun or a common abbreviation,... Otherwise, use "and": https://wiki.koha-community.org/wiki/Terminology#characters Test plan: 1. Enable the CurbsidePickup system preference. 2. Configure curbside pickup for Centerville: - Go to Administration > Patrons and circulation > Curbside pickup - Set values: . Enable: selected . Pickup interval: 5 . Maximum patrons per interval: 1 . Patron-scheduled pickup: selected . Enable for waiting holds only: selected . Curbside pickup hours: add from and to hours for some days . Click Save configuration 3. Go to Circulation > Holds and bookings > Curbside pickup. 4. Note that there is an '&' in the "Staged & ready (0)" tab title. 5. Apply the patch. 6. Refresh the page. 7. Note that and is spelt in full "Stage and ready (0)". Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Alex Carver [Acerock7] <alex@rcls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42454 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42454 --- Comment #6 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42454 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.11.00 |26.11.00,26.05.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42454 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.01 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42454 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00,26.05.01 |26.11.00,26.05.01,25.11.06 released in| | CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #8 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 25.11.x for 25.11.06 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42454 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 25.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42454 Catrina Berka <catrina@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |CLOSED CC| |catrina@bywatersolutions.co | |m Resolution|--- |FIXED --- Comment #10 from Catrina Berka <catrina@bywatersolutions.com> --- No documentation needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42454 Catrina Berka <catrina@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42454 --- Comment #11 from Catrina Berka <catrina@bywatersolutions.com> --- Mention on this page in the manual needs updating and new screenshot: https://koha-community.org/manual/latest/en/html/circulation.html#curbside-p... -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org