[Bug 12307] New: Catalog details page displaying incorrect status for items with itemtype level notforloan status
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307 Bug ID: 12307 Summary: Catalog details page displaying incorrect status for items with itemtype level notforloan status Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl The template markup that controls that status column for the items table in catalogue/detail.pl does not account for the itemtypes.notforloan flag. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28420&action=edit Bug 12307 - Catalog details page displaying incorrect status for items with itemtype level notforloan status The template markup that controls that status column for the items table in catalogue/detail.pl does not account for the itemtypes.notforloan flag. Test Plan: 1) Find an item that is currently available 2) Go to the itemtype editor and mark that itemtype of that item as being not for loan 3) Browse to the catalog details page for that item's record 4) Note the item status is still "Available" 5) Apply this patch 6) Reload the catalog details page 7) Note the item status is now "Not for loan" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12419 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- This looks similar than bug 12419 (but not the same view). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #3 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- We didn't understand the bug to be fixed, we could not manage to see the bug on the master version in english, we give up. The bug should be explained with more details. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Koha Team Lyon 3 from comment #3)
We didn't understand the bug to be fixed, we could not manage to see the bug on the master version in english, we give up. The bug should be explained with more details.
See with Lyon 3, the item-level_itypes pref should be set to "item specific". They use "biblio record", so they won't test this patch. But no regression found for biblio level :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307 --- Comment #5 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 29491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29491&action=edit [SIGNED OFF] Bug 12307 - Catalog details page displaying incorrect status for items with itemtype level notforloan status The template markup that controls that status column for the items table in catalogue/detail.pl does not account for the itemtypes.notforloan flag. Test Plan: 1) Find an item that is currently available 2) Go to the itemtype editor and mark that itemtype of that item as being not for loan 3) Browse to the catalog details page for that item's record 4) Note the item status is still "Available" 5) Apply this patch 6) Reload the catalog details page 7) Note the item status is now "Not for loan" Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28420|0 |1 is obsolete| | CC| |nick@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29491|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 29527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29527&action=edit [PASSED QA] Bug 12307 - Catalog details page displaying incorrect status for items with itemtype level notforloan status The template markup that controls that status column for the items table in catalogue/detail.pl does not account for the itemtypes.notforloan flag. Test Plan: 1) Find an item that is currently available 2) Go to the itemtype editor and mark that itemtype of that item as being not for loan 3) Browse to the catalog details page for that item's record 4) Note the item status is still "Available" 5) Apply this patch 6) Reload the catalog details page 7) Note the item status is now "Not for loan" Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Good catch! Works as described, no problems found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Brendan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org