[Bug 28955] New: We need a way to set default branch from apache
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Bug ID: 28955 Summary: We need a way to set default branch from apache Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org With the moved of some system preferences to News blocks we need a way to set the default branch from apache such that we can display the right block prior to users login. We used to use SetEnvIf to set various prefs per domain.. it would be great to be able to do the same from branchcode so the News blocks behave as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|We need a way to set |Add option to set default |default branch from apache |branch from Apache Assignee|oleonard@myacpl.org |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #1 from David Cook <dcook@prosentient.com.au> --- With a Plack-enabled site, I imagine we'd need to send a custom http header to achieve that? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jake.deery@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Janet McGowan <janet.mcgowan@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- I wonder if we should actually implement this in Plack, as I think a long-term goal would be to move away from Apache httpd as the reverse proxy. It could help move towards a more multitenanted Koha as well. Might be worthwhile looking at Julian's work on that... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29332 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29332 [Bug 29332] AdditionalContents displays blocks for all libraries prior to login -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126989&action=edit Bug 28955: Add OPAC_BRANCH_DEFAULT This patch adds support for OPAC_BRANCH_DEFAULT as an environment option that can be passed via apache with either SetEnv or as a header for plack. It allows setting a default branch for the anonymous opac session such that you can display the right opac content blocks prior to login if you have set up per branch URI's. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Bug 28955 depends on bug 29332, which changed state. Bug 29332 Summary: AdditionalContents displays blocks for every library prior to login https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29332 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126989|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 128507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128507&action=edit Bug 28955: Add OPAC_BRANCH_DEFAULT This patch adds support for OPAC_BRANCH_DEFAULT as an environment option that can be passed via apache with either SetEnv or as a header for plack. It allows setting a default branch for the anonymous opac session such that you can display the right opac content blocks prior to login if you have set up per branch URI's. To test (on top of bug 29691) 1 - Add to apache conf (/etc/apache2/sites-available/kohadev.conf) SetEnv OPAC_BRANCH_DEFAULT "CPL" RequestHeader add X-Koha-SetEnv "OPAC_BRANCH_DEFAULT CPL" 2 - Restart all 3 - Confirm that news for all and CPL show on opac mainpage 4 - Sign in as a different library 5 - Confirm users library news shows Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm escalating this one a bit as really it's a regression rather than an enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- 1. Shouldn't only be passed to the templates for OPAC interface? 2. You are assuming that this "branchcode" variable is passed only for this purpose. Is that true? 3. Where is this "branchcode" actually passed to the template? 4. Did you see that sometimes "logged_in_user.branchcode" is used (opac-main.tt)? Not sure this is correct actually. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Martin Renvoize from comment #5)
I'm escalating this one a bit as really it's a regression rather than an enhancement.
How is it a regression? I don't think it was possible before either. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- It's a regression in so much as when these were system preferences rather than news blocks you could set them in the apache environment to get a different OPAC look depending on the URL of the virtual host. That is impossible since the move from syspref to news and is causing a number of our upgrades pain. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128507|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 128569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128569&action=edit Bug 28955: Add OPAC_BRANCH_DEFAULT This patch adds support for OPAC_BRANCH_DEFAULT as an environment option that can be passed via apache with either SetEnv or as a header for plack. It allows setting a default branch for the anonymous opac session such that you can display the right opac content blocks prior to login if you have set up per branch URI's. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 128570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128570&action=edit Bug 28955: (follow-up) Set to fall back This patch updates the original fix to only set the template parameter for opac sessions and updates all occurences in templats to check first for logged_in_user.branchcode before falling back to default_branch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #6)
1. Shouldn't only be passed to the templates for OPAC interface?
Done
2. You are assuming that this "branchcode" variable is passed only for this purpose. Is that true?
Renamed to 'default_branch'
3. Where is this "branchcode" actually passed to the template?
I've switched to using a new default_branch and it's always passed for OPAC templates
4. Did you see that sometimes "logged_in_user.branchcode" is used (opac-main.tt)? Not sure this is correct actually.
It looks like most occurrences have no actually switched from 'branchcode' to 'logged_in_user.branchcode'.. I've updated all templates to use `logged_in_branch.branchcode || default_branch` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29691 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Can you rebase pleae? error: sha1 information is lacking or useless (C4/Auth.pm). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128569|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130819&action=edit Bug 28955: Add OPAC_BRANCH_DEFAULT This patch adds support for OPAC_BRANCH_DEFAULT as an environment option that can be passed via apache with either SetEnv or as a header for plack. It allows setting a default branch for the anonymous opac session such that you can display the right opac content blocks prior to login if you have set up per branch URI's. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128570|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130820&action=edit Bug 28955: (follow-up) Set to fall back This patch updates the original fix to only set the template parameter for opac sessions and updates all occurences in templats to check first for logged_in_user.branchcode before falling back to default_branch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130819|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130823&action=edit Bug 28955: Add OPAC_BRANCH_DEFAULT This patch adds support for OPAC_BRANCH_DEFAULT as an environment option that can be passed via apache with either SetEnv or as a header for plack. It allows setting a default branch for the anonymous opac session such that you can display the right opac content blocks prior to login if you have set up per branch URI's. To test (on top of bug 29691) 1 - Add to apache conf (/etc/apache2/sites-available/kohadev.conf) SetEnv OPAC_BRANCH_DEFAULT "CPL" RequestHeader add X-Koha-SetEnv "OPAC_BRANCH_DEFAULT CPL" 2 - Restart all 3 - Confirm that news for all and CPL show on opac mainpage 4 - Sign in as a different library 5 - Confirm users library news shows Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130820|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130824&action=edit Bug 28955: (follow-up) Set to fall back This patch updates the original fix to only set the template parameter for opac sessions and updates all occurences in templats to check first for logged_in_user.branchcode before falling back to default_branch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Rebased :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> ---
3 - Confirm that news for all and CPL show on opac mainpage
This is failing. We are not impacting "News", but "HTML customizations". Is the test plan wrong or we are missing something in the patch? What was the previous behaviour? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130862&action=edit Bug 28955: Impact News as well -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #19)
Created attachment 130862 [details] [review] Bug 28955: Impact News as well
We could go with this trivial patch, do you agree? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I lifted the test plan from Nicks comment, but I forgot to set bug 29691 as a dependency. However, I like the simplicity of your patch and would happily go with it in the interim and reverse the dependencies whilst we work out the fix for the current FQA bug above. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130823|0 |1 is obsolete| | Attachment #130824|0 |1 is obsolete| | Attachment #130862|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130949&action=edit Bug 28955: Add OPAC_BRANCH_DEFAULT This patch adds support for OPAC_BRANCH_DEFAULT as an environment option that can be passed via apache with either SetEnv or as a header for plack. It allows setting a default branch for the anonymous opac session such that you can display the right opac content blocks prior to login if you have set up per branch URI's. To test (on top of bug 29691) 1 - Add to apache conf (/etc/apache2/sites-available/kohadev.conf) SetEnv OPAC_BRANCH_DEFAULT "CPL" RequestHeader add X-Koha-SetEnv "OPAC_BRANCH_DEFAULT CPL" 2 - Restart all 3 - Confirm that news for all and CPL show on opac mainpage 4 - Sign in as a different library 5 - Confirm users library news shows Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 --- Comment #23 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130950&action=edit Bug 28955: (follow-up) Set to fall back This patch updates the original fix to only set the template parameter for opac sessions and updates all occurences in templats to check first for logged_in_user.branchcode before falling back to default_branch Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 --- Comment #24 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130951&action=edit Bug 28955: Impact News as well Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Add support for release notes| |OPAC_BRANCH_DEFAULT as an | |environment option. | |It | |allows setting a default | |branch for the anonymous | |OPAC session such that you | |can display the right OPAC | |content blocks prior to | |login if you have set up | |per branch website. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 --- Comment #25 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Doesn't apply to 21.11.x. If this should be backported please rebase and ping me! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 131833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131833&action=edit Bug 28955: Add OPAC_BRANCH_DEFAULT [21.11] This patch adds support for OPAC_BRANCH_DEFAULT as an environment option that can be passed via apache with either SetEnv or as a header for plack. It allows setting a default branch for the anonymous opac session such that you can display the right opac content blocks prior to login if you have set up per branch URI's. To test (on top of bug 29691) 1 - Add to apache conf (/etc/apache2/sites-available/kohadev.conf) SetEnv OPAC_BRANCH_DEFAULT "CPL" RequestHeader add X-Koha-SetEnv "OPAC_BRANCH_DEFAULT CPL" 2 - Restart all 3 - Confirm that news for all and CPL show on opac mainpage 4 - Sign in as a different library 5 - Confirm users library news shows Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 131834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131834&action=edit Bug 28955: (follow-up) Set to fall back [21.11] This patch updates the original fix to only set the template parameter for opac sessions and updates all occurences in templats to check first for logged_in_user.branchcode before falling back to default_branch Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 131835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131835&action=edit Bug 28955: Impact News as well [21.11] Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00; 21.11.07 released in| | --- Comment #30 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Pushed to 21.11 for 21.11.07, thx! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |victor@tuxayo.net --- Comment #31 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Missing dependencies for 21.05.x, it shouldn't be affected, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/568 Resolution|--- |FIXED Documentation| |Martin Renvoize contact| | Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29691 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29691 [Bug 29691] Use template plugins to display opac news on homepage -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org