[Bug 26340] New: Printing labels without zero(s) in the start of labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Bug ID: 26340 Summary: Printing labels without zero(s) in the start of labels Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger@foundations.edu Reporter: ivan.dziuba@inlibro.com QA Contact: testopia@bugs.koha-community.org TO TEST: 1. Go Tools > Label creator 2. Click +New -> Barcode range 3. Print barcode range with zero(s) in the start (Ex. from 00011881 to 00012000 ) 4. Select a template to be applied:: Code à barre 48467 Select a layout to be applied: Code à barres 5. Export 6. Open PDF The prefix is not displayed. We should see 00011881 on the labels, but we see 11881, 11882, ... without zeros in the start of labels. This patch fix it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.05 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 --- Comment #1 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Created attachment 109441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109441&action=edit Bug 26340: Printing labels without zero(s) in the start of labels -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109441|0 |1 is obsolete| | --- Comment #2 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Created attachment 109442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109442&action=edit Bug 26340: Printing labels without zero(s) in the start of labels TO TEST: 1. Go Tools > Label creator 2. Click +New -> Barcode range 3. Print barcode range with zero(s) in the start (Ex. from 00011881 to 00012000 ) 4. Select a template to be applied:: Code à barre 48467 Select a layout to be applied: Code à barres 5. Export 6. Open PDF The prefix is not displayed. We should see 00011881 on the labels, but we see 11881, 11882, ... without zeros in the start of labels. This patch fix it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin@inLibro.com, | |ivan.dziuba@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|ivan.dziuba@inlibro.com |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109442|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 111190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111190&action=edit Bug 26340: Printing labels without zero(s) in the start of labels Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger@foundations.ed |ivan.dziuba@inlibro.com |u | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Ivan, I think this might be your first patch for Koha, so some hints about bugzilla and our tools: 1) Please make sure you set yourself as "Assignee" once you plan on submitting a patch to a bug. 2) When using git bz -e or git bz edit it might seem like you can edit the commit message, but while this will post here, it's not changing the patch file. In order to include the test plan and patch description in your patch, you will have to do so in the git commit step. I will upload an updated patch and have already updated bugzilla :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Printing labels without |When printing labels from a |zero(s) in the start of |barcode range, keep zero |labels |padding -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111653&action=edit Bug 26340: Keep zero padding when printing barcodes from a range When creating barcode labels from a range, the leading zeros of padded barcodes will be removed. They should be kept instead. TO TEST: 1. Go to Tools > Label creator 2. Click +New -> Barcode range 3. Print barcode range with zero(s) in the start (Ex. from 00011881 to 00012000 ) 4. Select a template to be applied:: Code à barre 48467 Select a layout to be applied: Code à barres 5. Export 6. Open PDF The prefix is not displayed. We should see 00011881 on the labels, but we see 11881, 11882, ... without zeros in the start of labels. 7. Apply patch and retest - the zeros should be kept now. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111654&action=edit Bug 26340: (QA follow-up) Rephrase hint on to and from values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111190|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ok, I have a bit of bad news here too - with the patch set it's no longer possible to print unpadded barcodes as it requires the barcodes entered to be of the same length. Example: from 1 to 33 will no longer print. I am not sure what the best fix here would be - maybe check for the numbers to start with zero and only output the hint if they do? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 --- Comment #8 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- (In reply to Katrin Fischer from comment #7)
Ok, I have a bit of bad news here too - with the patch set it's no longer possible to print unpadded barcodes as it requires the barcodes entered to be of the same length. Example: from 1 to 33 will no longer print.
I am not sure what the best fix here would be - maybe check for the numbers to start with zero and only output the hint if they do?
Hi Katrin. Yes, it's my first patch for Koha. I understood your recommendations about 'commit -e' and 'Assignee'. In relation to the same length from and to values. Example from = 0005 and to=10. What we must do? Printing 0005, 0006,...,0010 or 05, 06, ...,10. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think these should be invalid: 001 to 33 22 to 0044 But these should work: 001 to 020 00001 to 00010 1 to 44 4 to 100 Make sense? Either enter them zero padded or not... print according to what was entered. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 --- Comment #10 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- (In reply to Katrin Fischer from comment #9)
I think these should be invalid:
001 to 33 22 to 0044
But these should work:
001 to 020 00001 to 00010 1 to 44 4 to 100
Make sense?
Either enter them zero padded or not... print according to what was entered.
Are you saying that the system should give an error if some field(input from or to) does not contain 0* in the start of number, then the other field must not have 0* in the start of number? Did I understand correctly? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Are you saying that the system should give an error if some field(input from or to) does not contain 0* in the start of number, then the other field must not have 0* in the start of number? Did I understand correctly?
Hi Ivan, I think that could work. Basically what we want to do is support 2 use cases: - Printing numbers without zero padding - Printing numbers with zero padding So the validation needs to work for both cases. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111653|0 |1 is obsolete| | --- Comment #12 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Created attachment 121496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121496&action=edit Bug 26340: Keep zero padding when printing barcodes from a range When creating barcode labels from a range, the leading zeros of padded barcodes will be removed. They should be kept instead. TO TEST: 1. Go to Tools > Label creator 2. Click +New -> Barcode range 3. Print barcode range with zero(s) in the start (Ex. from 00011881 to 00012000 ) 4. Select a template to be applied:: Code à barre 48467 Select a layout to be applied: Code à barres 5. Export 6. Open PDF The prefix is not displayed. We should see 00011881 on the labels, but we see 11881, 11882, ... without zeros in the start of labels. 7. Apply patch and retest - the zeros should be kept now. Signed-off-by: David Nind <david@davidnind.com> Bug 26340: (QA follow-up) Rephrase hint on to and from values Bug 26340: Keep zero padding when printing barcodes from a range -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121496|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Ivan Dziuba <ivan.dziuba@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111654|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 --- Comment #13 from Ivan Dziuba <ivan.dziuba@inlibro.com> --- Created attachment 121923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121923&action=edit Bug 26340: When printing labels from a barcode range, keep zero padding TEST PLAN: 1. Go Tools > Label creator 2. Click +New -> Barcode range 3. Print barcode range with zero(s) in the start (Ex. from 00011881 to 00012000 ) 4. Select a template to be applied:: Code à barre 48467 Select a layout to be applied: Code à barres 5. Export 6. Open PDF The prefix is not displayed. We should see 00011881 on the labels, but we see 11881, 11882, ... without zeros in the start of labels. This patch fix it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Hakam Almotlak <hakam.almotlak@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121923|0 |1 is obsolete| | --- Comment #14 from Hakam Almotlak <hakam.almotlak@inLibro.com> --- Created attachment 122305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122305&action=edit Bug 26340: When printing labels from a barcode range, keep zero padding TEST PLAN: 1. Go Tools > Label creator 2. Click +New -> Barcode range 3. Print barcode range with zero(s) in the start (Ex. from 00011881 to 00012000 ) 4. Select a template to be applied:: Code à barre 48467 Select a layout to be applied: Code à barres 5. Export 6. Open PDF The prefix is not displayed. We should see 00011881 on the labels, but we see 11881, 11882, ... without zeros in the start of labels. This patch fix it. Signed-off-by: hakam <hakam@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Hakam Almotlak <hakam.almotlak@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hakam.almotlak@inLibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Eric Bégin <eric.begin@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|hakam.almotlak@inLibro.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122305|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 122575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122575&action=edit Bug 26340: When printing labels from a barcode range, keep zero padding TEST PLAN: 1. Go Tools > Label creator 2. Click +New -> Barcode range 3. Print barcode range with zero(s) in the start (Ex. from 00011881 to 00012000 ) 4. Select a template to be applied:: Code à barre 48467 Select a layout to be applied: Code à barres 5. Export 6. Open PDF The prefix is not displayed. We should see 00011881 on the labels, but we see 11881, 11882, ... without zeros in the start of labels. This patch fix it. Signed-off-by: hakam <hakam@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 122576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122576&action=edit Bug 26340: (QA follow-up) Remove warns and set input fields hidden again Removes traces of debugging. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Ivan and Hakam, it appears to be working now for both use cases - zero padded or not. So this is good :) I noticed some code changes made, I assume, when debugging. Please be careful about removing those from your patches before submitting! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122777&action=edit Bug 26340: Code simplification And rename $range with $barcode_length -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122777|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122779&action=edit Bug 26340: Code simplification And rename $range with $barcode_length -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #21 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Congratulations, Ivan, for your first patch pushed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Enhancement not backported to 21.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31220 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31220 [Bug 31220] Error when attempting to export selected labels as PDF -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org