https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #237 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry Julian, patches apply, but still some problems: 1) QA scripts Lots of those: FAIL Koha/Baskets.pm FAIL git manipulation The file has been added and deleted in the same patchset Maybe see if you can squash some with the same sign-offer? And: FAIL t/db_dependent/Acquisition/close_reopen_basket.t OK critic OK forbidden patterns OK git manipulation OK pod OK spelling FAIL valid Global symbol "$order1" requires explicit package name Global symbol "$order2" requires explicit package name t/db_dependent/Acquisition/close_reopen_basket.t had compilation errors. FAIL t/db_dependent/Acquisition/Basketgroups.t OK critic OK forbidden patterns OK git manipulation OK pod OK spelling FAIL valid "AddBookseller" is not exported by the C4::Bookseller module Can't continue after import errors 2) Code review a) Koha/Acquisition/Baskets.pm -# Copyright 2017 Aleisha Amohia <aleisha@catalyst.net.nz> -# Why remove the Copyright statement? And POD? b) Similar: Koha/Acquisition/Orders.pm + my $pdfformatfile = './' . ($pdfformat =~ s,::,/,gr) . '.pm'; + require $pdfformatfile; Seems to be an unrelated change? I remember that we hardcoded the valid template names once for added security. could only find one mention of it tho: bug 11459#c11 c) admin/currency.pl +use Koha::Acquisition::Currency; Unrelated change? d) koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroups.tt <th>Bookseller</th> Should be vendor! e) Generate EDIFACT Order Capitalization: Generate EDIFACT order f) Changes to koha-tmpl/intranet-tmpl/prog/js/datatables.js Do you remember why those changes were needed or was it not intentional? Trying to figure out what needs to be tested with this patch and it turns out a lot of code is touched. g) Merge atomicupdates? 3) Unit tests prove t/db_dependent/Acquisition/Basketgroups.t t/db_dependent/Acquisition/Basketgroups.t .. "AddBookseller" is not exported by the C4::Bookseller module Can't continue after import errors at t/db_dependent/Acquisition/Basketgroups.t line 9. BEGIN failed--compilation aborted at t/db_dependent/Acquisition/Basketgroups.t line 9. prove t/db_dependent/Acquisition/close_reopen_basket.t t/db_dependent/Acquisition/close_reopen_basket.t .. Global symbol "$order1" requires explicit package name at t/db_dependent/Acquisition/close_reopen_basket.t line 58. Global symbol "$order2" requires explicit package name at t/db_dependent/Acquisition/close_reopen_basket.t line 68. Execution of t/db_dependent/Acquisition/close_reopen_basket.t aborted due to compilation errors. -- You are receiving this mail because: You are watching all bug changes.