http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 --- Comment #1 from Ian Walls <ian.walls@bywatersolutions.com> 2012-01-04 17:23:25 UTC --- Created attachment 7040 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7040 Proposed Patch ENH 7401: Shelving Location facet instead of Libraries facet when 1 branch only If only a single branch has been configured in the system, it doesn't make sense to show a Libraries facet. A facet of shelving locations within the library would be more helpful to guide users to where to get resources This patch adds Location facets to both the OPAC and staff side only 1 branch is configured. To handle the OPAC v. staff side labels for location codes, a parameter has been added to getRecord in C4::Search. the optional $opac parameter is the last to be passed; 1 indicates OPAC, 0 or undef for staff side. To test: 1. On a system with a single branch, define a shelving location with different OPAC and staff client text 2. perform a search that will retrive some items with that shelving location a. on the OPAC side, you should get OPAC text in the facets b. on the staff side, you should get staff text 3. Add a new branch to the system 4. Repeat the search. Should get the Libraries facet instead of the Locations facet -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED CC| |kyle.m.hall@gmail.com Resolution| |INVALID --- Comment #2 from Kyle M Hall <kyle.m.hall@gmail.com> 2012-02-16 17:16:12 UTC --- It looks like this is already in Koha, but it checks the singleBranchMode, rather than counting the number of branches. So, if singleBranchMode is enabled, the branchcode limiter disappears, but a location limiter appears instead. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 --- Comment #3 from Kyle M Hall <kyle.m.hall@gmail.com> 2012-02-16 17:18:31 UTC --- (In reply to comment #2) It looks like I may be wrong. I'll do some more testing.

It looks like this is already in Koha, but it checks the singleBranchMode, rather than counting the number of branches. So, if singleBranchMode is enabled, the branchcode limiter disappears, but a location limiter appears instead.

-- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 --- Comment #4 from Kyle M Hall <kyle.m.hall@gmail.com> 2012-02-16 17:33:23 UTC --- Created attachment 7700 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7700 Bug 7401 - Shelving Location facet instead of Branch facet when only 1 branch configured Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Did some minor re-working so it uses the singleBranchMode system pref, instead of counting the number or branches. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 --- Comment #5 from Kyle M Hall <kyle.m.hall@gmail.com> 2012-02-16 17:34:59 UTC --- (In reply to comment #4) I should also note that it didn't apply in its original state, but minor adjustments were all that were required to make it work.

Created attachment 7700 [details] Bug 7401 - Shelving Location facet instead of Branch facet when only 1 branch configured

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Did some minor re-working so it uses the singleBranchMode system pref, instead of counting the number or branches.

-- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #6 from Ian Walls <koha.sekjal@gmail.com> 2012-02-17 14:48:35 UTC --- Kyle, SingleBranchMode is buggy, and should be phased out in favour of branch counting (in my opinion). It seems unreasonable to me to have a system preference toggle when the number of configured branches would give you that information. Turning on SingleBranchMode in a multi-branch context is just begging for problems. Hence my usage of branch count instead of the system preference. To the greater community: opinions or thoughts on this? I think we'd eliminate a fair number of problems by phasing SingleBranchMode out, but perhaps some of you know of a worthwhile use-case for keeping it (and keeping it in all it's currently used contexts). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 --- Comment #8 from Kyle M Hall <kyle.m.hall@gmail.com> 2012-02-17 16:24:40 UTC --- (In reply to comment #6) Here are my thoughts: If you use branch counting instead of SingleBranchMode, then it limits the ability to use this. If a group if libraries use SingleBranchMode, why should they not be able to see the shelving facet? I understand the reasoning behind only using it for single libraries ( e.g. We don't want to show locations that don't exist in this library ). So, if SingleBranchMode is indeed to be deprecated, then you are right, and this should go back to branch counting. As far as I can tell, SingleBranchMode is only used in two places, once in Search.pm and twice in Koha.pm, all instances involve facets.

Kyle,

SingleBranchMode is buggy, and should be phased out in favour of branch counting (in my opinion). It seems unreasonable to me to have a system preference toggle when the number of configured branches would give you that information. Turning on SingleBranchMode in a multi-branch context is just begging for problems. Hence my usage of branch count instead of the system preference.

To the greater community: opinions or thoughts on this? I think we'd eliminate a fair number of problems by phasing SingleBranchMode out, but perhaps some of you know of a worthwhile use-case for keeping it (and keeping it in all it's currently used contexts).

-- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 --- Comment #10 from Kyle M Hall <kyle.m.hall@gmail.com> 2012-02-17 16:32:42 UTC --- (In reply to comment #9) I meant C4::Auth, not C4::Context.

Perhaps we should delete the SingleBranchMode system pref, and have C4::Context set it to enabled if the branch count is 1? That way we don't have to go counting the branches each time with GetBranchesLoop().

-- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7040|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7741|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7741|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8188|0 |1 is obsolete| | --- Comment #13 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 8189 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8189&action=edit [SIGNED-OFF] Bug 7401 - Shelving Location facet instead of Branch facet when only 1 branch configured Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Enable for either A) SingleBranchMode is enabled or B) There is only one branch in the branches table Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Tested with one branch and with multiple branches, tested with SingleBranchMode on and off. All tests passed. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #14 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * clean code * I agree with the idea of removing SingleBranch mode, and the GetBranchCount is a 1st step in this direction * a question though = why not having location facet even with multiple branches ? marking passed QA, will push later, once i've the answer to question 3 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #16 from Paul Poulain <paul.poulain@biblibre.com> --- sorry, but this patch does not apply correctly anymore, because of bug 3216, applied 2 weeks ago. The bug 3216 changes the content of the array, from: my $library_facet = { idx => 'branch', label => 'Libraries', tags => [ qw/ 995b / ], expanded => '1', }; to $library_facet = { link_value => 'branch', label_value => 'Libraries', tags => [ '995', ], subfield => 'b', expanded => '1', }; solving this conflict is not trivial, I won't do it myself, sorry for the annoyance to do it again -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 --- Comment #18 from Michael Davis <m.r.davis@cranfield.ac.uk> --- Created attachment 10210 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10210&action=edit [SIGNED-OFF] Bug 7401 - Shelving Location facet instead of Branch facet when only 1 branch configured Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Enable for either A) SingleBranchMode is enabled or B) There is only one branch in the branches table Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Tested with one branch and with multiple branches, tested with SingleBranchMode on and off. All tests passed. Signed-off-by: Michael Davis <m.r.davis@cranfield.ac.uk> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10154|0 |1 is obsolete| | --- Comment #19 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 10154 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10154 Bug 7401 - Shelving Location facet instead of Branch facet when only 1 branch configured patch obsoleted, keeping the other signed-off one -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #21 from Paul Poulain <paul.poulain@biblibre.com> --- sorry, but does not apply once again. Please rebase and switch to passed QA again, and I'll take care of it promptly ! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 kyle.m.hall@gmail.com <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10210|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 kyle.m.hall@gmail.com <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10210|0 |1 is obsolete| | --- Comment #24 from kyle.m.hall@gmail.com <kyle@bywatersolutions.com> --- Created attachment 10817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10817&action=edit Bug 7401 - Shelving Location facet instead of Branch facet when only 1 branch configured Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Enable for either A) SingleBranchMode is enabled or B) There is only one branch in the branches table Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Tested with one branch and with multiple branches, tested with SingleBranchMode on and off. All tests passed. Signed-off-by: Michael Davis <m.r.davis@cranfield.ac.uk> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 --- Comment #25 from kyle.m.hall@gmail.com <kyle@bywatersolutions.com> --- My bad. I took a simple rebase for granted, and missed the fact that an additional variable and been added to GetRecords! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10817|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 10877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10877&action=edit Bug 7401 - Shelving Location facet This patch enables the shelving location facet as an alternative to the branches fact in two situations: A) SingleBranchMode is enabled B) There is only one branch in the branches table Test Plan: 1) Catalog multiple items with different shelving locations. 2) Test enable by enabling SingleBranchMode 3) Test enable by deleting all but one branch Based on initial patch by Ian Walls. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Here is an updated patch. This version is modified enough from the original that I think it should be signed-off on again. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to comment #29)

Created attachment 12241 [details] Shelving location facet showing "*" link

Is it to be expected that one of the facets is "*"--representing items with no shelving location I assume? Or is there a problem with my data? I don't think narrowing a search to items without shelving location is useful to patrons.

Your first assumption is correct. I don't know if we should alter it however, as that is how all the different facets work. If there are items with no value for the given facet, a "*" shows up to represent the 'no value' option. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to comment #31)

...

If there are items with no value for the given facet, a "*" shows up to represent the 'no value' option.

In what situation is this the case?

It happens for branches, as well. But those are the only two though. If a branch has no branchname, it get's a "*" instead. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to comment #33)

(In reply to comment #32)

...

It happens for branches, as well. But those are the only two though. If a branch has no branchname, it get's a "*" instead.

By no branchname, do you mean the item has not homebranch or holdingbranch? I can't reproduce that output.

Even so, it seems like an awfully slim edge case. When would an item not have a branch name? Even in such a case, is it useful to the OPAC user to be able to refine their results to items which *don't* have a branch?

Actually, it appears to mean the branch exists, but doesn't have a name. I agree, it's not very useful. It's code Ian wrote, so I'm not sure if he had a particular reason for doing it that way. I'll post a new patch that should fix this issue. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12253|0 |1 is obsolete| | --- Comment #36 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 12254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12254&action=edit [SIGNED-OFF] Bug 7401 - Shelving Location facet This patch enables the shelving location facet as an alternative to the branches fact in two situations: A) SingleBranchMode is enabled B) There is only one branch in the branches table Test Plan: 1) Catalog multiple items with different shelving locations. 2) Test enable by enabling SingleBranchMode 3) Test enable by deleting all but one branch Based on initial patch by Ian Walls. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Tested cases 2) and 3) successfully in OPAC and staff client -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com QA Contact|koha.sekjal@gmail.com |mtj@kohaaloha.com --- Comment #37 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #36)

Created attachment 12254 [details] [SIGNED-OFF] Bug 7401 - Shelving Location facet Signed-off-by: Owen Leonard <oleonard@myacpl.org>

patch looks good, passing QA… $ koha-qa.pl testing 1 commit(s) (applied to commit 3f31617) * 663f5e5 Bug 7401 - Shelving Location facet C4/Branch.pm C4/Koha.pm C4/Search.pm koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc opac/opac-search.pl * C4/Branch.pm OK * C4/Koha.pm OK * C4/Search.pm OK * opac/opac-search.pl OK * koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc OK * koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc OK -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Shelving Location facet |Show shelving location |instead of Branch facet |facet instead of branch |when only 1 branch |facet when only 1 branch |configured |configured -- You are receiving this mail because: You are watching all bug changes.