[Bug 26595] New: Add SMTP server column to libraries table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26595 Bug ID: 26595 Summary: Add SMTP server column to libraries table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26595 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |kyle@bywatersolutions.com, | |martin.renvoize@ptfs-europe | |.com Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Depends on| |22343 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 [Bug 22343] Add SMTP configuration options to Administration -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26595 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 111122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111122&action=edit Bug 26595: Add Koha::Library->smtp_server_info This patch adds a method for retrieving brief information about the linked (or not) SMTP server for embedding on API requests. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Library.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26595 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 111123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111123&action=edit Bug 26595: Add smtp_server_info embed option to /libraries This patch simply adds the option to embed the return value from Koha::Library->smtp_server_info on the libraries GET actions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26595 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 111124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111124&action=edit Bug 26595: Add SMTP server column to libraries table This patch makes the libraries datatable render the assigned SMTP server on each row. 'Default' will be rendered when the system default is detected. A link to the SMTP server config will be rendered when a real SMTP server is assigned. To test: 1. Apply this patches, reload al the things 2. Visit the libraries table => SUCCESS: There's an SMTP server column displaying the right thing 3. Assign an SMTP server to a library => SUCCESS: The table displays the server name as a link => SUCCESS: The link correctly points to the SMTP server config page 4. Sign off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26595 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 111125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111125&action=edit Bug 26595: Add the option to hide the SMTP server column This patch adds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26595 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26595 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111122|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111155&action=edit Bug 26595: Add Koha::Library->smtp_server_info This patch adds a method for retrieving brief information about the linked (or not) SMTP server for embedding on API requests. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Library.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26595 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111123|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111156&action=edit Bug 26595: Add smtp_server_info embed option to /libraries This patch simply adds the option to embed the return value from Koha::Library->smtp_server_info on the libraries GET actions. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26595 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111124|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111157&action=edit Bug 26595: Add SMTP server column to libraries table This patch makes the libraries datatable render the assigned SMTP server on each row. 'Default' will be rendered when the system default is detected. A link to the SMTP server config will be rendered when a real SMTP server is assigned. To test: 1. Apply this patches, reload al the things 2. Visit the libraries table => SUCCESS: There's an SMTP server column displaying the right thing 3. Assign an SMTP server to a library => SUCCESS: The table displays the server name as a link => SUCCESS: The link correctly points to the SMTP server config page 4. Sign off Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26595 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111125|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111158&action=edit Bug 26595: Add the option to hide the SMTP server column This patch adds Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26595 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All works well, Signing off. Minor feedback.. I wonder if when clicking through to edit smtp server details from the libraries table whether we should redirect back to the libraries table on completion as opposed to being taken to the SMPT servers management page? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26595 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Martin Renvoize from comment #9)
All works well, Signing off.
Minor feedback.. I wonder if when clicking through to edit smtp server details from the libraries table whether we should redirect back to the libraries table on completion as opposed to being taken to the SMPT servers management page?
That's a good point -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26595 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26595 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111155|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111550&action=edit Bug 26595: Add Koha::Library->smtp_server_info This patch adds a method for retrieving brief information about the linked (or not) SMTP server for embedding on API requests. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Library.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26595 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111156|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111551&action=edit Bug 26595: Add smtp_server_info embed option to /libraries This patch simply adds the option to embed the return value from Koha::Library->smtp_server_info on the libraries GET actions. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26595 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111157|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111552&action=edit Bug 26595: Add SMTP server column to libraries table This patch makes the libraries datatable render the assigned SMTP server on each row. 'Default' will be rendered when the system default is detected. A link to the SMTP server config will be rendered when a real SMTP server is assigned. To test: 1. Apply this patches, reload al the things 2. Visit the libraries table => SUCCESS: There's an SMTP server column displaying the right thing 3. Assign an SMTP server to a library => SUCCESS: The table displays the server name as a link => SUCCESS: The link correctly points to the SMTP server config page 4. Sign off Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26595 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111158|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111553&action=edit Bug 26595: Add the option to hide the SMTP server column This patch adds Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26595 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 111606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111606&action=edit Bug 26595: Embed the whole smtp_server object -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26595 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #15)
Created attachment 111606 [details] [review] Bug 26595: Embed the whole smtp_server object
Tomas, why did not you embed the whole whole like in this patch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26595 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #16)
(In reply to Jonathan Druart from comment #15)
Created attachment 111606 [details] [review] [review] Bug 26595: Embed the whole smtp_server object
Tomas, why did not you embed the whole whole like in this patch?
Primarily, because of permissions/security. Someone without the right permissions shouldn't be able to see the user/password settings of an SMTP server. I thought of a workaround to this, making the API not send the password along in the object i.e. make $smtp_server->to_api delete the attribute. But I didn't see a real use case. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26595 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26595 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111606|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26595 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 111621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111621&action=edit Bug 26595: Embed the whole smtp_server object Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26595 --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 111622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111622&action=edit Bug 26595: Remove password from the smtp_server API object This patch makes the SMTP server objects do not include the password for API representation. If we need the password itself, we can add a route to retrieve it with specific permissions. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26595 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26595 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26595 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26595 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26595 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #21 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26595 Bug 26595 depends on bug 22343, which changed state. Bug 22343 Summary: Add configuration options for SMTP servers https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org