[Bug 14077] New: Remove unused AUTH_UPDATE_FAILED from moremember.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14077 Bug ID: 14077 Summary: Remove unused AUTH_UPDATE_FAILED from moremember.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com 'AUTH_UPDATE_FAILED' in moremember.tt is never set and should be removed (see comment #6 on Bug 13910). To verify: git grep 'AUTH_UPDATE_FAILED' Result: Only one occurence (in moremember.tt) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14077 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13910 Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14077 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 38653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38653&action=edit Bug 14077 - Remove unused AUTH_UPDATE_FAILED from moremember.tt 'AUTH_UPDATE_FAILED' in moremember.tt is never set and should be removed (see comment #6 on Bug 13910). To verify: git grep 'AUTH_UPDATE_FAILED' Result: Only one occurence (in moremember.tt) Test plan: - Apply patch (on top of Bug 13910) - Verify that the part with AUTH_UPDATE_FAILED is removed from moremember.tt - Go to a patron's detail page and verify that nothing is broken (Home > Patrons > Patrons details for...) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14077 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13910 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14077 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14077 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38653|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38654 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38654&action=edit Bug 14077 - Remove unused AUTH_UPDATE_FAILED from moremember.tt 'AUTH_UPDATE_FAILED' in moremember.tt is never set and should be removed (see comment #6 on Bug 13910). To verify: git grep 'AUTH_UPDATE_FAILED' Result: Only one occurence (in moremember.tt) Test plan: - Apply patch (on top of Bug 13910) - Verify that the part with AUTH_UPDATE_FAILED is removed from moremember.tt - Go to a patron's detail page and verify that nothing is broken (Home > Patrons > Patrons details for...) Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This has been introduced by commit 1a91801b06607ee9e5f8c21d531a7b7a3ca3b683 Date: Sat Dec 1 20:56:27 2007 -0600 Add Staff member type. Add permissions checks for bug# 1269 and related permissions on memberentry and mods. But was already not used... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14077 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14077 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38654|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38685&action=edit [PASSED QA] Bug 14077 - Remove unused AUTH_UPDATE_FAILED from moremember.tt 'AUTH_UPDATE_FAILED' in moremember.tt is never set and should be removed (see comment #6 on Bug 13910). To verify: git grep 'AUTH_UPDATE_FAILED' Result: Only one occurence (in moremember.tt) Test plan: - Apply patch (on top of Bug 13910) - Verify that the part with AUTH_UPDATE_FAILED is removed from moremember.tt - Go to a patron's detail page and verify that nothing is broken (Home > Patrons > Patrons details for...) Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This has been introduced by commit 1a91801b06607ee9e5f8c21d531a7b7a3ca3b683 Date: Sat Dec 1 20:56:27 2007 -0600 Add Staff member type. Add permissions checks for bug# 1269 and related permissions on memberentry and mods. But was already not used... Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14077 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14077 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org