[Bug 32682] New: Add permission for viewing patron reading history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Bug ID: 32682 Summary: Add permission for viewing patron reading history Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: bwsdonna@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com With intranetreadinghistory it is an all or nothing option - there are often situations where staff will need to view this, but not necessarily every staff member needs to see the information. It would be great to add the ability to view this to the permissions so libraries can decided which staff have this ability. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Donna <bwsdonna@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catrina@bywatersolutions.co | |m, | |hebah@bywatersolutions.com, | |sbrown@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 trevor.diamond@mainlib.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |trevor.diamond@mainlib.org --- Comment #1 from trevor.diamond@mainlib.org --- Hear here! Great idea and as a consortium we are wholeheartedly behind this kind of development. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|22.05 |Main CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 --- Comment #2 from David Flater <flaterdavid@gmail.com> --- Created attachment 183844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183844&action=edit Bug 32682: Add permission for viewing patron reading history -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 --- Comment #3 from David Flater <flaterdavid@gmail.com> --- Created attachment 183845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183845&action=edit Bug 32682: Implement reading history permission -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 --- Comment #4 from David Flater <flaterdavid@gmail.com> --- Created attachment 183846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183846&action=edit Bug 32682: Adjust atomicupdate permission -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Is this ready for testing? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |flaterdavid@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 --- Comment #6 from David Flater <flaterdavid@gmail.com> --- It's not quite ready yet--I'm still working on both a test plan and migrating over old functionality so that libraries don't experience a change in expected functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- Comment on attachment 183844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183844 Bug 32682: Add permission for viewing patron reading history Review of attachment 183844: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=32682&attachment=183844) ----------------------------------------------------------------- ::: installer/data/mysql/atomicupdate/bug_32682_add_permission.pl @@ +24,5 @@
+ # SELECT borrowernumber, 10, 'view_checkout_history' FROM user_permissions WHERE code = 'remaining_permissions' + # } + # ); + + # TODO: migrate libraries' "intranetreadinghistory" syspref (will this require us to not fully remove it until we're sure everyone has migrated off of it?)
This is an interesting question. Technically, I think that you have to keep the intranetreadinghistory because it's impossible to replace it with permissions only. For instance, maybe you disable intranetreadinghistory via Apache configuration because you don't want anyone - even superlibrarians to be able to read the checkout history. If you have libraries with intranetreadinghistory turned off, then these patches will actually cause a regression where anyone with all borrowers permissions will be able to see the reading history when they couldn't previously. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au Status|ASSIGNED |Failed QA --- Comment #8 from David Cook <dcook@prosentient.com.au> --- Failing due to my above comment. On the plus side, with a small adjustment, I think that these patches would be nearly good to go. I suppose the only scenario not covered would be where intranetreadinghistory is enabled and you have limited borrower permissions and you used to be able to read the checkout history and now you can't... I suppose you could add another SQL update that adds the view_checkout_history permission if they had permission to view the pages that this is modifying... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Michael Adamyk <michael.adamyk@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michael.adamyk@bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40364 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40364 [Bug 40364] Add permission for viewing patron holds history -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 --- Comment #9 from David Flater <flaterdavid@gmail.com> --- Created attachment 184571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184571&action=edit Bug 32682: Fix atomicupdate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 David Flater <flaterdavid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183844|0 |1 is obsolete| | --- Comment #10 from David Flater <flaterdavid@gmail.com> --- Created attachment 184572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184572&action=edit Bug 32682: Add permission for viewing patron reading history Create or modify a staff user with edit_borrowers permssion enabled ( Staff A ) Create or modify a staff user without edit_borrowers permssion enabled ( Staff B ) Ensure the "intranetreadinghistory" syspref is enabled Check out an assortment of items to any patron Apply patch, update_database, then restart_all Check the permissions of the staff user A and ensure that they have been automatically assigned the new "view_checkout_history" permission Check the permissions of the staff user B and ensure that they have NOT been automatically assigned the new "view_checkout_history" permission View the same patron and ensure you can still see their checkout history as Staff A and as a superlibrarain Disable the "intranetreadinghistory" syspref and remove the "view_checkout_history" permission of the staff user update_database, then restart_all, and check the staff user (Staff A and Staff B). Neither should have the "view_checkout_history" permission L:i -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 David Flater <flaterdavid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- In issuehistory.tt: [% SET show_patron_column = (CAN_user_borrowers_view_checkout_history && Koha.Preference('intranetreadinghistory')) AND CAN_user_circulate_circulate_remaining_permissions %] Should we still be checking for circulate_remaining_permissions ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183844|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 David Flater <flaterdavid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183844|0 |1 is obsolete| | Attachment #184572|0 |1 is obsolete| | --- Comment #12 from David Flater <flaterdavid@gmail.com> --- Created attachment 184832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184832&action=edit Bug 32682: Add permission for viewing patron reading history Create or modify a staff user with edit_borrowers permssion enabled ( Staff A ) Create or modify a staff user without edit_borrowers permssion enabled ( Staff B ) Ensure the "intranetreadinghistory" syspref is enabled Check out an assortment of items to any patron Apply patch, update_database, then restart_all Check the permissions of the staff user A and ensure that they have been automatically assigned the new "view_checkout_history" permission Check the permissions of the staff user B and ensure that they have NOT been automatically assigned the new "view_checkout_history" permission View the same patron and ensure you can still see their checkout history as Staff A and as a superlibrarain Disable the "intranetreadinghistory" syspref and remove the "view_checkout_history" permission of the staff user update_database, then restart_all, and check the staff user (Staff A and Staff B). Neither should have the "view_checkout_history" permission L:i -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 --- Comment #13 from David Flater <flaterdavid@gmail.com> --- Created attachment 184833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184833&action=edit Bug 32682: Fix typo -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Status|Needs Signoff |Patch doesn't apply --- Comment #14 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I can't get these patches to apply, the atomicupdate is giving errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|flaterdavid@gmail.com |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183844|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183845|0 |1 is obsolete| | --- Comment #15 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 186944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186944&action=edit Bug 32682: Implement reading history permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183844|0 |1 is obsolete| | Attachment #184832|0 |1 is obsolete| | --- Comment #16 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 186945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186945&action=edit Bug 32682: Add permission for viewing patron reading history -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186944|0 |1 is obsolete| | --- Comment #17 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 186946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186946&action=edit Bug 32682: Implement reading history permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183846|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184571|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184833|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186946|0 |1 is obsolete| | --- Comment #18 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 186947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186947&action=edit Bug 32682: Implement reading history permission To test: 1. Create or modify a staff user with edit_borrowers permssion enabled ( Staff A ) 2. Create or modify a staff user without edit_borrowers permssion enabled ( Staff B ) 3. Ensure the "intranetreadinghistory" syspref is enabled 4. Check out an assortment of items to any patron 5. Apply patch, update_database, then restart_all 6. Check the permissions of the staff user A and ensure that they have been automatically assigned the new "view_checkout_history" permission 7. Check the permissions of the staff user B and ensure that they have NOT been automatically assigned the new "view_checkout_history" permission 8. View the same patron and ensure you can still see their checkout history as Staff A and as a superlibrarain 9. Disable the "intranetreadinghistory" syspref and remove the "view_checkout_history" permission of the staff user -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 --- Comment #19 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Squashed and rebased for David. This should again be ready for testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 --- Comment #20 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 187591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187591&action=edit Bug 32682: Add new permission to t/Koha/Auth/Permissions.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m Status|Needs Signoff |Failed QA --- Comment #21 from Lisette Scheer <lisette@bywatersolutions.com> --- Hi Lucas, you shouldn't use C4::Context in DB updates. https://wiki.koha-community.org/wiki/Database_updates So do not call Koha:: or C4:: methods/subroutines or use of Koha::Database->schema. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 --- Comment #22 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Lisette Scheer from comment #21)
Hi Lucas, you shouldn't use C4::Context in DB updates.
https://wiki.koha-community.org/wiki/Database_updates
So do not call Koha:: or C4:: methods/subroutines or use of Koha::Database->schema.
Lisette, what do you suggest instead? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 --- Comment #23 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 188168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188168&action=edit Bug 32682: Update patrons chekcoput route to allow access with new permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 --- Comment #24 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 188169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188169&action=edit Bug 32682: Fix how sys pref is retrived in DB update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186945|0 |1 is obsolete| | --- Comment #25 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 189039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189039&action=edit Bug 32682: Add permission for viewing patron reading history Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186947|0 |1 is obsolete| | --- Comment #26 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 189040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189040&action=edit Bug 32682: Implement reading history permission To test: 1. Create or modify a staff user with edit_borrowers permssion enabled ( Staff A ) 2. Create or modify a staff user without edit_borrowers permssion enabled ( Staff B ) 3. Ensure the "intranetreadinghistory" syspref is enabled 4. Check out an assortment of items to any patron 5. Apply patch, update_database, then restart_all 6. Check the permissions of the staff user A and ensure that they have been automatically assigned the new "view_checkout_history" permission 7. Check the permissions of the staff user B and ensure that they have NOT been automatically assigned the new "view_checkout_history" permission 8. View the same patron and ensure you can still see their checkout history as Staff A and as a superlibrarain 9. Disable the "intranetreadinghistory" syspref and remove the "view_checkout_history" permission of the staff user Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187591|0 |1 is obsolete| | --- Comment #27 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 189041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189041&action=edit Bug 32682: Add new permission to t/Koha/Auth/Permissions.t Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188168|0 |1 is obsolete| | --- Comment #28 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 189042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189042&action=edit Bug 32682: Update patrons chekcoput route to allow access with new permission Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188169|0 |1 is obsolete| | --- Comment #29 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 189043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189043&action=edit Bug 32682: Fix how sys pref is retrived in DB update Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 --- Comment #30 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Trevor approved SO of this bug on 9/26/25 based on a demo I provided for him. I'm not sure how this ended up at Signed-Off without that being officially noted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189039|0 |1 is obsolete| | --- Comment #31 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 191920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191920&action=edit Bug 32682: Add permission for viewing patron reading history Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189040|0 |1 is obsolete| | --- Comment #32 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 191921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191921&action=edit Bug 32682: Implement reading history permission To test: 1. Create or modify a staff user with edit_borrowers permssion enabled ( Staff A ) 2. Create or modify a staff user without edit_borrowers permssion enabled ( Staff B ) 3. Ensure the "intranetreadinghistory" syspref is enabled 4. Check out an assortment of items to any patron 5. Apply patch, update_database, then restart_all 6. Check the permissions of the staff user A and ensure that they have been automatically assigned the new "view_checkout_history" permission 7. Check the permissions of the staff user B and ensure that they have NOT been automatically assigned the new "view_checkout_history" permission 8. View the same patron and ensure you can still see their checkout history as Staff A and as a superlibrarain 9. Disable the "intranetreadinghistory" syspref and remove the "view_checkout_history" permission of the staff user Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189041|0 |1 is obsolete| | --- Comment #33 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 191922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191922&action=edit Bug 32682: Add new permission to t/Koha/Auth/Permissions.t Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189042|0 |1 is obsolete| | --- Comment #34 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 191923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191923&action=edit Bug 32682: Update patrons chekcoput route to allow access with new permission Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189043|0 |1 is obsolete| | --- Comment #35 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 191924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191924&action=edit Bug 32682: Fix how sys pref is retrived in DB update Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@openfifth.c | |o.uk QA Contact|testopia@bugs.koha-communit |matt.blenkinsop@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 --- Comment #36 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds a new release notes| |permission for viewing | |parton's reading history. ( | |view_checkout_history ) | |Now when | |intranetreadinghistory is | |enabled staff must also | |have the specific | |'view_checkout_history' | |permission in order to view | |a patron's reading history. | |With intranetreadinghistory | |turned off the no users are | |able to view patron's | |reading history. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42062 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42062 [Bug 42062] Patron column missing from checkout history on biblio record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #37 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- This will not be backported to 25.11.x due to it being deemed an enhancement or a dependancy not being met -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32682 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org --- Comment #38 from Aude Charillon <aude.charillon@openfifth.co.uk> --- *** Bug 42817 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org