[Bug 19651] New: SIP/ILS/Item missing title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19651 Bug ID: 19651 Summary: SIP/ILS/Item missing title Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: stefan.berndtsson@ub.gu.se QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com In 17.05 of C4/SIP/ILS/Item.pm (sub new) $item is fetched via GetBiblioFromItemNumber(). I assume this means that "title" was available as a property on the $item object. In master however, $item is fetched using Koha::Item->find() which means it is a pure Item object, and does not contain biblio data. $item->{title} is therefor lost. The "title" property has to be reinserted from $biblio explicitly. Looking at the %fields hash in the same file, "author" is probably another field that needs fixing too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19651 --- Comment #1 from Stefan Berndtsson <stefan.berndtsson@ub.gu.se> --- Created attachment 69302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69302&action=edit Add title and author from biblio to SIP/ILS/Item.pm Adding title and author manually lite this is a simple fix that solves the problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19651 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin.rokseth@kul.oslo.k | |ommune.no --- Comment #2 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- We Oslo Public Library can confirm this is an issue. Problem is that $item->unblessed overloads $self, and thus no $self->{author} or $self->{title} as was in GetBiblioFromItemnumber. This solution is a workaround, probably needs rework, and tests, later. But since release 17.11 is so close, and it will break any Item information response and probably any self checkout device, I propose this be added as is. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19651 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69302|0 |1 is obsolete| | --- Comment #3 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 69303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69303&action=edit
From 3dab1160c4b71bc6f6e9893427f59acb50f3500b Mon Sep 17 00:00:00 2001 From: Stefan Berndtsson <stefan.berndtsson@ub.gu.se> Date: Thu,23 Nov 2017 12:10:00 UTC Subject: [PATCH] Bug 19651 - SIP/ILS/Item missing title
Signed-off-by: Benjamin Rokseth <bensinober@gmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19651 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69303|From |[PATCH] Bug 19651 - description|3dab1160c4b71bc6f6e9893427f |SIP/ILS/Item missing title |59acb50f3500b Mon Sep 17 | |00:00:00 2001 From: Stefan | |Berndtsson | |<stefan.berndtsson@ub.gu.se | |> Date: Thu,23 Nov 2017 | |12:10:00 UTC Subject: | |[PATCH] Bug 19651 - | |SIP/ILS/Item missing title | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19651 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #4 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Took the liberty of adding git bz required info to your patch. It is needed for using git bz (https://wiki.koha-community.org/wiki/Git_bz_configuration) which Koha community uses for bugtracking. Basically it is email version of git issues, very old and tedioius, but this is what is used. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19651 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19651 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19651 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19651 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 69327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69327&action=edit Bug 19651: SIP/ILS/Item misses title and author Signed-off-by: Benjamin Rokseth <bensinober@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Amended $item->biblio by $biblio. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19651 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Assignee|koha-bugs@lists.koha-commun |stefan.berndtsson@ub.gu.se |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19651 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69303|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19651 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |18276 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Caused by bug 18276. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19651 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Patch pushed to Master! Thanks Stephan and congrats for your first patch in! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19651 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19651 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Bug 18276 not in 17.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org