[Bug 34634] New: Expiration date does not display on /reserve/request.pl if date is today or in the past
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34634 Bug ID: 34634 Summary: Expiration date does not display on /reserve/request.pl if date is today or in the past Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: 1. Place some holds and go to /reserve/request.pl for that bib. 2. If the reserves.expirationdate is set to today or some date in the past the date does not display in the Flatpickr instance. 3. Change the reserves.expirationdate to sometime in the future, the date displays. If staff cannot edit the reserves.expirationdate because it is in the past it still needs to display. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34634 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34634 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34634 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 154891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154891&action=edit Bug 34634: Show expirationdate of expired holds on reserve/request.pl To test: 1. Place some holds and go to /reserve/request.pl for that bib. 2. If the reserves.expirationdate is set to today or some date in the past the date does not display in the Flatpickr instance. 3. Change the reserves.expirationdate to sometime in the future, the date displays. 4. Aply patch, restart_all 5. Try steps 2-3 again. 6. This time if the expiration date is in the past you should see it displayed. However it will be uneditable. 7. Make sure holds with a expiration date in the future can still be properly edited. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34634 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Expiration date does not |Expiration date does not |display on |display on |/reserve/request.pl if date |reserve/request.pl if date |is today or in the past |is today or in the past -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34634 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34634 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34634 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154891|0 |1 is obsolete| | --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 154899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154899&action=edit Bug 34634: Show expirationdate of expired holds on reserve/request.pl To test: 1. Place some holds and go to /reserve/request.pl for that bib. 2. If the reserves.expirationdate is set to today or some date in the past the date does not display in the Flatpickr instance. 3. Change the reserves.expirationdate to sometime in the future, the date displays. 4. Aply patch, restart_all 5. Try steps 2-3 again. 6. This time if the expiration date is in the past you should see it displayed. However it will be uneditable. 7. Make sure holds with a expiration date in the future can still be properly edited. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34634 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34634 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154899|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 154905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154905&action=edit Bug 34634: Show expirationdate of expired holds on reserve/request.pl To test: 1. Place some holds and go to /reserve/request.pl for that bib. 2. If the reserves.expirationdate is set to today or some date in the past the date does not display in the Flatpickr instance. 3. Change the reserves.expirationdate to sometime in the future, the date displays. 4. Aply patch, restart_all 5. Try steps 2-3 again. 6. This time if the expiration date is in the past you should see it displayed. However it will be uneditable. 7. Make sure holds with a expiration date in the future can still be properly edited. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Christine <chlee@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34634 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov --- Comment #4 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Straightforward change, works nicely, QA tool happy. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34634 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34634 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34634 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.04 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34634 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.04 |23.11.00,23.05.04,22.11.10 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34634 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34634 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35559 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 [Bug 35559] Can't change the pickup date of holds on the last day of expiration -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org