[Bug 11010] New: Useless column purchaseordernumber in aqorders table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11010 Bug ID: 11010 Summary: Useless column purchaseordernumber in aqorders table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Database Assignee: gmcharlt@gmail.com Reporter: mathieu.saby@univ-rennes2.fr QA Contact: testopia@bugs.koha-community.org In Schemaspy, column purchaseordernumber is reported as "not used? always NULL". "grep -r cancelledby *" give this result : C4/Acquisition.pm:The following keys are used: "biblionumber", "title", "basketno", "quantity", "notes", "rrp", "ecost", "gstrate", "unitprice", "subscription", "sort1", "sort2", "booksellerinvoicenumber", "listprice", "budgetdate", "purchaseordernumber", "branchcode", "booksellerinvoicenumber", "budget_id". C4/Acquisition.pm: datereceived,purchaseordernumber, installer/data/mysql/update22to30.pl: field => 'purchaseordernumber', installer/data/mysql/kohastructure.sql: `purchaseordernumber` mediumtext, -- not used? always NULL installer/data/Pg/kohastructure.sql:purchaseordernumber text, t/db_dependent/Acquisition.t: purchaseordernumber In C4::Acquisition.pm::GetParcels, the SELECT statement retreives purchaseordernumber, but no value is pushed to that column in any part of Koha's code. So I think it is useless. I propose the deletion of this column. M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11010 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> --- There is a patch on bug 4456 to utilize this field. see also bug 4960 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11010 --- Comment #2 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Thank you. 4456 is very old, and there is nothing attached to 4456. Do you think these enh could be "revived" ? What's the difference between the ordernumber and the purchaseordernumber? M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11010 --- Comment #3 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- oups, the patch attached to 4456 is not very old, sorry for that. M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11010 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart@biblibre.co | |m Resolution|--- |INVALID --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Since bug 4456 will use this field, this bug report is invalid. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org