[Bug 7772] New: reports/bor_issues_top.pl: we need to exit(0) for plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7772 Priority: P5 - low Change sponsored?: --- Bug ID: 7772 Assignee: gmcharlt@gmail.com Summary: reports/bor_issues_top.pl: we need to exit(0) for plack QA Contact: koha.sekjal@gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: dpavlin@rot13.org Hardware: All Status: NEW Version: rel_3_8 Component: Reports Product: Koha Created attachment 8393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8393&action=edit proposed patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7772 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7172 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7772 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8393|0 |1 is obsolete| | --- Comment #1 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 8424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8424&action=edit Bug 7772 - reports/bor_issues_top.pl: we need to exit(0) for plack -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7772 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7772 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |dpavlin@rot13.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7772 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8424|0 |1 is obsolete| | --- Comment #2 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 8557 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8557&action=edit [Signed-off] Bug 7772 - reports/bor_issues_top.pl: we need to exit(0) for plack Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7772 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |alex.arnaud@biblibre.com --- Comment #3 from Alex Arnaud <alex.arnaud@biblibre.com> --- It works, signing off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7772 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Ian Walls <koha.sekjal@gmail.com> --- This exit(1) line looks to be very, very old code, and I don't think an error exit status is at all appropriate, given that the code did exactly what it was supposed to do. Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7772 --- Comment #5 from Ian Walls <koha.sekjal@gmail.com> --- Further investigation shows that the whole reports area is littered with exit(1) for cases of success. A wider-range patch to fix all these instances is welcomed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7772 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7772 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7829 --- Comment #6 from Dobrica Pavlinusic <dpavlin@rot13.org> --- bug 7892 cleans up all exit(1) in reports -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org