[Bug 10516] New: Improve titles, breadcrumbs, and confirmation messages for Z39.50 server adds and updates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516 Bug ID: 10516 Summary: Improve titles, breadcrumbs, and confirmation messages for Z39.50 server adds and updates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org The template for adding and updating a Z39.50 server currently shows the same message for adds and updates. It would be more clear if it showed one message for adds and one for updates. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 19807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19807&action=edit Bug 10516 - Improve titles, breadcrumbs, and confirmation messages for Z39.50 server adds and updates The template for adding/editing Z39.50 servers shows the same title, breadcrumbs, etc. for add and edit operations. This patch creates separate text for each case. To test, try both adding and editing a Z39.50 server. The page title, breadcrumb, and heading should correctly reflect the operation you perform. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19807|0 |1 is obsolete| | --- Comment #2 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 19812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19812&action=edit Bug 10516 - Improve titles, breadcrumbs, and confirmation messages for Z39.50 server adds and updates The template for adding/editing Z39.50 servers shows the same title, breadcrumbs, etc. for add and edit operations. This patch creates separate text for each case. To test, try both adding and editing a Z39.50 server. The page title, breadcrumb, and heading should correctly reflect the operation you perform. Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19812|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 19832 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19832&action=edit [PASSED QA] Bug 10516 - Improve titles, breadcrumbs, and confirmation messages for Z39.50 server adds and updates The template for adding/editing Z39.50 servers shows the same title, breadcrumbs, etc. for add and edit operations. This patch creates separate text for each case. To test, try both adding and editing a Z39.50 server. The page title, breadcrumb, and heading should correctly reflect the operation you perform. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely and all strings are translatable. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 19833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19833&action=edit Bug 10516 - Follow up - Fixing capitalization Fix capitalization on submit buttons when deleting a Z39.50 server. - Delete this Server - Do Not Delete I think the "Do not delete" should maybe even be a cancel link to be more consistent with how Koha displays this kind of dialog in other places. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19833|0 |1 is obsolete| | --- Comment #5 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 19842 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19842&action=edit Bug 10516 - Follow up - Fixing capitalization Fix capitalization on submit buttons when deleting a Z39.50 server. - Delete this Server - Do Not Delete I think the "Do not delete" should maybe even be a cancel link to be more consistent with how Koha displays this kind of dialog in other places. Signed-off-by: Liz Rea <wizzyrea@gmail.com> fixes capitalisation, tool stil works -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Liz! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Switching back to passed QA after checking with Galen. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #8 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Liz Rea from comment #5)
I think the "Do not delete" should maybe even be a cancel link to be more consistent with how Koha displays this kind of dialog in other places.
I agree, but I'm content to leave that to a follow-up. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be in 3.10.11 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish@catalyst.net.nz --- Comment #12 from Chris Hall <chrish@catalyst.net.nz> --- Pushed to 3.8.x, will be in 3.8.18 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no --- Comment #13 from Magnus Enger <magnus@enger.priv.no> --- *** Bug 9849 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org