[Bug 14824] New: Fix sorting of Norwegian vowels
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14824 Bug ID: 14824 Summary: Fix sorting of Norwegian vowels Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: magnus@libriotech.no Reporter: magnus@libriotech.no QA Contact: testopia@bugs.koha-community.org Currently, if you sort bibliographic search results by title, the Norwegian wovels ÆØÅ will not be sorted correctly. Specifically, with a result list containing 4 results, I was getting this for an A-Z (or A-Å) sort: Å... Æ... H... Ø... Which is just about as incorrect as it gets. As documented here: http://www.indexdata.com/zebra/doc/character-map-files.html sorting in Zebra is governed by the "lowercase" and "uppercase" setting in sort-string-utf.chr. That page suggests this for scandinavian languages: lowercase {0-9}{a-y}üzæäøöå uppercase {0-9}{A-Y}ÜZÆÄØÖÅ But with that config I got warnings during rebuild zebra: 10:05:00-15/09 zebraidx(26924) [warn] duplicate entry for charmap from 'ä' 10:05:00-15/09 zebraidx(26924) [warn] duplicate entry for charmap from 'Ä' 10:05:00-15/09 zebraidx(26924) [warn] duplicate entry for charmap from 'ö' 10:05:00-15/09 zebraidx(26924) [warn] duplicate entry for charmap from 'Ö' 10:05:00-15/09 zebraidx(26924) [warn] duplicate entry for charmap from 'ü' 10:05:00-15/09 zebraidx(26924) [warn] duplicate entry for charmap from 'Ü' I assume this is because these characters are already mapped to other chars. So I will propose a patch that uses this simplified setting: lowercase {0-9}{a-z}æøå uppercase {0-9}{A-Z}ÆØÅ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14824 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14824 --- Comment #1 from Magnus Enger <magnus@libriotech.no> --- Created attachment 42549 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42549&action=edit Bug 14824 - Fix sorting of Norwegian vowels Currently, Norwegian vowels are not sorted correctly, even when you have chosen "nb" as the ZEBRA_LANGUAGE during installation. To test: - Make sure you have three records with titles that begin with ÆØÅ respectively - Do a search that turns up those three records and some others, and sort the results by title, bot ascending and descending. - Verify that ÆØÅ is shown in some weird order. - Edit your sort-string-utf.chr* so it is in line with the current patch. It should include these two lines: lowercase {0-9}{a-z}æøå uppercase {0-9}{A-Z}ÆØÅ - Restart Zebra and reindex all the records, e.g.: $ sudo koha-restart-zebra <instancename> $ sudo koha-rebuild-zebra -f -v <instancename> - Do the search again, make sure you order by title and check that ÆØÅ are sorted in the order of 1. Æ 2. Ø 3. Å, and after all other characters * = If you are on a gitified install, you need to edit this file: /etc/koha/zebradb/lang_defs/<your ZEBRA_LANGUAGE>/sort-string-utf.chr NOT the file in your git clone (yeah, i wasted some time there...) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14824 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42549|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 43780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43780&action=edit Bug 14824 - Fix sorting of Norwegian vowels Currently, Norwegian vowels are not sorted correctly, even when you have chosen "nb" as the ZEBRA_LANGUAGE during installation. To test: - Make sure you have three records with titles that begin with ÆØÅ respectively - Do a search that turns up those three records and some others, and sort the results by title, bot ascending and descending. - Verify that ÆØÅ is shown in some weird order. - Edit your sort-string-utf.chr* so it is in line with the current patch. It should include these two lines: lowercase {0-9}{a-z}æøå uppercase {0-9}{A-Z}ÆØÅ - Restart Zebra and reindex all the records, e.g.: $ sudo koha-restart-zebra <instancename> $ sudo koha-rebuild-zebra -f -v <instancename> - Do the search again, make sure you order by title and check that ÆØÅ are sorted in the order of 1. Æ 2. Ø 3. Å, and after all other characters * = If you are on a gitified install, you need to edit this file: /etc/koha/zebradb/lang_defs/<your ZEBRA_LANGUAGE>/sort-string-utf.chr NOT the file in your git clone (yeah, i wasted some time there...) Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14824 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14824 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14824 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43780|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43943&action=edit [PASSED QA] Bug 14824 - Fix sorting of Norwegian vowels Currently, Norwegian vowels are not sorted correctly, even when you have chosen "nb" as the ZEBRA_LANGUAGE during installation. To test: - Make sure you have three records with titles that begin with ÆØÅ respectively - Do a search that turns up those three records and some others, and sort the results by title, bot ascending and descending. - Verify that ÆØÅ is shown in some weird order. - Edit your sort-string-utf.chr* so it is in line with the current patch. It should include these two lines: lowercase {0-9}{a-z}æøå uppercase {0-9}{A-Z}ÆØÅ - Restart Zebra and reindex all the records, e.g.: $ sudo koha-restart-zebra <instancename> $ sudo koha-rebuild-zebra -f -v <instancename> - Do the search again, make sure you order by title and check that ÆØÅ are sorted in the order of 1. Æ 2. Ø 3. Å, and after all other characters * = If you are on a gitified install, you need to edit this file: /etc/koha/zebradb/lang_defs/<your ZEBRA_LANGUAGE>/sort-string-utf.chr NOT the file in your git clone (yeah, i wasted some time there...) Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14824 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Magnus! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org