https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20054 --- Comment #1 from Indranil Das Gupta <indradg@l2c2.co.in> --- Created attachment 70787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70787&action=edit Bug 20054 - Remove attribute "text/css" for <style> element in OPAC Conformance rules for HTML5 is generating warnings for <style> element with type="text/css" attribute when the OPAC page is checked with W3C Validator. Test plan ========= 1/ Click the "Tag cloud" link on the OPAC. Paste the URL to your OPAC page (if it is hosted) to W3C Validator and watch the warning about type attribute "text/css". 2/ Apply patch and re-submit the page to the Validator. The warning will be gone. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20054 Indranil Das Gupta <indradg@l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Prevents warnings about release notes| |type attribute being | |generated for <style> | |elements when testing the | |OPAC pages using W3C | |Validator for HTML5. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20054 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 70798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70798&action=edit Bug 20054: Remove attribute "text/css" for <style> element in OPAC Conformance rules for HTML5 is generating warnings for <style> element with type="text/css" attribute when the OPAC page is checked with W3C Validator. Test plan ========= 1/ Click the "Tag cloud" link on the OPAC. Paste the URL to your OPAC page (if it is hosted) to W3C Validator and watch the warning about type attribute "text/css". 2/ Apply patch and re-submit the page to the Validator. The warning will be gone. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20054 Maksim Sen <maksim.sen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70798|0 |1 is obsolete| | --- Comment #3 from Maksim Sen <maksim.sen@inlibro.com> --- Created attachment 70979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70979&action=edit Bug 20054: Remove attribute "text/css" for <style> element in OPAC Conformance rules for HTML5 is generating warnings for <style> element with type="text/css" attribute when the OPAC page is checked with W3C Validator. Test plan ========= 1/ Click the "Tag cloud" link on the OPAC. Paste the URL to your OPAC page (if it is hosted) to W3C Validator and watch the warning about type attribute "text/css". 2/ Apply patch and re-submit the page to the Validator. The warning will be gone. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Maksim Sen <maksim@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20054 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70979|0 |1 is obsolete| | --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 71027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71027&action=edit Bug 20054: Remove attribute "text/css" for <style> element in OPAC Conformance rules for HTML5 is generating warnings for <style> element with type="text/css" attribute when the OPAC page is checked with W3C Validator. Test plan ========= 1/ Click the "Tag cloud" link on the OPAC. Paste the URL to your OPAC page (if it is hosted) to W3C Validator and watch the warning about type attribute "text/css". 2/ Apply patch and re-submit the page to the Validator. The warning will be gone. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: maksim <maksim@inlibro.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20054 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What about the staff interface? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20054 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- I have submitted Bug 20102 - Remove attribute "text/css" for <style> element used in staff client templates. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20054 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #7)

Hi Indranil, the patch does not longer apply, can you rebase? It sounds like it would be better to regenerate it, I guess you wrote a small script?

This comment was for bug 20053. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20054 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20054 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Prevents warnings about |Prevents warnings about release notes|type attribute being |type attribute being |generated for <style> |generated for the style |elements when testing the |tags when testing the OPAC |OPAC pages using W3C |pages using W3C Validator |Validator for HTML5. |for HTML5. Summary|Remove attribute "text/css" |Remove attribute "text/css" |for <style> element used in |for the style tags used in |the OPAC templates |the OPAC templates -- You are receiving this mail because: You are watching all bug changes.