[Bug 29278] New: write_age function broken by Flatpickr conversion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29278 Bug ID: 29278 Summary: write_age function broken by Flatpickr conversion Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 28937 The write_age() function builds a string describing the patron's age based on the date of birth field in the patron entry form. The function has been broken by Bug 28937 because the HTML structure of the page has changed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 [Bug 28937] Use Flatpickr on circulation and patron pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29278 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29278 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 126528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126528&action=edit Bug 29278: Fix selector of hint used to show age This patch modifies the patron entry form to correct a problem with the write_age() function introduced by the switch to Flatpickr on this page (Bug 28937). Rather than selecting the element based on the sequence of elements on the page, we should add an ID for direct selection. To test, apply the patch and go to Patrons. - Locate a patron record which has a date of birth saved. - When you open that patron for editing, you should see their age displayed below the date of birth input field, e.g. "Age: 23 years 9 months." - Changing the date in the date of birth field should update the age string correctly. - Go to Patrons -> New patron. - The date of birth field should have a hint showing the required date format, e.g. "(DD.MM.YYYY)". - When you select a date of birth using the Flatpickr calendar the age string should be updated correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29278 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26244 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26244 [Bug 26244] Move translatable strings out of memberentrygen.tt and into JavaScript -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29278 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29278 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126528|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 126631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126631&action=edit Bug 29278: Fix selector of hint used to show age This patch modifies the patron entry form to correct a problem with the write_age() function introduced by the switch to Flatpickr on this page (Bug 28937). Rather than selecting the element based on the sequence of elements on the page, we should add an ID for direct selection. To test, apply the patch and go to Patrons. - Locate a patron record which has a date of birth saved. - When you open that patron for editing, you should see their age displayed below the date of birth input field, e.g. "Age: 23 years 9 months." - Changing the date in the date of birth field should update the age string correctly. - Go to Patrons -> New patron. - The date of birth field should have a hint showing the required date format, e.g. "(DD.MM.YYYY)". - When you select a date of birth using the Flatpickr calendar the age string should be updated correctly. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29278 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the display of a release notes| |patron's age in the staff | |interface after the date of | |birth field (for example: | |Age: 63 years 4 months). | |This was not displaying | |after the switch to | |Flatpickr for date entry on | |this page in the 21.11 | |release development cycle. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29278 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- While I LOVE the text to go in the release notes I wonder if it's useful for a case like this when the feature that causes it will only be released with 21.11 - so the bug this fixes hasn't had a chance to hit anyone (my favourite bugs of all). Maybe we should focus on the enh/new features and behaviour changing ones? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29278 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29278 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126631|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126794&action=edit Bug 29278: Fix selector of hint used to show age This patch modifies the patron entry form to correct a problem with the write_age() function introduced by the switch to Flatpickr on this page (Bug 28937). Rather than selecting the element based on the sequence of elements on the page, we should add an ID for direct selection. To test, apply the patch and go to Patrons. - Locate a patron record which has a date of birth saved. - When you open that patron for editing, you should see their age displayed below the date of birth input field, e.g. "Age: 23 years 9 months." - Changing the date in the date of birth field should update the age string correctly. - Go to Patrons -> New patron. - The date of birth field should have a hint showing the required date format, e.g. "(DD.MM.YYYY)". - When you select a date of birth using the Flatpickr calendar the age string should be updated correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29278 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29278 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29278 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org