[Bug 40239] New: Improve TT validation when saving notice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40239 Bug ID: 40239 Summary: Improve TT validation when saving notice Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: marion.durand@biblibre.com QA Contact: testopia@bugs.koha-community.org Bug 31211 add a validation system to detect error in notification template when saving, but some errors are not caught by this system: For example, the following model will not generate any error or warning when saving, but it will completely (and silently) prevent sending the notification ``` Hello [% borrower.date_due %] ``` (in general, when trying to access a sub-field/sub-object that doesn't exist) Another example is a model looking like this : ``` Hello [% patron.surname %] ``` This notification is still sent, but the object patron doesn't exist and is not replaced. It would be great to test and warn the librarian if they are using invalid or non-available objects. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40239 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31211 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211 [Bug 31211] Check slips and notices for valid Template Toolkit and report errors -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40239 --- Comment #1 from Marion Durand <marion.durand@biblibre.com> --- To reproduce : 1- Go to Tools > Notification 2- In any notification template (but for example WELCOME is easy to generate from a patron page), enter the following model: ``` Hello, [% borrower.date_due %] ``` or ``` Hello [% patron.surname %] ``` 3- Click on "Save and continue editing" and display the section (message transport type, for example email) you juste edited. 4- No error message has been added, the template looks valid 5- generate the notification. With the first example, no notification is generated. With the second one, it is generated, but the object is not replaced. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org