[Bug 15213] New: Fix tools sidebar to highlight Patron lists when in that module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 Bug ID: 15213 Summary: Fix tools sidebar to highlight Patron lists when in that module Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: liz@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org Patron lists has some subpages within it, so special handling is needed for bolding the sidebar when that tool is the active one. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15211, 15212 --- Comment #1 from Liz Rea <liz@catalyst.net.nz> --- Depends on 15211 and 15212 because both of them bring this issue forward. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15211 [Bug 15211] Label/patron card creators need to have Tools sidebar http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15212 [Bug 15212] Patron lists tool page needs Tools area sidebar -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 --- Comment #2 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 45031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45031&action=edit Bug 15213 - Fix tools sidebar to highlight Patron lists when in that module To test: Add some patron lists, navigate through the lists interface and make sure that while you are in the module, that Patron lists is highlighted on the sidebar. Depends on 15211 and 15213 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15223 --- Comment #3 from Liz Rea <liz@catalyst.net.nz> --- This patch will also fix bug 15223. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15223 [Bug 15223] Buttons on patron list main page funny after font awesome -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45031|0 |1 is obsolete| | --- Comment #4 from Liz Rea <liz@catalyst.net.nz> --- Comment on attachment 45031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45031 Bug 15213 - Fix tools sidebar to highlight Patron lists when in that module Actually I don't want 15223 included in this patch, in case this one doesn't get in, so I'll send a new patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 --- Comment #5 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 45033 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45033&action=edit Bug 15213 - Fix tools sidebar to highlight Patron lists when in that module To test: Add some patron lists, navigate through the lists interface and make sure that while you are in the module, that Patron lists is highlighted on the sidebar. Depends on 15211 and 15213 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com --- Comment #6 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Hi Liz (In reply to Liz Rea from comment #1)
Depends on 15211 and 15212 because both of them bring this issue forward.
15212 doesn't have patch attached. (In reply to Liz Rea from comment #5)
Created attachment 45033 [details] [review] Bug 15213 - Fix tools sidebar to highlight Patron lists when in that module To test:
Add some patron lists, navigate through the lists interface and make sure that while you are in the module, that Patron lists is highlighted on the sidebar.
Depends on 15211 and 15213
Do I need to apply bug 15211 on top? Test plan isn't clear for me, please reword/clarify the message :) Regards -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45033|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 45272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45272&action=edit [SIGNED-OFF] Bug 15213 - fix buttons on patron lists To test: go to tools -> patron lists notice that the buttons are not misaligned anymore You may need to force refresh the page to see the original issue, and to see it fixed. http://bugs.koha-community.org/show_bug.cgi?id=15223 Signed-off-by: Owen Leonard <oleonard@myacpl.org> I can reproduce the problem in Chromium and the patch fixes it. No adverse effects in Firefox. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45272|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Comment on attachment 45272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45272 [SIGNED-OFF] Bug 15213 - fix buttons on patron lists Sorry, wrong bug report! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED Patch complexity|Trivial patch |--- -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45031|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45033|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45031|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 Bug 15213 depends on bug 15212, which changed state. Bug 15212 Summary: Patron lists tool page needs Tools area sidebar http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15212 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15223 | See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15223 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15223 [Bug 15223] Buttons on patron list main page funny after font awesome -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org