[Bug 16899] New: Add ability to disallow overpayments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Bug ID: 16899 Summary: Add ability to disallow overpayments Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com Some SIP services ( such as Comprise ) require that an attempt at over-paying a patron's account via SIP2 should fail, rather than create a credit on the account. We should make this a configurable option on a per-login basis in the SIP2 config file. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16895 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16895 [Bug 16895] Allow writeoffs via SIP2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 53272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53272&action=edit Bug 16899 - Add ability to disallow overpayments Some SIP services ( such as Comprise ) require that an attempt at over-paying a patron's account via SIP2 should fail, rather than create a credit on the account. We should make this a configurable option on a per-login basis in the SIP2 config file. Test Plan: 1) Apply this patch 2) Enable the new parameter disallow_overpayment="1" for the login to be used in this test. 3) Restart your SIP server 4) Create or find a patron with fines 5) Attempt to send a payment via SIP for more than what the patron's balance is 6) Note the response indicates a payment failure 7) Attempt to send a payment via SIP for the account balance or less 8) Note the response indicates the payment has succeeded 9) Verify in Koha that the payment was processed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53272|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 53275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53275&action=edit Bug 16899 - Add ability to disallow overpayments Some SIP services ( such as Comprise ) require that an attempt at over-paying a patron's account via SIP2 should fail, rather than create a credit on the account. We should make this a configurable option on a per-login basis in the SIP2 config file. Test Plan: 1) Apply this patch 2) Enable the new parameter disallow_overpayment="1" for the login to be used in this test. 3) Restart your SIP server 4) Create or find a patron with fines 5) Attempt to send a payment via SIP for more than what the patron's balance is 6) Note the response indicates a payment failure 7) Attempt to send a payment via SIP for the account balance or less 8) Note the response indicates the payment has succeeded 9) Verify in Koha that the payment was processed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53275|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 54203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54203&action=edit Bug 16899 - Add ability to disallow overpayments Some SIP services ( such as Comprise ) require that an attempt at over-paying a patron's account via SIP2 should fail, rather than create a credit on the account. We should make this a configurable option on a per-login basis in the SIP2 config file. Test Plan: 1) Apply this patch 2) Enable the new parameter disallow_overpayment="1" for the login to be used in this test. 3) Restart your SIP server 4) Create or find a patron with fines 5) Attempt to send a payment via SIP for more than what the patron's balance is 6) Note the response indicates a payment failure 7) Attempt to send a payment via SIP for the account balance or less 8) Note the response indicates the payment has succeeded 9) Verify in Koha that the payment was processed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ability to disallow |Add ability to disallow |overpayments |overpayments via SIP -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54203|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 55615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55615&action=edit [SIGNED-OFF] Bug 16899 - Add ability to disallow overpayments Some SIP services ( such as Comprise ) require that an attempt at over-paying a patron's account via SIP2 should fail, rather than create a credit on the account. We should make this a configurable option on a per-login basis in the SIP2 config file. Test Plan: 1) Apply this patch 2) Enable the new parameter disallow_overpayment="1" for the login to be used in this test. 3) Restart your SIP server 4) Create or find a patron with fines 5) Attempt to send a payment via SIP for more than what the patron's balance is 6) Note the response indicates a payment failure 7) Attempt to send a payment via SIP for the account balance or less 8) Note the response indicates the payment has succeeded 9) Verify in Koha that the payment was processed Signed-off-by: Rhonda Kuiper <kuiper@roundrocktexas.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.hedstrom.mace@sub.s | |u.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Also depends on a PNA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55615|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 61378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61378&action=edit Bug 16899 - Add ability to disallow overpayments Some SIP services ( such as Comprise ) require that an attempt at over-paying a patron's account via SIP2 should fail, rather than create a credit on the account. We should make this a configurable option on a per-login basis in the SIP2 config file. Test Plan: 1) Apply this patch 2) Enable the new parameter disallow_overpayment="1" for the login to be used in this test. 3) Restart your SIP server 4) Create or find a patron with fines 5) Attempt to send a payment via SIP for more than what the patron's balance is 6) Note the response indicates a payment failure 7) Attempt to send a payment via SIP for the account balance or less 8) Note the response indicates the payment has succeeded 9) Verify in Koha that the payment was processed Signed-off-by: Rhonda Kuiper <kuiper@roundrocktexas.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61378|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 61379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61379&action=edit Bug 16899 - Add ability to disallow overpayments Some SIP services ( such as Comprise ) require that an attempt at over-paying a patron's account via SIP2 should fail, rather than create a credit on the account. We should make this a configurable option on a per-login basis in the SIP2 config file. Test Plan: 1) Apply this patch 2) Enable the new parameter disallow_overpayment="1" for the login to be used in this test. 3) Restart your SIP server 4) Create or find a patron with fines 5) Attempt to send a payment via SIP for more than what the patron's balance is 6) Note the response indicates a payment failure 7) Attempt to send a payment via SIP for the account balance or less 8) Note the response indicates the payment has succeeded 9) Verify in Koha that the payment was processed Signed-off-by: Rhonda Kuiper <kuiper@roundrocktexas.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Bug 16899 depends on bug 16895, which changed state. Bug 16895 Summary: Allow writeoffs via SIP2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16895 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Global symbol "$patron" requires explicit package name at /usr/share/koha/masterclone/C4/SIP/ILS/Transaction/FeePayment.pm line 60. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61379|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 64080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64080&action=edit Bug 16899 - Add ability to disallow overpayments Some SIP services ( such as Comprise ) require that an attempt at over-paying a patron's account via SIP2 should fail, rather than create a credit on the account. We should make this a configurable option on a per-login basis in the SIP2 config file. Test Plan: 1) Apply this patch 2) Enable the new parameter disallow_overpayment="1" for the login to be used in this test. 3) Restart your SIP server 4) Create or find a patron with fines 5) Attempt to send a payment via SIP for more than what the patron's balance is 6) Note the response indicates a payment failure 7) Attempt to send a payment via SIP for the account balance or less 8) Note the response indicates the payment has succeeded 9) Verify in Koha that the payment was processed Signed-off-by: Rhonda Kuiper <kuiper@roundrocktexas.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- +++ b/Koha/Account/Lines.pm +sub amount_outstanding { You add this sub, but you are not using it ? And not testing it ? This needs feedback. Thanks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Sally Healey <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #10)
+++ b/Koha/Account/Lines.pm +sub amount_outstanding {
You add this sub, but you are not using it ? And not testing it ?
This needs feedback. Thanks.
Ended up not needing the sub. I'll remove it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64080|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 68604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68604&action=edit Bug 16899 - Add ability to disallow overpayments Some SIP services ( such as Comprise ) require that an attempt at over-paying a patron's account via SIP2 should fail, rather than create a credit on the account. We should make this a configurable option on a per-login basis in the SIP2 config file. Test Plan: 1) Apply this patch 2) Enable the new parameter disallow_overpayment="1" for the login to be used in this test. 3) Restart your SIP server 4) Create or find a patron with fines 5) Attempt to send a payment via SIP for more than what the patron's balance is 6) Note the response indicates a payment failure 7) Attempt to send a payment via SIP for the account balance or less 8) Note the response indicates the payment has succeeded 9) Verify in Koha that the payment was processed Signed-off-by: Rhonda Kuiper <kuiper@roundrocktexas.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68604|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 68656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68656&action=edit Bug 16899 - Add ability to disallow overpayments Some SIP services ( such as Comprise ) require that an attempt at over-paying a patron's account via SIP2 should fail, rather than create a credit on the account. We should make this a configurable option on a per-login basis in the SIP2 config file. Test Plan: 1) Apply this patch 2) Enable the new parameter disallow_overpayment="1" for the login to be used in this test. 3) Restart your SIP server 4) Create or find a patron with fines 5) Attempt to send a payment via SIP for more than what the patron's balance is 6) Note the response indicates a payment failure 7) Attempt to send a payment via SIP for the account balance or less 8) Note the response indicates the payment has succeeded 9) Verify in Koha that the payment was processed Signed-off-by: Rhonda Kuiper <kuiper@roundrocktexas.gov> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22873 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22873 [Bug 22873] C4::SIP::ILS::Transation::FeePayment->pay $disallow_overpayment does nothing -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org