[Bug 36557] New: Improve logic and display of OPAC cart, tag, and lists controls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 Bug ID: 36557 Summary: Improve logic and display of OPAC cart, tag, and lists controls Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 36166, 36207 I would like to update the OPAC so that the Cart, Tag, and List controls on multi-record pages (search results, lists) have consistent controls and use consistent logic for displaying controls. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36166 [Bug 36166] Disable select to add to list if opacuserlogin is disabled https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36207 [Bug 36207] Convert browser alerts to modals: OPAC tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 164563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164563&action=edit Bug 36166: Convert Cart and Lists conrols to buttons and rework logic This patch tries to address errors in the way features are displayed in result lists so that controls for holds, tags, lists, etc. are shown or hidden according to system preferences. The patch converst the Cart/Lists dropdown to separate buttons, making the display logic simpler and making the interface more consistent with updates to the staff interface search results. To test, apply the patch and rebuild the OPAC CSS. - In the OPAC, test these pages: - Catalog search results - List contents - Test with various combinations of these system preferences: - opacbookbag - DisplayMultiPlaceHold - virtualshelves - OPACHoldRequests - TagsEnabled - TagsInputOnList - UseRecalls - ArticleRequests With each different combination of settings the right controls should appear in the toolbar at the top (if present), and with each search result. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- Requires bug 32607, which currently no longer applies. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 --- Comment #3 from David Nind <david@davidnind.com> --- (In reply to David Nind from comment #2)
Requires bug 32607, which currently no longer applies.
That should have been bug 36207! That bug was fixed. However, now I'm getting a sha1/fake ancestor error for bug 36166. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #4 from David Nind <david@davidnind.com> --- (In reply to David Nind from comment #3)
However, now I'm getting a sha1/fake ancestor error for bug 36166.
If I apply bug 36166 by itself, everything works as it should - no sha1/fake ancestor error. However, I think I worked out what the problem is. The sha1/fake ancestor is for this bug - the patch itself for this bug has the wrong bug number! - Bug title: Bug 36557 - Improve logic and display of OPAC cart, tag, and lists controls - Bug attached: Bug 36166: Convert Cart and Lists conrols to buttons and rework logic () Here is the sha1/fake ancestor error: git bz apply 36557 Bug 36557 Depends on bug 36166 (Signed Off) Follow? [(y)es, (n)o] y Bug 36166 Depends on bug 36207 (Signed Off) Follow? [(y)es, (n)o] y Bug 36207 - Convert browser alerts to modals: OPAC tags 166212 - Bug 36207: Use confirmation modal when removing tags from titles in the OPAC Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 36207: Use confirmation modal when removing tags from titles in the OPAC Bug 36166 - Disable select to add to list if opacuserlogin is disabled 162794 - Bug 36166: Disable select to add to list if opacuserlogin is disabled Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 36166: Disable select to add to list if opacuserlogin is disabled Bug 36557 - Improve logic and display of OPAC cart, tag, and lists controls 164563 - Bug 36166: Convert Cart and Lists conrols to buttons and rework logic Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 36166: Convert Cart and Lists conrols to buttons and rework logic error: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss). error: could not build fake ancestor Patch failed at 0001 Bug 36166: Convert Cart and Lists conrols to buttons and rework logic -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164563|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 166297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166297&action=edit Bug 36166: Convert Cart and Lists controls to buttons and rework logic This patch tries to address errors in the way features are displayed in result lists so that controls for holds, tags, lists, etc. are shown or hidden according to system preferences. The patch converts the Cart/Lists dropdown to separate buttons, making the display logic simpler and making the interface more consistent with updates to the staff interface search results. To test, apply the patch and rebuild the OPAC CSS. - In the OPAC, test these pages: - Catalog search results - List contents - Test with various combinations of these system preferences: - opacbookbag - DisplayMultiPlaceHold - virtualshelves - OPACHoldRequests - TagsEnabled - TagsInputOnList - UseRecalls - ArticleRequests With each different combination of settings the right controls should appear in the toolbar at the top (if present), and with each search result. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #6 from David Nind <david@davidnind.com> --- Getting a really weird error now when trying to apply the patch 8-(... git bz apply 36557 Bug 36557 Depends on bug 36166 (Signed Off) Follow? [(y)es, (n)o] y Bug 36166 Depends on bug 36207 (Signed Off) Follow? [(y)es, (n)o] y Bug 36207 - Convert browser alerts to modals: OPAC tags 166212 - Bug 36207: Use confirmation modal when removing tags from titles in the OPAC Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 36207: Use confirmation modal when removing tags from titles in the OPAC Bug 36166 - Disable select to add to list if opacuserlogin is disabled 162794 - Bug 36166: Disable select to add to list if opacuserlogin is disabled Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 36166: Disable select to add to list if opacuserlogin is disabled Bug 36557 - Improve logic and display of OPAC cart, tag, and lists controls 166297 - Bug 36166: Convert Cart and Lists controls to buttons and rework logic Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 36166: Convert Cart and Lists controls to buttons and rework logic Moving to starting point Adding bug reference 825098d Bug 36166: Convert Cart and Lists controls to buttons and rework logic Cleaning up back to original state on error Traceback (most recent call last): File "/usr/bin/git-bz", line 2834, in <module> applied = do_apply(bug_ref) ^^^^^^^^^^^^^^^^^ File "/usr/bin/git-bz", line 1977, in do_apply add_url(bug, commits) File "/usr/bin/git-bz", line 1719, in add_url add_url_to_head_commit(commit, bug) File "/usr/bin/git-bz", line 1682, in add_url_to_head_commit git.commit(file="-", amend=True, _input=input) File "/usr/bin/git-bz", line 197, in f o = git_run(command, *args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/bin/git-bz", line 167, in git_run output, error = process.communicate(input) ^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.11/subprocess.py", line 1207, in communicate stdout, stderr = self._communicate(input, endtime, timeout) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.11/subprocess.py", line 2039, in _communicate input_view = memoryview(self._input) ^^^^^^^^^^^^^^^^^^^^^^^ TypeError: memoryview: a bytes-like object is required, not 'str' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like a git bz issue, but not spotting what's actually going on. Adding Joubu. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Bug number on the patch is not 36557, and the git-bz python3 version is buggy... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166297|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 166422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166422&action=edit Bug 36557: Convert Cart and Lists controls to buttons and rework logic This patch tries to address errors in the way features are displayed in result lists so that controls for holds, tags, lists, etc. are shown or hidden according to system preferences. The patch converts the Cart/Lists dropdown to separate buttons, making the display logic simpler and making the interface more consistent with updates to the staff interface search results. To test, apply the patch and rebuild the OPAC CSS. - In the OPAC, test these pages: - Catalog search results - List contents - Test with various combinations of these system preferences: - opacbookbag - DisplayMultiPlaceHold - virtualshelves - OPACHoldRequests - TagsEnabled - TagsInputOnList - UseRecalls - ArticleRequests With each different combination of settings the right controls should appear in the toolbar at the top (if present), and with each search result. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 --- Comment #10 from David Nind <david@davidnind.com> --- Thanks for fixing! The patch now applies. The only thing that wasn't working as expected for me was article requests. With ArticleRequests enabled (as well as ArticleRequestsLinkControl set to 'Use algorithm to show or hide'): 1. Before the patch, 'Request article' was displayed in the actions for each result in the search results and on the record details page. It was also displayed on the list results. 2. After the patch, 'Request article' is not displayed in the search results, record details page, or lists. Not sure whether this was intended, or if it has something to do with ArticleRequestsLinkControl. With that set to always show, 'Request article' appears for all search results and on lists, but not on the record details page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- (In reply to David Nind from comment #10)
2. After the patch, 'Request article' is not displayed in the search results, record details page, or lists.
I'm not seeing this. In my testing the 'Request article' link shows up as expected on search results and lists with both settings of ArticleRequestsLinkControl. My patch doesn't touch the record detail page, so if there's an issue with that it's separate. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 --- Comment #12 from David Nind <david@davidnind.com> --- (In reply to Owen Leonard from comment #11)
(In reply to David Nind from comment #10)
2. After the patch, 'Request article' is not displayed in the search results, record details page, or lists.
I'm not seeing this. In my testing the 'Request article' link shows up as expected on search results and lists with both settings of ArticleRequestsLinkControl.
My patch doesn't touch the record detail page, so if there's an issue with that it's separate.
Have re-tested and is now showing. My apologies Owen, there must have been something wrong with my setup.... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166422|0 |1 is obsolete| | --- Comment #13 from David Nind <david@davidnind.com> --- Created attachment 166798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166798&action=edit Bug 36557: Convert Cart and Lists controls to buttons and rework logic This patch tries to address errors in the way features are displayed in result lists so that controls for holds, tags, lists, etc. are shown or hidden according to system preferences. The patch converts the Cart/Lists dropdown to separate buttons, making the display logic simpler and making the interface more consistent with updates to the staff interface search results. To test, apply the patch and rebuild the OPAC CSS. - In the OPAC, test these pages: - Catalog search results - List contents - Test with various combinations of these system preferences: - opacbookbag - DisplayMultiPlaceHold - virtualshelves - OPACHoldRequests - TagsEnabled - TagsInputOnList - UseRecalls - ArticleRequests With each different combination of settings the right controls should appear in the toolbar at the top (if present), and with each search result. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37150 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37150 [Bug 37150] Can't delete single title from a list using the "Remove from list" link -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 167966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167966&action=edit Bug 36557: (follow-up) Restore missing "Remove from list" control This patch restores the "Remove from list" control to the batch operations toolbar when one is looking at the contents of a list. It was unintentionally left out of the previous patch. The patch also corrects some button markup to ensure consisten style of controls in the batch operations toolbar. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166798|0 |1 is obsolete| | --- Comment #15 from David Nind <david@davidnind.com> --- Created attachment 167997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167997&action=edit Bug 36557: Convert Cart and Lists controls to buttons and rework logic This patch tries to address errors in the way features are displayed in result lists so that controls for holds, tags, lists, etc. are shown or hidden according to system preferences. The patch converts the Cart/Lists dropdown to separate buttons, making the display logic simpler and making the interface more consistent with updates to the staff interface search results. To test, apply the patch and rebuild the OPAC CSS. - In the OPAC, test these pages: - Catalog search results - List contents - Test with various combinations of these system preferences: - opacbookbag - DisplayMultiPlaceHold - virtualshelves - OPACHoldRequests - TagsEnabled - TagsInputOnList - UseRecalls - ArticleRequests With each different combination of settings the right controls should appear in the toolbar at the top (if present), and with each search result. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167966|0 |1 is obsolete| | --- Comment #16 from David Nind <david@davidnind.com> --- Created attachment 167998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167998&action=edit Bug 36557: (follow-up) Restore missing "Remove from list" control This patch restores the "Remove from list" control to the batch operations toolbar when one is looking at the contents of a list. It was unintentionally left out of the previous patch. The patch also corrects some button markup to ensure consisten style of controls in the batch operations toolbar. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Patch doesn't apply --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Sorry Owen.. I'm getting the dreaded sha1 apply error here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167997|0 |1 is obsolete| | Attachment #167998|0 |1 is obsolete| | --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 168248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168248&action=edit Bug 36557: Convert Cart and Lists controls to buttons and rework logic This patch tries to address errors in the way features are displayed in result lists so that controls for holds, tags, lists, etc. are shown or hidden according to system preferences. The patch converts the Cart/Lists dropdown to separate buttons, making the display logic simpler and making the interface more consistent with updates to the staff interface search results. To test, apply the patch and rebuild the OPAC CSS. - In the OPAC, test these pages: - Catalog search results - List contents - Test with various combinations of these system preferences: - opacbookbag - DisplayMultiPlaceHold - virtualshelves - OPACHoldRequests - TagsEnabled - TagsInputOnList - UseRecalls - ArticleRequests With each different combination of settings the right controls should appear in the toolbar at the top (if present), and with each search result. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 --- Comment #19 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 168249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168249&action=edit Bug 36557: (follow-up) Restore missing "Remove from list" control This patch restores the "Remove from list" control to the batch operations toolbar when one is looking at the contents of a list. It was unintentionally left out of the previous patch. The patch also corrects some button markup to ensure consisten style of controls in the batch operations toolbar. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168248|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168251&action=edit Bug 36557: Convert Cart and Lists controls to buttons and rework logic This patch tries to address errors in the way features are displayed in result lists so that controls for holds, tags, lists, etc. are shown or hidden according to system preferences. The patch converts the Cart/Lists dropdown to separate buttons, making the display logic simpler and making the interface more consistent with updates to the staff interface search results. To test, apply the patch and rebuild the OPAC CSS. - In the OPAC, test these pages: - Catalog search results - List contents - Test with various combinations of these system preferences: - opacbookbag - DisplayMultiPlaceHold - virtualshelves - OPACHoldRequests - TagsEnabled - TagsInputOnList - UseRecalls - ArticleRequests With each different combination of settings the right controls should appear in the toolbar at the top (if present), and with each search result. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168249|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168252&action=edit Bug 36557: (follow-up) Restore missing "Remove from list" control This patch restores the "Remove from list" control to the batch operations toolbar when one is looking at the contents of a list. It was unintentionally left out of the previous patch. The patch also corrects some button markup to ensure consisten style of controls in the batch operations toolbar. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Logic all checks out, looks nicer. Thanks for the thorough testing David. QA scripts all happy. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.06 released in| | Status|Pushed to main |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #24 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #25 from Fridolin Somers <fridolin.somers@biblibre.com> --- Dependancies not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38620 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38620 [Bug 38620] Non-existent hc-sticky asset included in opac-tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes errors in the release notes| |way features are displayed | |in OPAC result lists so | |that controls for holds, | |tags, lists, and so on, are | |shown or hidden according | |to system preferences. | | | |It | |converts the Cart/Lists | |dropdown to separate | |buttons, making the display | |logic simpler and making | |the interface more | |consistent with updates to | |the staff interface search | |results. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 Bug 36557 depends on bug 37150, which changed state. Bug 37150 Summary: Can't delete single title from a list using the "Remove from list" link https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37150 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 Bug 36557 depends on bug 36166, which changed state. Bug 36166 Summary: Disable select to add to list if opacuserlogin is disabled https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36166 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org