[Bug 13931] New: Date of birth in patron search result and in autocomplete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Bug ID: 13931 Summary: Date of birth in patron search result and in autocomplete Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: josef.moravec@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com It would be nice to see the date of birth in patron search results and possibly in autocomplete in searchfield for patron which you are going to checking out to. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 --- Comment #1 from Jiří Kozlovský <mail@jkozlovsky.cz> --- Created attachment 37801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37801&action=edit Bug 13931 - Added date of birth to member's search results table (intranet/cgi-bin/koha/members/member.pl) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 --- Comment #2 from Jiří Kozlovský <mail@jkozlovsky.cz> --- Created attachment 37807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37807&action=edit Bug 13931 - Added patron's dateofbirth to autocomplete -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Jiří Kozlovský <mail@jkozlovsky.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Jiří Kozlovský <mail@jkozlovsky.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37807|0 |1 is obsolete| | --- Comment #3 from Jiří Kozlovský <mail@jkozlovsky.cz> --- Created attachment 37809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37809&action=edit Bug 13931 - Implemented patron's dateofbirth autocompletion into newest version of circ/ysearch.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mail@jkozlovsky.cz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Jiří Kozlovský <mail@jkozlovsky.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Jiří Kozlovský <mail@jkozlovsky.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37801|0 |1 is obsolete| | Attachment #37809|0 |1 is obsolete| | --- Comment #4 from Jiří Kozlovský <mail@jkozlovsky.cz> --- Created attachment 37811 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37811&action=edit Bug 13931 - Implemented date of birth in patron search result and in autocomplete -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 --- Comment #5 from Jiří Kozlovský <mail@jkozlovsky.cz> --- Test plan: 1) Apply the patch 2) Type into search form patron's name & check his date of birth in autocompletion 3) Go to intranet/cgi-bin/koha/members/member.pl & submit a search with more than one result .. now should in the table appear patron's date of birth 4) Try show/hide columns section if it works correctly for date of birth 5) Go to intranet/cgi-bin/koha/admin/columns_settings.pl -> go to patrons section & check there is dateofbirth & it's functionality -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 --- Comment #6 from Jiří Kozlovský <mail@jkozlovsky.cz> --- Created attachment 38045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38045&action=edit Bug 13931 - Fixed Licence & Copyright statements & refactored the code -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Jiří Kozlovský <mail@jkozlovsky.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38045|1 |0 is patch| | Attachment #38045|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #7 from Marc Véron <veron@veron.ch> --- Created attachment 38126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38126&action=edit Columns wrong in result table In cgi-bin/koha/members/member.pl the birth date displays in the column "Category" and an empty column is added. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 --- Comment #8 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 44691 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44691&action=edit Bug 13931 - Fix patron search result table heading, fix member.pl template params -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37811|0 |1 is obsolete| | --- Comment #9 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 44692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44692&action=edit Bug 13931 - Implemented date of birth in patron search result and in autocomplete -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44691|0 |1 is obsolete| | --- Comment #10 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 44693 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44693&action=edit Bug 13931 - Fix patron search result table heading, fix member.pl template params -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #11 from Josef Moravec <josef.moravec@gmail.com> --- I've rebased patchs on top of current master and made followup to fix the error in patron search results table heading. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #12 from Frédéric Demians <frederic@tamil.fr> --- Comment 7 issue is solved. Could you merge your 2 patches in one single patch? and include your test plan into the patch itself? Remarque: Admin > Column settings > Patrons > memberresultst is respected in normal patron search result table: you can hide the new column dateofbirth if necessary. But this is not respected by the autocompletion search result. From my point of view, it's an issue. But it's worth noting. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38126|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 --- Comment #13 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 44817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44817&action=edit Bug 13931 - Date of birth in patron search result and in autocomplete -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44692|0 |1 is obsolete| | Attachment #44693|0 |1 is obsolete| | Attachment #44817|0 |1 is obsolete| | --- Comment #14 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 44818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44818&action=edit Bug 13931 - Date of birth in patron search result and in autocomplete Test plan: 1) Apply the patch 2) Type into search form patron's name & check his date of birth in autocompletion 3) Go to intranet/cgi-bin/koha/members/member.pl & submit a search with more than one result .. now should in the table appear patron's date of birth 4) Try show/hide columns section if it works correctly for date of birth 5) Go to intranet/cgi-bin/koha/admin/columns_settings.pl -> go to patrons section & check there is dateofbirth & it's functionality -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 --- Comment #15 from Josef Moravec <josef.moravec@gmail.com> --- Thanks for testing Frédéric. I squashed the commits and again rebased on master. I think the autocomplete is not configurable at all, so we could open new bug, if somebody need it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 --- Comment #16 from Frédéric Demians <frederic@tamil.fr> ---
I think the autocomplete is not configurable at all, so we could open new bug, if somebody need it.
The other option would be to not add the date of birth to the autocompletion. I wrote earlier by mistake: "From my point of view, it's an issue." I think exactly the contrary, IMO it's NOT an issue. The date of birth doesn't take that much space, and add a valuable information on the autocompletion search result. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44818|0 |1 is obsolete| | --- Comment #17 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 44821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44821&action=edit Bug 13931 - Date of birth in patron search result and in autocomplete Test plan: 1) Apply the patch 2) Type into search form patron's name & check his date of birth in autocompletion 3) Go to intranet/cgi-bin/koha/members/member.pl & submit a search with more than one result .. now should in the table appear patron's date of birth 4) Try show/hide columns section if it works correctly for date of birth 5) Go to intranet/cgi-bin/koha/admin/columns_settings.pl -> go to patrons section & check there is dateofbirth & it's functionality Signed-off-by: Frederic Demians <f.demians@tamil.fr> Works as described. Syspref dateformat respected. Column dateofbirth configurable, but mandatory on autocompletion search result. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44821|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45062&action=edit Bug 13931 - Date of birth in patron search result and in autocomplete Test plan: 1) Apply the patch 2) Type into search form patron's name & check his date of birth in autocompletion 3) Go to intranet/cgi-bin/koha/members/member.pl & submit a search with more than one result .. now should in the table appear patron's date of birth 4) Try show/hide columns section if it works correctly for date of birth 5) Go to intranet/cgi-bin/koha/admin/columns_settings.pl -> go to patrons section & check there is dateofbirth & it's functionality Signed-off-by: Frederic Demians <f.demians@tamil.fr> Works as described. Syspref dateformat respected. Column dateofbirth configurable, but mandatory on autocompletion search result. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45065&action=edit Bug 13931 [QA Followup] - Fix whitespace error -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 sally.healey@cheshirewestandchester.gov.uk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshirewestan | |dchester.gov.uk -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master, thanks Josef! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13931 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15400 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org