[Bug 30728] New: Allow real-time holds queue opt-out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 Bug ID: 30728 Summary: Allow real-time holds queue opt-out Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Somehow, the patchset got an initially developed piece that made it optional lost. Probably my fault on some submission. We need to add that back. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_05_candidate Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | CC| |fridolin.somers@biblibre.co | |m, | |jonathan.druart+koha@gmail. | |com, | |nick@bywatersolutions.com Depends on| |29346 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 [Bug 29346] Real-time holds queue update -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 134823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134823&action=edit Bug 30728: Add RealTimeHoldsQueue syspref Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 134824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134824&action=edit Bug 30728: Add unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 134825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134825&action=edit Bug 30728: Only trigger real-time holds queue update if enabled This patch makes the places in which Koha enqueues holds queue for real time updates verify the feature is enabled. To test: 1. Apply this patches up to the unit tests 2. Run: $ updatedatabase $ kshell k$ git diff origin/master --name-only | grep -e '\.t$' | xargs prove => FAIL: tests fail, the code doesn't care about the syspref 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Be happy! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29346 |30710, 30727 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 [Bug 29346] Real-time holds queue update https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30710 [Bug 30710] Background tasks can be called multiple times on batch item deletion https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30727 [Bug 30727] Holds queue updates can be called multiple times on batch record deletion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134824|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134825|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134823|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 134826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134826&action=edit Bug 30728: Add RealTimeHoldsQueue syspref Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 134827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134827&action=edit Bug 30728: Add unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 134828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134828&action=edit Bug 30728: Only trigger real-time holds queue update if enabled This patch makes the places in which Koha enqueues holds queue for real time updates verify the feature is enabled. To test: 1. Apply this patches up to the unit tests 2. Run: $ updatedatabase $ kshell k$ git diff origin/master --name-only | grep -e '\.t$' | xargs prove => FAIL: tests fail, the code doesn't care about the syspref 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Be happy! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 134829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134829&action=edit [OPTIONAL] Bug 30728: Make RealTimeHoldsQueue disabled by default Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Personally, I prefer to have the feature enabled by default. But I've added a follow-up patch disabling it by default so we can choose to disable it by default. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134826|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 134831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134831&action=edit Bug 30728: Add RealTimeHoldsQueue syspref Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134827|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 134832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134832&action=edit Bug 30728: Add unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134828|0 |1 is obsolete| | --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 134833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134833&action=edit Bug 30728: Only trigger real-time holds queue update if enabled This patch makes the places in which Koha enqueues holds queue for real time updates verify the feature is enabled. To test: 1. Apply this patches up to the unit tests 2. Run: $ updatedatabase $ kshell k$ git diff origin/master --name-only | grep -e '\.t$' | xargs prove => FAIL: tests fail, the code doesn't care about the syspref 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Be happy! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 --- Comment #12 from David Nind <david@davidnind.com> --- Created attachment 134834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134834&action=edit Bug 30728: Make RealTimeHoldsQueue disabled by default Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #13 from David Nind <david@davidnind.com> --- After signing off, the [OPTIONAL] patch is still there as well as the signed off version without optional in the title - does this need to be obsoleted? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134829|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134831|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134857&action=edit Bug 30728: Add RealTimeHoldsQueue syspref Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134832|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134858&action=edit Bug 30728: Add unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134833|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134859&action=edit Bug 30728: Only trigger real-time holds queue update if enabled This patch makes the places in which Koha enqueues holds queue for real time updates verify the feature is enabled. To test: 1. Apply this patches up to the unit tests 2. Run: $ updatedatabase $ kshell k$ git diff origin/master --name-only | grep -e '\.t$' | xargs prove => FAIL: tests fail, the code doesn't care about the syspref 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Be happy! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134834|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134860&action=edit Bug 30728: Make RealTimeHoldsQueue disabled by default Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Solid improvement, could have swarn when first testing this was in the original patchset.. I agree it's a required addition.. we have libraries that want this queue to be static for X hours whilst they have people walk around the library with a paper list printed from the results. All works as expected, QA script is happy and the Unit tests all pass. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 --- Comment #19 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 134967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134967&action=edit Bug 30728: (QA follow-up) Fix missing comma -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Followup pushed to get jenkins (and koha-testing-docker) happy again.. easily missed comma lost somewhere along the line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30728 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35979 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org