https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 146470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146470&action=edit Bug 32939: Have a generic fetch function for POST and PUT requests in vue modules In bug 32925 it's discussed the possibility of having a generic fetch function to handle basic CRUD creates and edits for vuejs modules in the future and move all common POST+PUT async requests workflow in there, like the 'Submitting...' loading behaviour. This POC illustrates this and it's intent is to start discussion, plan on iterating further to the rest of ERM if agreed upon. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I love it! Some feedback: 1. a_id => prefer the full var name, agreement_id ;) 2. if ( this.$route.path.includes("edit") ) I don't really like this, I would prefer to rely on the status code (but I do understand why you did that!). Imagine we have another form on this url, it won't work in all cases. Actually you don't need this, we know already if we are editing or adding (search for "method", if there is agreement_id it's an edit). Note that there is code that is no longer needed there (variable options, etc.) 3. I would add a "count" method in http-client 4. fetch/api-client.js is a too generic name, it should be tight to the "erm" module. Don't you think? 5. Looks like we don't need fetch/fetch.js? Was it expected? 6. There are things in http-client.js we are not using, we should remove them. 7. Instead of the async/await you add, shouldn't we prefer client.agreements.(create).then(addMessage())? Maybe it's only a matter of taste? 8. Code is not tidy, don't forget to install the pre-commit git hook! I would like a version of this that is before bug 32925, then we added the "isSubmitting info" there. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32925 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32925 [Bug 32925] Display loading info when a form is submitted -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 146642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146642&action=edit Bug 32939: Have a generic fetch function for POST and PUT requests in vue modules - Cleaned up the code and further extended the implementation concept on agreements only. - Jonathan I followed your suggestions but had to keep async/await or the catch will not work if an error is thrown from the http-client - I'm keeping this as a separate patch for diff check (intention is to squash all of it once we're happy) - I plan on continuing with this in coming days but more feedback is always welcome, also plan on rebasing this to 32925 Later: - api-client.js should be renamed to erm-api-client.js (or something of the sort) but I kept the same name for now for diff check - erm.js will ultimately disappear once this is all done (or api-client.js will become erm.js) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146644|0 |1 is obsolete| | --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 146645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146645&action=edit Bug 32939: Have a generic fetch function for POST and PUT requests in vue modules Rebase to 32806 and prior to 32925. Squash More updates. Ready for review, for now. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 146669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146669&action=edit Bug 32939: Have a generic APIClient object You always import the same, only once, and you can access other resources from the same object. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 146671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146671&action=edit Bug 32939: Restore checkError -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146672|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 146674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146674&action=edit Bug 32939: Introduce count Not used yet, will replace myFetchTotal -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 146676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146676&action=edit Bug 32939: Have a generic APIClient object You always import the same, only once, and you can access other resources from the same object. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 146678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146678&action=edit Bug 32939: Restore checkError -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 146680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146680&action=edit Bug 32939: Fix delete -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 146682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146682&action=edit Bug 32939: Uniformize api calls We want to make the call easier and without less errors possible. Here, no need to async keyword, try-catch, etc. Only call the method and use the common then with the 2 success and error Promise arguments. We will certainly want to add later a parameter to prevent the display of the error in fetchJSON, in case the failure does not require a message for the end user. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146675|0 |1 is obsolete| | Attachment #146676|0 |1 is obsolete| | Attachment #146677|0 |1 is obsolete| | Attachment #146678|0 |1 is obsolete| | Attachment #146679|0 |1 is obsolete| | Attachment #146680|0 |1 is obsolete| | Attachment #146681|0 |1 is obsolete| | Attachment #146682|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147029&action=edit Bug 32939: Have a generic fetch function for POST and PUT requests in vue modules Rebase to 32806 and prior to 32925. Squash More updates. Ready for review, for now. JD amended patch: * prettier * remove changes to AgreementRelationships.vue and EHoldingsLocalPackageAgreements.vue to have less files to update in upcoming patches -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 --- Comment #23 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147031&action=edit Bug 32939: Set the default header at lower level -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 --- Comment #25 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147033&action=edit Bug 32939: Introduce count Not used yet, will replace myFetchTotal -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 --- Comment #27 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147035&action=edit Bug 32939: Uniformize api calls We want to make the call easier and without less errors possible. Here, no need to async keyword, try-catch, etc. Only call the method and use the common then with the 2 success and error Promise arguments. We will certainly want to add later a parameter to prevent the display of the error in fetchJSON, in case the failure does not require a message for the end user. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 --- Comment #29 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147037&action=edit Bug 32939: Use APIClient to fetch licenses -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 --- Comment #31 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147039&action=edit Bug 32939: Use APIClient to fetch vendors -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 --- Comment #33 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147041&action=edit Bug 32939: Use APIClient to fetch EBSCO eHoldings -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 --- Comment #35 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147043&action=edit Bug 32939: Use APIClient to replace some more fetch calls -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 --- Comment #37 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Test plan: Retest the whole ERM module. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32806 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 [Bug 32806] Some Vue files need to be moved for better reusability -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147029|0 |1 is obsolete| | --- Comment #39 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 147056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147056&action=edit Bug 32939: Have a generic fetch function for POST and PUT requests in vue modules Rebase to 32806 and prior to 32925. Squash More updates. Ready for review, for now. JD amended patch: * prettier * remove changes to AgreementRelationships.vue and EHoldingsLocalPackageAgreements.vue to have less files to update in upcoming patches Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147030|0 |1 is obsolete| | Attachment #147031|0 |1 is obsolete| | Attachment #147032|0 |1 is obsolete| | Attachment #147033|0 |1 is obsolete| | Attachment #147034|0 |1 is obsolete| | Attachment #147035|0 |1 is obsolete| | Attachment #147036|0 |1 is obsolete| | Attachment #147037|0 |1 is obsolete| | Attachment #147038|0 |1 is obsolete| | Attachment #147039|0 |1 is obsolete| | Attachment #147040|0 |1 is obsolete| | Attachment #147041|0 |1 is obsolete| | Attachment #147042|0 |1 is obsolete| | Attachment #147043|0 |1 is obsolete| | Attachment #147044|0 |1 is obsolete| | Attachment #147056|0 |1 is obsolete| | --- Comment #40 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 147057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147057&action=edit Bug 32939: Have a generic fetch function for POST and PUT requests in vue modules Rebase to 32806 and prior to 32925. Squash More updates. Ready for review, for now. JD amended patch: * prettier * remove changes to AgreementRelationships.vue and EHoldingsLocalPackageAgreements.vue to have less files to update in upcoming patches Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 --- Comment #42 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 147060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147060&action=edit Bug 32939: Set the default header at lower level Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 --- Comment #44 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 147062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147062&action=edit Bug 32939: Introduce count Not used yet, will replace myFetchTotal Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 --- Comment #46 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 147064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147064&action=edit Bug 32939: Uniformize api calls We want to make the call easier and without less errors possible. Here, no need to async keyword, try-catch, etc. Only call the method and use the common then with the 2 success and error Promise arguments. We will certainly want to add later a parameter to prevent the display of the error in fetchJSON, in case the failure does not require a message for the end user. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 --- Comment #48 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 147066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147066&action=edit Bug 32939: Use APIClient to fetch licenses Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 --- Comment #50 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 147068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147068&action=edit Bug 32939: Use APIClient to fetch vendors Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 --- Comment #52 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 147070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147070&action=edit Bug 32939: Use APIClient to fetch EBSCO eHoldings Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 --- Comment #54 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 147072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147072&action=edit Bug 32939: Use APIClient to replace some more fetch calls Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 --- Comment #57 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to David Cook from comment #56)

I wonder if it would be useful to implement a simple feature or a Koha plugin using Vue.js to see which components need to be specific to ERM and which need to be more generalized/re-usable...

I am already working on another module, on top of this tree. This is the result of the different situations I faced. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147059|0 |1 is obsolete| | --- Comment #60 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 147307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147307&action=edit Bug 32939: Have a generic APIClient object You always import the same, only once, and you can access other resources from the same object. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147061|0 |1 is obsolete| | --- Comment #62 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 147309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147309&action=edit Bug 32939: Restore checkError Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147063|0 |1 is obsolete| | --- Comment #64 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 147311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147311&action=edit Bug 32939: Fix delete Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147065|0 |1 is obsolete| | --- Comment #66 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 147313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147313&action=edit Bug 32939: Use APIClient to fetch agreements Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147067|0 |1 is obsolete| | --- Comment #68 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 147315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147315&action=edit Bug 32939: Use APIClient to fetch patrons Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147069|0 |1 is obsolete| | --- Comment #70 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 147317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147317&action=edit Bug 32939: Use APIClient to fetch local eHoldings Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147071|0 |1 is obsolete| | --- Comment #72 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 147319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147319&action=edit Bug 32939: Remove fetch/erm.js Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147073|0 |1 is obsolete| | --- Comment #74 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 147321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147321&action=edit Bug 32939: Use APIClient to replace PATCH requests Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 --- Comment #76 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Really cool to see how this thing is evolving! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.04 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 Bug 32939 depends on bug 32806, which changed state. Bug 32806 Summary: Some Vue files need to be moved for better reusability https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33290 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33290 [Bug 33290] Incorrect variable used in http-client.js -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33443 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33443 [Bug 33443] The "X titles found locally" not displayed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33485 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33485 [Bug 33485] Add/remove title from holdings is not using the correct endpoint -- You are receiving this mail because: You are watching all bug changes.