[Bug 38683] New: Opac cover images are only shown on fist result page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38683 Bug ID: 38683 Summary: Opac cover images are only shown on fist result page Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: bibliothek@th-wildau.de QA Contact: testopia@bugs.koha-community.org When using cover images on the opac there is a strange behavior when there are more than 1 result pages. On the first result page everything works like expected, but on the subsequent result pages the cover images are not shown. to reproduce: - set system preference OPACAmazonCoverImages to show - open opac an search for "and" - the html structure for each result row is like: <td class="selectcol"></td> <td class="numcol"></td> <td class="covercol"></td> <td class="bibliocol"></td> - then go to the second result page and check that the row structure differs now <td class="selectcol"></td> <td class="numcol"></td> <td class="bibliocol"></td> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38683 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Severity|minor |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38683 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Opac cover images are only |Opac cover images are only |shown on fist result page |shown on first result page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38683 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38683 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 175404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175404&action=edit Bug 38683: Opac cover images are only shown on fist result page This patch corrects the OPAC search results template so that cover images will be added on more than just the first page of results. To test, apply the patch and enable a cover image system preference e.g. OPACAmazonCoverImages. Perform a search in the OPAC which will return multiple pages of results. Page through several pages of results to confirm that cover images appear on each page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38683 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26933 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933 [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38683 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Opac cover images are only |OPAC cover images are only |shown on first result page |shown on first result page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38683 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175404|0 |1 is obsolete| | --- Comment #2 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 175416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175416&action=edit Bug 38683: Opac cover images are only shown on fist result page This patch corrects the OPAC search results template so that cover images will be added on more than just the first page of results. To test, apply the patch and enable a cover image system preference e.g. OPACAmazonCoverImages. Perform a search in the OPAC which will return multiple pages of results. Page through several pages of results to confirm that cover images appear on each page. Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38683 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175416|0 |1 is obsolete| | --- Comment #3 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 175417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175417&action=edit Bug 38683: Opac cover images are only shown on fist result page This patch corrects the OPAC search results template so that cover images will be added on more than just the first page of results. To test, apply the patch and enable a cover image system preference e.g. OPACAmazonCoverImages. Perform a search in the OPAC which will return multiple pages of results. Page through several pages of results to confirm that cover images appear on each page. Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38683 SamSowanick <sam.sowanick@corvallisoregon.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sam.sowanick@corvallisorego | |n.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38683 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes OPAC search release notes| |results when cover images | |are enabled - covers are | |now shown on all the result | |pages, instead of just the | |first page of results. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38683 Bug 38683 depends on bug 26933, which changed state. Bug 26933 Summary: Improve handling of multiple covers on catalog search results in the OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38683 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38683 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175417|0 |1 is obsolete| | --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175487&action=edit Bug 38683: Opac cover images are only shown on fist result page This patch corrects the OPAC search results template so that cover images will be added on more than just the first page of results. To test, apply the patch and enable a cover image system preference e.g. OPACAmazonCoverImages. Perform a search in the OPAC which will return multiple pages of results. Page through several pages of results to confirm that cover images appear on each page. Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38683 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |matt.blenkinsop@ptfs-europe |y.org |.com CC| |matt.blenkinsop@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38683 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38683 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38683 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38683 --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38683 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz --- Comment #7 from Alex Buckley <alexbuckley@catalyst.net.nz> --- not backporting to 24.05.x unless requested - dependency not in 24.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38683 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org