[Bug 16952] New: Add sorting rules for Czech language to Zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952 Bug ID: 16952 Summary: Add sorting rules for Czech language to Zebra Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: josef.moravec@gmail.com QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |black23@gmail.com Assignee|koha-bugs@lists.koha-commun |josef.moravec@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952 --- Comment #1 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 53556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53556&action=edit Bug 16952: Czech language definitions for sorting in Zebra Test plan: 1) Apply patch 2) Create new instance with parameter --zebralang cs 3) Insert some record with basic latin characters and some with "czech" characters (for example: "č" - should be sorted after "c", "š" - should be sorted after "s") 4) Try to search in katalog (staff and opac) and sort by other field then relevance - title or author for instance 5) Records should be sorted correctly by Czech rules 6) Look at code and confirm it is ok -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952 Mike <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952 Mike <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rbit@rbit.cz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952 --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- If you aren't building and installing packages after applying patches (which is most cases I think) you may need copy the new configuration file to /etc directory manually: mkdir /etc/koha/zebradb/lang_defs/cs cp etc/zebradb/lang_defs/cs/sort-string-utf.chr /etc/koha/zebradb/lang_defs/cs/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952 --- Comment #3 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- The right copy command for kohadevbox is following: cp /home/vagrant/kohaclone/etc/zebradb/lang_defs/cs/sort-string-utf.chr /etc/koha/zebradb/lang_defs/cs/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952 --- Comment #4 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- In my opinion, czech alphabet needs better sorting of characters like "a" vs. "á". For instance "Cáchovnice" should be sorted after "Carevna", but it's not: http://prntscr.com/cvrem1 I think we cannot consider eéě as the same one to be perfect. This is the correct ordering of czech characters: https://cs.wikipedia.org/wiki/Česká_abeceda -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952 --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- It's not true. For sorting shouldn't be used full czech alphabet. See https://cs.wikipedia.org/wiki/Abecedn%C3%AD_%C5%99azen%C3%AD or https://albatros.vlada.cz/usneseni/usneseni_webtest.nsf/WebGovRes/0AD8FEF4CC... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952 --- Comment #6 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- Regardning your last post, the sorting is much more sofisticated. The simplified (your) alphabet is used only when we actually CAN decide about hte correct order. If we cannot, it's required to use special signs like in this example: - Sálá - Sála In this case the secondary ordering rule should be taken into account, I think. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952 --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Radek Šiman (R-Bit Technology, s.r.o.) from comment #6)
Regardning your last post, the sorting is much more sofisticated. The simplified (your) alphabet is used only when we actually CAN decide about hte correct order. If we cannot, it's required to use special signs like in this example: - Sálá - Sála In this case the secondary ordering rule should be taken into account, I think.
According to Zebra documentation here: http://www.indexdata.com/zebra/doc/character-map-files.html It looks like zebra is not capable doing 2-level sorting... So propably this could be better than nothing, as it looks like secondary sorting is edge case... what do you think? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952 --- Comment #8 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- Yes, I agree, that we should sort the texts somehow reasonably. What do you think about using my first proposal, ie. sorting like aábcčdďeéě...? This seems to me as more accurate approach, even if it's not as defined simplified standard rules. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952 --- Comment #9 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Radek Šiman (R-Bit Technology, s.r.o.) from comment #8)
Yes, I agree, that we should sort the texts somehow reasonably. What do you think about using my first proposal, ie. sorting like aábcčdďeéě...? This seems to me as more accurate approach, even if it's not as defined simplified standard rules.
I can't agree with you, it would be more unaccurate approach, because if use the current patches, we are able to perfectly match the primary level of sortng as defined by ČSN 97 6030. But with your approach with doesn't implement anything... Moreover, the primary level works in most cases and merging primary and secondary levels rules together just ends like a mess in my opinion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952 --- Comment #10 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- Ok, let's use ČSN's primary level only. Continuing the signoff process... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952 --- Comment #11 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- Unfortunately it seems, there are some issues to be solved. For instance "Kýbl" and "Kapr" are sorted in incorrect order. http://prntscr.com/cwj9mj -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53556|0 |1 is obsolete| | --- Comment #12 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56683&action=edit Bug 16952: Czech language definitions for sorting in Zebra Test plan: 1) Apply patch 2) Create new instance with parameter --zebralang cs 3) Insert some record with basic latin characters and some with "czech" characters (for example: "č" - should be sorted after "c", "š" - should be sorted after "s") 4) Try to search in katalog (staff and opac) and sort by other field then relevance - title or author for instance 5) Records should be sorted correctly by Czech rules 6) Look at code and confirm it is ok -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952 --- Comment #13 from Josef Moravec <josef.moravec@gmail.com> --- Thanks for testing! I've rebased on master and added some mappings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952 --- Comment #14 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- What about this case...? - Kůň - Kuna http://prntscr.com/cx4101 I'm not sure if this is the right order if taking ČSN Level 1 into account. What do you thnk? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952 --- Comment #15 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Radek Šiman (R-Bit Technology, s.r.o.) from comment #14)
What about this case...? - Kůň - Kuna
I'm not sure if this is the right order if taking ČSN Level 1 into account. What do you thnk?
I think it is right order according to this, example 2 and 3: https://cs.wikipedia.org/wiki/Abecedn%C3%AD_%C5%99azen%C3%AD#P.C5.99.C3.ADkl... and this example - motýl noční - motýlek from http://prirucka.ujc.cas.cz/?id=900 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56683|0 |1 is obsolete| | --- Comment #16 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- Created attachment 56733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56733&action=edit Bug 16952: Czech language definitions for sorting in Zebra Test plan: 1) Apply patch 2) Create new instance with parameter --zebralang cs 3) Insert some record with basic latin characters and some with "czech" characters (for example: "č" - should be sorted after "c", "š" - should be sorted after "s") 4) Try to search in katalog (staff and opac) and sort by other field then relevance - title or author for instance 5) Records should be sorted correctly by Czech rules 6) Look at code and confirm it is ok Signed-off-by: radiuscz <radek.siman@centrum.cz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56733|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 56833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56833&action=edit Bug 16952: Czech language definitions for sorting in Zebra Test plan: 1) Apply patch 2) Create new instance with parameter --zebralang cs 3) Insert some record with basic latin characters and some with "czech" characters (for example: "č" - should be sorted after "c", "š" - should be sorted after "s") 4) Try to search in katalog (staff and opac) and sort by other field then relevance - title or author for instance 5) Records should be sorted correctly by Czech rules 6) Look at code and confirm it is ok Signed-off-by: radiuscz <radek.siman@centrum.cz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> I did not test this patch, but trust in the author and signoffer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Josef! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #19 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.06. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org