[Bug 12399] New: opaccredits printing at top on printable version
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12399 Bug ID: 12399 Summary: opaccredits printing at top on printable version Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org Created attachment 28758 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28758&action=edit footer printing near top When printing the OPAC in Bootstrap on 3.14 and master the footer prints at the top - see attached. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12399 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #1 from Marc Véron <veron@veron.ch> --- I can confirm this behaviour. It displays the Koha credits at the wrong place as well. To reproduce: In Opac with Bootstrap theme, do a search with many results. It seems that the credits should not display at all in print version, because in opac-tmpl/bootstrap/css/print.css, line 205, a class .koha_url gets "display:none". However, there is no class koha_url in the HTML code, but an Id koha_url that should be addressed as #koha_url Regarding the Id opaccredits (containing the contents from system preference opaccredits), I do not find any traces in print.css -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12399 --- Comment #2 from Marc Véron <veron@veron.ch> --- Still valid in current master 3.19.00.008 Additionally, Language selector displays at top of page 2 and overlays other text. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12399 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12399 --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 35711 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35711&action=edit Bug 12399 - opaccredits printing at top on printable version This patch introduces a new class "noprint" in koha-tmpl/opac-tmpl/bootstrap/css/print.css With this class, unwanted elements can be hidden when printing. To test: In OPAC, do a search with many results (> 1 Page) Print page or do a print preview See that footer elements are not displayed correctly (as of screenshot in comment #1) and that on top of page 2 the language selector overlays the list Apply patch Repeat steps above. Verify that printed page looks much nicer now by hiding unwanted elements (including e.g. RSS icon, toolbar etc.) This mechanism can be used on other pages as well. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12399 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12399 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12399 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35711|0 |1 is obsolete| | --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 36263 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36263&action=edit Bug 12399 - opaccredits printing at top on printable version This patch introduces a new class "noprint" in koha-tmpl/opac-tmpl/bootstrap/css/print.css With this class, unwanted elements can be hidden when printing. To test: In OPAC, do a search with many results (> 1 Page) Print page or do a print preview See that footer elements are not displayed correctly (as of screenshot in comment #1) and that on top of page 2 the language selector overlays the list Apply patch Repeat steps above. Verify that printed page looks much nicer now by hiding unwanted elements (including e.g. RSS icon, toolbar etc.) This mechanism can be used on other pages as well. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12399 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12399 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36263|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 36536 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36536&action=edit [PASSED QA] Bug 12399 - opaccredits printing at top on printable version This patch introduces a new class "noprint" in koha-tmpl/opac-tmpl/bootstrap/css/print.css With this class, unwanted elements can be hidden when printing. To test: In OPAC, do a search with many results (> 1 Page) Print page or do a print preview See that footer elements are not displayed correctly (as of screenshot in comment #1) and that on top of page 2 the language selector overlays the list Apply patch Repeat steps above. Verify that printed page looks much nicer now by hiding unwanted elements (including e.g. RSS icon, toolbar etc.) This mechanism can be used on other pages as well. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12399 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 36537 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36537&action=edit Bug 12399: Small change to remove the whole paging Previous patch only removed the next and previous buttons. This patch changes it a bit to remove the whole paging from the print view of the page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12399 --- Comment #7 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 36538 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36538&action=edit Bug 12399 - opaccredits printing at top on printable version This patch introduces a new class "noprint" in koha-tmpl/opac-tmpl/bootstrap/css/print.css With this class, unwanted elements can be hidden when printing. To test: In OPAC, do a search with many results (> 1 Page) Print page or do a print preview See that footer elements are not displayed correctly (as of screenshot in comment #1) and that on top of page 2 the language selector overlays the list Apply patch Repeat steps above. Verify that printed page looks much nicer now by hiding unwanted elements (including e.g. RSS icon, toolbar etc.) This mechanism can be used on other pages as well. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12399 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36537|0 |1 is obsolete| | --- Comment #8 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 36539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36539&action=edit Bug 12399: Small change to remove the whole paging Previous patch only removed the next and previous buttons. This patch changes it a bit to remove the whole paging from the print view of the page. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12399 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Attachment #36538|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12399 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12399 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- String changes held for 3.18.6 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12399 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org