[Bug 21548] New: ILLLIBS patron category / partner_code seems extraneous
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 Bug ID: 21548 Summary: ILLLIBS patron category / partner_code seems extraneous Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.isherwood@ptfs-europe.com The original installation notes created by Alex for ILL (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317#c20) describe a requirement to create a new patron category with a code ILLLIBS, organisational patrons are then attached to this category and their email address is used for the "Place request with partners" function. However, Koha ships with a patron category called "Inter-Library Loans" (code: IL) which would appear to remove the requirement for an ILLLIBS category to be created. This bug proposes moving away from using ILLLIBS and using the pre-existing IL category instead. Grepping the code for ILLLIBS reveals that it's assumed to exist and will be used as a default code if one is not specified in the <partner_code> element in koha-conf.xml, so modifications will be required. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Andrew, I think using the existing value from the sample data makes sense. But could we make the code configurable? Preferrably moving the current setting out of the conf file and into a pref? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 --- Comment #2 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- That would certainly make sense Katrin, there's quite a bit of the ILL config that would benefit from moving out of koha-conf.xml into sysprefs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19822 --- Comment #3 from Magnus Enger <magnus@libriotech.no> --- Bug 19822 suggests to shift the ILL config from koha-conf.xml to sysprefs. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 Niamh Walker-Headon <Niamh.WalkerHeadon@hse.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Niamh.WalkerHeadon@hse.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Move to pref and change default to IL are still both great ideas. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19822 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 [Bug 19822] Add system preferences for ILL Module -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 146333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146333&action=edit 21548: ILLLIBS patron category / partner_code seems extraneous This patch updates the default partner category used by the partner_code config to be in line with sample data in sample_patrons.yml Preparation: Apply patch Enable ILLModule sys pref Install an ILL backend (e.g. FreeForm) Add this change to your koha-conf.xml Flush, restart. Search for patron of category inter-library loan and assign a primary e-mail address to it Test plan: Create an ILL request and click 'place request with partners' Verify that the 'select partner libraries' has the correct patron of IL category Run tests and ensure they pass: prove t/db_dependent/Illrequest/Config.t prove t/Koha/Config.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32911 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 147416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147416&action=edit Bug 21548: ILLLIBS patron category / partner_code seems extraneous This patch updates the default partner category used by the partner_code config to be in line with sample data in sample_patrons.yml Preparation: Apply patch Enable ILLModule sys pref Install an ILL backend (e.g. FreeForm) Add this change to your koha-conf.xml Flush, restart. Search for patron of category inter-library loan and assign a primary e-mail address to it Test plan: Create an ILL request and click 'place request with partners' Verify that the 'select partner libraries' has the correct patron of IL category Run tests and ensure they pass: prove t/db_dependent/Illrequest/Config.t prove t/Koha/Config.t Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146333|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We should have done this ages ago :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148977&action=edit Bug 33276: Get auth values for location on serials Serial location is linked to a library, if we want to modify serial with users does not belongs to, location is not in select and we could erase it. Test plan: 1) Be sure to have a LOC authorized value limited to one library at least 2) See when editing serial subscription you didn't get the current location 3) Apply this patch 4) Refresh and now you've got the value Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147416|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148978&action=edit Bug 21548: ILLLIBS patron category / partner_code seems extraneous This patch updates the default partner category used by the partner_code config to be in line with sample data in sample_patrons.yml Preparation: Apply patch Enable ILLModule sys pref Install an ILL backend (e.g. FreeForm) Add this change to your koha-conf.xml Flush, restart. Search for patron of category inter-library loan and assign a primary e-mail address to it Test plan: Create an ILL request and click 'place request with partners' Verify that the 'select partner libraries' has the correct patron of IL category Run tests and ensure they pass: prove t/db_dependent/Illrequest/Config.t prove t/Koha/Config.t Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Attachment #148977|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ILLLIBS patron category / |Make ILL patron category in |partner_code seems |koha-conf.xml match with |extraneous |ILL patron category in | |sample data -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |matt.blenkinsop@ptfs-europe | |.com --- Comment #11 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 Aude Charillon <aude.charillon@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |Needs documenting Documentation| |Aude Charillon contact| | CC| |aude.charillon@ptfs-europe. | |com --- Comment #12 from Aude Charillon <aude.charillon@ptfs-europe.com> --- Manual will need to be updated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 --- Comment #13 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- *** Bug 30820 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |**Sponsored by** *PTFS release notes| |Europe* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|**Sponsored by** *PTFS |**Sponsored by** *PTFS release notes|Europe* |Europe* | | | |This makes sure, | |that in the future the | |Inter-Library Loan (IL) | |patron category of the | |sample data matches the | |default configuration of | |the ILL patron category in | |the `koha-conf.xml` file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 Aude Charillon <aude.charillon@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/695 Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #14 from Aude Charillon <aude.charillon@ptfs-europe.com> --- 23.05 Manual updated. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org