[Bug 5979] New: OPAC : using OPACISBD systempreference to display link
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Bug #: 5979 Summary: OPAC : using OPACISBD systempreference to display link Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: chris@bigballofwax.co.nz QAContact: koha-bugs@lists.koha-community.org Blocks: 5584 The OPACISBD system preference is used in order to be able to have one ISBD for OPAC another one for intranet. But the link ISBD at OPAC was depending on the presence or absence of value in ISBD which is for intranet. This patch fixes the behaviour to depend on the correct system preference at OPAC -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff Severity|enhancement |normal -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-28 21:08:06 UTC --- Created attachment 3480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3480 Proposed Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|oleonard@myacpl.org |paul.poulain@biblibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2011-03-29 15:17:07 UTC --- This patch alters the scripts but lacks any change to preferences or the database. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|paul.poulain@biblibre.com |henridamien@koha-fr.org --- Comment #3 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-04-01 09:43:10 UTC --- This bug is mentioned in: Bug 5979 : OPAC : using OPACISBD systempreference to display link http://lists.koha-community.org/pipermail/koha-patches/2011-March/014296.htm... --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> 2011-05-23 12:42:04 UTC --- The idea behind this patch is correct: there are some problems with isbd when you do some advanced things, as links are supposed to be replaced on the fly depending on you're on opac or staff. Also, one may want to have a different ISBD on staff and on opac. This patch is quite incomplete though. Affecting it to hdl again -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com AssignedTo|henridamien@koha-fr.org |alex.arnaud@biblibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #5 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 10029 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10029&action=edit Bug 5979 - Follow up: using OPACISBD systempreference to display link -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from Alex Arnaud <alex.arnaud@biblibre.com> --- This follow up adds the OPACISBD syspref -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 CC| |katrin.fischer@bsz-bw.de Version|rel_3_4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3480|0 |1 is obsolete| | Attachment #10029|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 10326 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10326&action=edit [SIGNED-OFF] Bug 5979 : OPAC : using OPACISBD systempreference to display link The OPACISBD system preference is used in order to be able to have one ISBD for OPAC another one for intranet. But the link ISBD at OPAC was depending on the presence or absence of value in ISBD which is for intranet. This patch fixes the behaviour to depend on the correct system preference at OPAC Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 10327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10327&action=edit [SIGNED-OFF] Bug 5979 - Follow up: using OPACISBD systempreference to display link Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Verified that new system preference is added cleanly and ISBD view can be configured independently for staff and OPAC using OPACISBD and viewISBD system preferences. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |koha.sekjal@gmail.com --- Comment #9 from Ian Walls <koha.sekjal@gmail.com> --- OPACISBD exists in ru-RU and uk-UA language sysprefs only... very odd. In that context, it's a text area, rather than a boolean. It looks like this perference was added back around 3.00.05.001, but is not longer part of the default installation. The first patch is fine; it changes the logic to use OPACISBD in the opac. But getting that preference properly installed where it may not already be is something else. If OPACISBD syspref is not present in newer installs, we should create one that is congruent with the original intent. A YesNo type is not appropriate in this context Failed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m Patch complexity|--- |Medium patch --- Comment #10 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Seems like OPACISBD was a syspref to configure an OPAC specific ISBD view, that's why it is a textarea. Why not using 2 syspref in OPAC like in intranet : ISBD and OPACISBD : ISBD config for intranet/OPAC viewISBD and OPACviewISBD : allow ISBD view in intranet/OPAC -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=3734 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- Can someone clarify the point of this bug? I'm not sure I understand, and it has been sitting Failed QA for nearly 3 years. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #12 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Is the ISBD view even used today ? Since the XSLT are largely used for a customised view. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli@cineca.it --- Comment #13 from Zeno Tajoli <z.tajoli@cineca.it> --- I confirm that ISBD view (opac and intranet) is wide used here in Italy. The main user are librarians. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10327|0 |1 is obsolete| | --- Comment #14 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 44123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44123&action=edit Bug 5979 - Follow up: using OPACISBD systempreference to display link -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #15 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 44126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44126&action=edit Bug 5979 - OPAC ISBD view has its own syspref -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #16 from Alex Arnaud <alex.arnaud@biblibre.com> --- Syspref OPACISBD is now a textarea so it's possible to have a different template in staff and opac. I didn't add a "OPACviewISBD", empty OPACISBD is enough for disable ISBD view in opac. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10326|0 |1 is obsolete| | --- Comment #17 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 44208 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44208&action=edit [SIGNED-OFF] Bug 5979 : OPAC : using OPACISBD systempreference to display link The OPACISBD system preference is used in order to be able to have one ISBD for OPAC another one for intranet. But the link ISBD at OPAC was depending on the presence or absence of value in ISBD which is for intranet. This patch fixes the behaviour to depend on the correct system preference at OPAC Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Verified that new system preference is added cleanly and ISBD view can be configured independently for staff and OPAC using OPACISBD and viewISBD system preferences. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44123|0 |1 is obsolete| | --- Comment #18 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 44209 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44209&action=edit [SIGNED-OFF] Bug 5979 - Follow up: using OPACISBD systempreference to display link Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44126|0 |1 is obsolete| | --- Comment #19 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 44210 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44210&action=edit [SIGNED-OFF] Bug 5979 - OPAC ISBD view has its own syspref Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works well, empty OPACISBD removes link. Test pass. Small koha-qa error fixed in followup -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #20 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 44211 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44211&action=edit Bug 5979: follow to fix spelling Changed Montains -> Mountains koha-qa complains!! Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) Please copy the current ISBD into OPACISBD to keep the same behaviour as before the patch for an installation with a modified ISBD view. 2) Please amend the ISBD preference description to include "staff", so it's more clear about the new difference. 3) The tests output some warnings, please take a look to see if they can be fixed: ok 1 - use C4::Biblio; Use of uninitialized value $template in string eq at /home/katrin/kohaclone/C4/Biblio.pm line 926. Use of uninitialized value $template in string eq at /home/katrin/kohaclone/C4/Biblio.pm line 998. Use of uninitialized value $template in string eq at /home/katrin/kohaclone/C4/Biblio.pm line 1010. Use of uninitialized value $template in string eq at /home/katrin/kohaclone/C4/Biblio.pm line 998. Use of uninitialized value $template in string eq at /home/katrin/kohaclone/C4/Biblio.pm line 1010. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPAC : using OPACISBD |Add separate OPACISBD |systempreference to display |system preference |link | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, also a question: if we have separate preferences, do we really still need 4 preferences? Could we have only 2 preferences and deactivate the feature by emptying them out? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #23 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Katrin Fischer from comment #22)
Hm, also a question: if we have separate preferences, do we really still need 4 preferences? Could we have only 2 preferences and deactivate the feature by emptying them out?
Hello Katrin, We have 3 preferences. 2 for staff (ISBD, viewISBD) and 1 for OPAC (OPACISBD). I agree that we don't need 2 preferences for staff as we do the same job with 1 on opac. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Alex, you are right, sorry - I think I misread last night. I think deduplicating the 2 staff preferences would be good, but on a separate bug :) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org