[Bug 41663] New: Wrong syspref values in some db_revs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41663 Bug ID: 41663 Summary: Wrong syspref values in some db_revs Initiative type: --- Sponsorship --- status: Product: Koha Version: 24.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs@lists.koha-community.org Reporter: lucasmontoya@theke.io QA Contact: testopia@bugs.koha-community.org CC: tomascohen@gmail.com When upgrading Koha from version 24.11.x to the latest release, several warnings are displayed regarding system preferences that are incorrectly configured. Specifically, the following system preferences are expected to have boolean values (0 or 1), but are currently set to an empty value (''): ILLHistoryCheck ILLOpacUnauthenticatedRequest SeparateHoldingsByGroup Additionally, there is a system preference, RequireChoosingExistingAuthority, which is currently disabled. However, a warning indicates that AutoCreateAuthorities must be enabled; otherwise, catalogers may add headings that are not linked to authority records. To replicate the issue: Initialize a fresh instance of ktd, using main as the default branch in the Koha repository. Run git reset --hard 24.11.x. Run ktd --shell to enter the container. Run reset_all to downgrade the database to 24.11. Exit the shell and run git reset --hard origin/main to switch back to the latest version of Koha. Run ktd --shell again to re-enter the container. Run updatedatabase && yarn build to apply the upgrade. Go to localhost:8081 (or the assigned port for the admin interface) -> More -> 'About Koha' -> 'System information' You should be able to see the warning messages -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41663 --- Comment #1 from Lucas <lucasmontoya@theke.io> --- Created attachment 191694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191694&action=edit Bug 41663: Update system preferences default values - Replace default values from '' to '0' for 'ILLHistoryCheck', 'ILLOpacUnauthenticatedRequest' and 'SeparateHoldingsByGroup' avoiding warning messages to be displayed in 'About Koha' page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41663 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41663 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|24.11 |Main Status|Needs Signoff |Failed QA --- Comment #2 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Lucas, a couple issues: (1) Why don't you just ```sql UPDATE systempreferences SET value=0 WHERE type='YesNo' AND value=''; ``` that would cover some other cases as well (i.e. people coming from versions older than 24.11) (2) You commit message should include a concrete test plan. In my opinion your first message here contains half of the test plan, so you would need to add a step that tells the tester to start over, but when switching to main, apply this patch first or similar. Thanks for taking care of this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41663 Lucas <lucasmontoya@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #3 from Lucas <lucasmontoya@theke.io> --- Yes, that makes sense to me. As you said, that would cover other possible cases. I'm going to complete the test plan and apply the suggested changes. Thanks for the feedback! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41663 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucasmontoya@theke.io |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41663 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Wrong syspref values in |Wrong YesNo syspref values |some db_revs |in some db_revs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41663 --- Comment #4 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Lucas from comment #3)
Yes, that makes sense to me.
As you said, that would cover other possible cases.
It would also make the patch more easily backportable, which I think will happen. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41663 Lucas <lucasmontoya@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Sponsorship status|--- |Sponsored QA Contact|testopia@bugs.koha-communit |lucasmontoya@theke.io |y.org | Comma delimited| |Universidad de la Frontera list of Sponsors| | --- Comment #5 from Lucas <lucasmontoya@theke.io> --- Bug Update for Bug 41663 - Wrong YesNo syspref values in some db_revs Current status: Needs Signoff Current QA-contact: testopia@bugs.koha-community.org Current sponsorship: Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41663 Lucas <lucasmontoya@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191694|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41663 --- Comment #6 from Lucas <lucasmontoya@theke.io> --- Created attachment 191719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191719&action=edit Bug 41663: Update system preferences default values This patch replace default values from '' to '0' for all system preferences which type is 'YesNo' avoiding warning messages to be displayed in 'About Koha' page. To test: 1 - Initialize a fresh instance of ktd, using main as the default branch in the Koha repository. 2 - Run git reset --hard 24.11.x. 3 - Run ktd --shell to enter the container. 4 - Run reset_all to downgrade the database to 24.11. 5 - Exit the shell and run git reset --hard origin/main to switch back to the latest version of Koha. 6 - Run ktd --shell again to re-enter the container. 7 - Run updatedatabase && yarn build to apply the upgrade. 8 - Go to localhost:8081 (or the assigned port for the admin interface) -> More -> 'About Koha' -> 'System information' and you should be able to see the warning messages 9 - Repeat steps 1-4 10 - Exit the shell and apply this patch 11 - Repeat steps 6-8 12 - Congrats! You shouldn't see the related warnings anymore! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41663 Lucas <lucasmontoya@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|lucasmontoya@theke.io |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41663 Lucas <lucasmontoya@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41663 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41663 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191719|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41663 --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 191720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191720&action=edit Bug 41663: Update system preferences default values This patch replace default values from '' to '0' for all system preferences which type is 'YesNo' avoiding warning messages to be displayed in 'About Koha' page. To test: 1 - Initialize a fresh instance of ktd, using main as the default branch in the Koha repository. 2 - Run git reset --hard 24.11.x. 3 - Run ktd --shell to enter the container. 4 - Run reset_all to downgrade the database to 24.11. 5 - Exit the shell and run git reset --hard origin/main to switch back to the latest version of Koha. 6 - Run ktd --shell again to re-enter the container. 7 - Run updatedatabase && yarn build to apply the upgrade. 8 - Go to localhost:8081 (or the assigned port for the admin interface) -> More -> 'About Koha' -> 'System information' and you should be able to see the warning messages 9 - Repeat steps 1-4 10 - Exit the shell and apply this patch 11 - Repeat steps 6-8 12 - Congrats! You shouldn't see the related warnings anymore! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41663 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #8 from David Nind <david@davidnind.com> --- I muddled my way through testing this, and everything worked: 1. I had to checkout 24.11.x locally so that it was available (git checkout 24.11.x) 2. I don't have git bz installed locally, so ran any applying patches and so on within the ktd shell. 3. System preferences that had the warning before the patch: Warning System preference 'ILLHistoryCheck' must be '0' or '1', but is ''. Warning System preference 'ILLOpacUnauthenticatedRequest' must be '0' or '1', but is ''. Warning System preference 'SeparateHoldingsByGroup' must be '0' or '1', but is ''. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41663 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- We could go with this, but please note that bug 41682 is planning to fix way more inconsistencies for sysprefs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41663 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41682 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41663 Lucas <lucasmontoya@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Signed Off |RESOLVED --- Comment #10 from Lucas <lucasmontoya@theke.io> --- I think Jonathan's patch already covers my case and is more complete, since it also improves the tests. Closing the ticket. *** This bug has been marked as a duplicate of bug 41682 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org