[Bug 12605] New: TestBuilder - Refactoring Acquisition/close_reopen_basket.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12605 Bug ID: 12605 Summary: TestBuilder - Refactoring Acquisition/close_reopen_basket.t Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: yohann.dufour@biblibre.com QA Contact: gmcharlt@gmail.com In order to see what the module TestBuilder can bring to the writing of tests, the tests in Acquisition/close_reopen_basket.t have been refactored with the use of TestBuilder. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12605 Yohann Dufour <yohann.dufour@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|chris@bigballofwax.co.nz |yohann.dufour@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12605 Yohann Dufour <yohann.dufour@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch Depends on| |12603 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12605 --- Comment #1 from Yohann Dufour <yohann.dufour@biblibre.com> --- Created attachment 29851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29851&action=edit Bug 12604: refactoring close_reopen_basket.t with TestBuilder The tests have been refactored with the module TestBuilder. Test plan: 1/ Apply the patch 12603 and the last patch of bug 11518. 2/ The command : prove t/db_dependent/Acquisition/close_reopen_basket.t has to be a success without error or warning : t/db_dependent/Acquisition/close_reopen_basket.t .. ok All tests successful. Files=1, Tests=7, 1 wallclock secs ( 0.03 usr 0.01 sys + 1.71 cusr 0.09 csys = 1.84 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12605 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12605 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29851|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30089 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30089&action=edit [SIGNED-OFF] Bug 12604: refactoring close_reopen_basket.t with TestBuilder The tests have been refactored with the module TestBuilder. Test plan: 1/ Apply the patch 12603 and the last patch of bug 11518. 2/ The command : prove t/db_dependent/Acquisition/close_reopen_basket.t has to be a success without error or warning : t/db_dependent/Acquisition/close_reopen_basket.t .. ok All tests successful. Files=1, Tests=7, 1 wallclock secs ( 0.03 usr 0.01 sys + 1.71 cusr 0.09 csys = 1.84 CPU) Result: PASS http://bugs.koha-community.org/show_bug.cgi?id=12605 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12605 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Version|unspecified |master QA Contact|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12605 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- CONFLICT (content): Merge conflict in t/db_dependent/Acquisition/close_reopen_basket.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12605 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 30089 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30089 [SIGNED-OFF] Bug 12604: refactoring close_reopen_basket.t with TestBuilder Review of attachment 30089: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12605&attachment=30089) ----------------------------------------------------------------- ::: t/db_dependent/Acquisition/close_reopen_basket.t @@ -46,5 @@
-my ($ordernumber1, $ordernumber2); -( undef, $ordernumber1 ) = C4::Acquisition::NewOrder( - { - basketno => $basketno, - quantity => 24,
How is this "quantity" reflected in the refactored code? @@ -55,5 @@
-( undef, $ordernumber2 ) = C4::Acquisition::NewOrder( - { - basketno => $basketno, - quantity => 42,
How is this "quantity" reflected in the refactored code? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org