[Bug 29225] New: Report subgroup does not appear consistently
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29225 Bug ID: 29225 Summary: Report subgroup does not appear consistently Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: bwsdonna@gmail.com QA Contact: testopia@bugs.koha-community.org It appears that bug 24958 (remember last selected tab in SQL reports) may have caused this bug. When you leave the Saved Reports page /guided_reports.pl?phase=Use%20saved and come back to it, the tab you were on is retained, but the subgroup dropdown does not appear. You have to click on another tab and then click back to the tab you were on to get the subgroup dropdown to show. To recreate: 1. In Saved reports have one tab, such as circulation, with subgroups associated with it. 2. Log in and go to reports - use saved, and click on Circulation tab. 3. Note the Subgroups drop down. 4. Run a report or go to a different area of Koha. 5. Come back to reports - Saved and see that you are still on the Circulation tab, but the Subgroups drop down does not show. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29225 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29225 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 126276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126276&action=edit Bug 29225: Don't hide subgroup filter on pag load When we auto select the last used tab, we hit code that hides the Subgroup dropdown Clicking to other tabs shows the dropdown again There is code on the tab selection to hide subgroups on the 'All' tab, the other line seems superfluous To test: 1 - Create a report and assign a group and subgroup, creating if necessary 2 - Browse to "Reports->Use saved" 3 - Click on the tab for the report you just created, see the subgroups dropdown 4 - Reload the page, Subgroups dropdown disappears 5 - Apply patch 6 - Relaod the page 7 - It's back! 8 - Confirm dropdown filters as expected -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29225 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Depends on| |24958 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24958 [Bug 24958] Remember last selected tab in SQL reports -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29225 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126276|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 126278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126278&action=edit Bug 29225: Don't hide subgroup filter on pag load When we auto select the last used tab, we hit code that hides the Subgroup dropdown Clicking to other tabs shows the dropdown again There is code on the tab selection to hide subgroups on the 'All' tab, the other line seems superfluous To test: 1 - Create a report and assign a group and subgroup, creating if necessary 2 - Browse to "Reports->Use saved" 3 - Click on the tab for the report you just created, see the subgroups dropdown 4 - Reload the page, Subgroups dropdown disappears 5 - Apply patch 6 - Relaod the page 7 - It's back! 8 - Confirm dropdown filters as expected Signed-off-by: Donna <donna@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29225 Donna <bwsdonna@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29225 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.05 |unspecified CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29225 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Good catch! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29225 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29225 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126278|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126621&action=edit Bug 29225: Don't hide subgroup filter on pag load When we auto select the last used tab, we hit code that hides the Subgroup dropdown Clicking to other tabs shows the dropdown again There is code on the tab selection to hide subgroups on the 'All' tab, the other line seems superfluous To test: 1 - Create a report and assign a group and subgroup, creating if necessary 2 - Browse to "Reports->Use saved" 3 - Click on the tab for the report you just created, see the subgroups dropdown 4 - Reload the page, Subgroups dropdown disappears 5 - Apply patch 6 - Relaod the page 7 - It's back! 8 - Confirm dropdown filters as expected Signed-off-by: Donna <donna@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29225 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29225 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29225 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29225 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.11 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29225 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor@tuxayo.net --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org