[Bug 17524] New: Datepicker on checkout fails when dateformat = iso
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17524 Bug ID: 17524 Summary: Datepicker on checkout fails when dateformat = iso Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Circulation Assignee: jonathan.druart@bugs.koha-community.org Reporter: magnus@libriotech.no QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com This surfaced after upgrading to 16.05.05. To reproduce: - Make sure dateformat = iso - Go to the checkout screen for some patron - Click on "Checkout settings" - Try to pick a date from the calendar -> nothing happens - Try to enter an iso date -> you get a js popup saying "Please enter a valid date (should match yyyy-mm-dd)" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17524 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17524 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17524 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57001&action=edit Bug 17524: Fix datepicker check for iso dates Iso dates are yyyy-mm-dd, the is_valid JS function expects \d{2}-\d{2}-\d{4} when it should be \d{4}-\d{2}-\d{2} Test plan: Switch DateFormat to iso Set a due date using the datepicker => Should work as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17524 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14060 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Caused by bug 14060 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 [Bug 14060] Remove readonly on date inputs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17524 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This should be backported ASAP, please test & QA quickly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17524 --- Comment #5 from Magnus Enger <magnus@libriotech.no> --- I have applied the fix to a live server and it works, I'll do a signoff later today if noone beats me to it. Thanks for a very quick fix, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17524 --- Comment #6 from Magnus Enger <magnus@libriotech.no> --- (In reply to Nick Clemens from comment #1)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876
? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17524 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17524 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57001|0 |1 is obsolete| | --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 57006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57006&action=edit Bug 17524: Fix datepicker check for iso dates Iso dates are yyyy-mm-dd, the is_valid JS function expects \d{2}-\d{2}-\d{4} when it should be \d{4}-\d{2}-\d{2} Test plan: Switch DateFormat to iso Set a due date using the datepicker => Should work as expected Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17524 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17524 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57006|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 57007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57007&action=edit Bug 17524: Fix datepicker check for iso dates Iso dates are yyyy-mm-dd, the is_valid JS function expects \d{2}-\d{2}-\d{4} when it should be \d{4}-\d{2}-\d{2} Test plan: Switch DateFormat to iso Set a due date using the datepicker => Should work as expected Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17524 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- P.S. This is bigger than just checkout. Member birth dates, for example. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17524 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17524 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Status|Pushed to Master |Pushed to Stable --- Comment #11 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.06. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17524 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org