[Bug 28120] New: Koha Account pay is logging fine amountoutstanding as 0 when paying selected lines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28120 Bug ID: 28120 Summary: Koha Account pay is logging fine amountoutstanding as 0 when paying selected lines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org We have hardcoded a 0 into the logs in Koha/Account.pm 170 new_amountoutstanding => 0, To recreate: 1 - Find a patron with debits, or charge a debit manually 2 - On the patron's accoutning tab Select 'Make a payment' 3 - Select the line and click 'Pay selected' 4 - Pay less than the full amount owed 5 - Go to Tools->log viewer 6 - Enter the patrons borrowernumber into 'Object' and hit enter 7 - Notice the fines log says 'new_amountoutstanding' => 0 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28120 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28120 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I would question whether we actually need the FinesLog at all now... we record all the details as offsets so the finesLog is redundant at this point. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28120 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |kyle@bywatersolutions.com Status|NEW |In Discussion --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Nick, Kyle, would you agree to remove FinesLog? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28120 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The log appears to have changed quite a bit since: $VAR1 = { 'note' => '', 'itemnumber' => undef, 'credit_type_code' => 'PAYMENT', 'description' => '', 'borrowernumber' => 51, 'amount' => -4, 'amountoutstanding' => -4, 'action' => 'create_PAYMENT', 'branchcode' => 'CPL', 'manager_id' => 51 }; Argueably as my fine was 5.00, the amountoutstanding should probably be 1? I am not sure about removing the fines log. It cannot be accessed as easily from the GUI - maybe we need to think how to make the information more visible/resusable first. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org