[Bug 12507] New: Don't show News in Staff and opac in 3.16.0 / 3.16.1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 Bug ID: 12507 Summary: Don't show News in Staff and opac in 3.16.0 / 3.16.1 Change sponsored?: --- Product: Koha Version: 3.14 Hardware: PC OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: felipe.gomez3@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com In these versions news HOMEPAGE staff and OPAC disappear. I have the error un the NewsChannels.pm file. /usr/share/koha/lib/C4/NewsChannels.pm the error is solved by simply changing the quotes in the line 200: OLD: AND `timestamp` < CURRENT_DATE()+1 NEW: AND 'timestamp' < CURRENT_DATE()+1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 MetaBiblioteca Colombia <felipe.gomez3@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |3.16 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Please paste the error. The news feature works fine for me in the OPAC and staff client in version 3.16.01. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |--- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- I can confirm this bug. There is no error message in the logs! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30410 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30410&action=edit Bug 12507 - Don't show News in Staff and opac -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- I have no idea how to trigger this bug, but the tester can at least prove it does not cause a regression, I think that should be enough! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |--- Assignee|kyle@bywatersolutions.com |koha-bugs@lists.koha-commun | |ity.org Summary|Don't show News in Staff |News does not always |and opac in 3.16.0 / 3.16.1 |display in staff or OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30410|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30411 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30411&action=edit Bug 12507 - News does not always display in staff or OPAC News will not display on the last day of each month due to the way the date is calculated in the SQL code for grabbing news. Test Plan: 1) Create a news item that should display 2) Change your server's date to the last day of the month 3) Note you can no longer see that news item 4) Apply this patch 5) Note you can now see your news item again -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30411|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 30412 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30412&action=edit [SIGNED-OFF] Bug 12507 - News does not always display in staff or OPAC News will not display on the last day of each month due to the way the date is calculated in the SQL code for grabbing news. Test Plan: 1) Create a news item that should display 2) Change your server's date to the last day of the month 3) Note you can no longer see that news item 4) Apply this patch 5) Note you can now see your news item again Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Staff Client |Tools Hardware|PC |All Version|3.16 |master Assignee|koha-bugs@lists.koha-commun |gmcharlt@gmail.com |ity.org | OS|Linux |All -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 --- Comment #7 from MetaBiblioteca Colombia <felipe.gomez3@gmail.com> --- Many Thanks for this patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30499&action=edit [PASSED QA] Bug 12507 - News does not always display in staff or OPAC News will not display on the last day of each month due to the way the date is calculated in the SQL code for grabbing news. Test Plan: 1) Create a news item that should display 2) Change your server's date to the last day of the month 3) Note you can no longer see that news item 4) Apply this patch 5) Note you can now see your news item again Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30412|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ideally this should have a regression test, but I am not sure how to pretend a specific date for the test to work as it's using SQL to get the current date. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com Keywords| |rel_3_16_candidate Status|Pushed to Master |Pushed to Stable --- Comment #11 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 --- Comment #12 from Mason James <mtj@kohaaloha.com> --- (In reply to Mason James from comment #11)
Pushed to 3.16.x, will be in 3.16.10
Fridolyn, you might want this for 3.14.x? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12507 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org