[Bug 13880] New: Allow svc/report to be passed sql parameters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13880 Bug ID: 13880 Summary: Allow svc/report to be passed sql parameters Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org The same feature added to the opac svc/report in bug 9915 should be added to the staff side. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13880 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Reports |and plumbing | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13880 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13880 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13880 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37042&action=edit Bug 13880 - Allow svc/report to be passed sql parameters The same feature added to the opac svc/report in bug 9915 should be added to the staff side. Test Plan: 1) Apply this patch 2) Create this report: SELECT * FROM biblio WHERE biblionumber = <<biblionumber>> 3) Note the id of the report 4) Go to the URL /cgi-bin/koha/svc/report?id=YOUR_REPORT_ID&sql_params=SOME_VALID_BIBLIONUMBER 5) Note you recieve a json response -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13880 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13880 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37042|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37390 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37390&action=edit Bug 13880 - Allow svc/report to be passed sql parameters The same feature added to the opac svc/report in bug 9915 should be added to the staff side. Test Plan: 1) Apply this patch 2) Create this report: SELECT * FROM biblio WHERE biblionumber = <<biblionumber>> 3) Note the id of the report 4) Go to the Staff URL /cgi-bin/koha/svc/report?id=YOUR_REPORT_ID&sql_params=SOME_VALID_BIBLIONUMBER 5) Note you recieve a json response NOTE: without applying the patch you get an empty JSON response. ALSO: running koha qa tools does not verify the changes. $ perlcritic -4 svc/report (my perlcritic rc points to the koha qa tool one) No issues. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13880 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13880 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37390|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38170&action=edit Bug 13880 - Allow svc/report to be passed sql parameters The same feature added to the opac svc/report in bug 9915 should be added to the staff side. Test Plan: 1) Apply this patch 2) Create this report: SELECT * FROM biblio WHERE biblionumber = <<biblionumber>> 3) Note the id of the report 4) Go to the Staff URL /cgi-bin/koha/svc/report?id=YOUR_REPORT_ID&sql_params=SOME_VALID_BIBLIONUMBER 5) Note you recieve a json response NOTE: without applying the patch you get an empty JSON response. ALSO: running koha qa tools does not verify the changes. $ perlcritic -4 svc/report (my perlcritic rc points to the koha qa tool one) No issues. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13880 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13880 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master CC| |katrin.fischer@bsz-bw.de Summary|Allow svc/report to be |Allow svc/report to be |passed sql parameters |passed sql parameters for | |non-public reports -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13880 Tom Misilo <misilot@fit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot@fit.edu -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org