[Bug 17703] New: Add ISSN column in serials claims table - fix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 Bug ID: 17703 Summary: Add ISSN column in serials claims table - fix Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com Bug 11861 added ISSN column in serials claims table, in a SQL query in C4::Serials::GetLateOrMissingIssues(). But this SQL query is in a if condition, the same change must be done in the else case. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11861 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11861 [Bug 11861] Add ISSN column in serials claims table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 57832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57832&action=edit Bug 17703 - Add ISSN column in serials claims table - fix Bug 11861 added ISSN column in serials claims table, in a SQL query in C4::Serials::GetLateOrMissingIssues(). But this SQL query is in a if condition, the same change must be done in the else case. Test plan: 1/ Go to serials claims page 2/ Do not choose a vendor and submit 3/ You should see a ISSN column, filled with subscription ISSN -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Fridolin, can you check your test plan? I have tested, but didn't manage to not have the ISSN column filled on claim serials page. In your test plan you say: 2/ Do not choose a vendor and submit But this is not possible int he GUI - there is no empyt entry in the pull down and an entry there only appears for a vendor with late serial issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57832|0 |1 is obsolete| | --- Comment #3 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 65454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65454&action=edit Bug 17703 - Add ISSN column in serials claims table - fix Bug 11861 added ISSN column in serials claims table, in a SQL query in C4::Serials::GetLateOrMissingIssues(). But this SQL query is in a if condition, the same change must be done in the else case. Test plan: - Make sure you have a subscription with some late issues - Go to serials claims page /cgi-bin/koha/serials/claims.pl - Choose a vendor and click OK => You should see a ISSN column, filled with subscription ISSN -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 --- Comment #4 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Ahhhhh oups no this change is needed for CSV export. I rewrite test plan -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Fridolin SOMERS from comment #4)
Ahhhhh oups no this change is needed for CSV export. I rewrite test plan
I even rewrite method to use common SQL query with only condition on WHERE. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65454|0 |1 is obsolete| | --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 65455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65455&action=edit Bug 17703 - Add ISSN column in serials claims table - fix Bug 11861 added ISSN column in serials claims table and a SQL query in C4::Serials::GetLateOrMissingIssues(). But this SQL query is in a if $supplierid condition, the same change must be done if $serialid to allow ISSN in CVS export of claims. This patch rewrites the method to have a common SQL query with conditions only on WHERE. Removes the order input arg since it is never used, order in TT is managed by DataTable and CSV export is generated with the order of selected rows. Test plan: - Make sure you have a subscription with some late or missing issues - Go to Tool > CSV profils - Create a profile : Profile name = Issues to claim Profile type = SQL Usage = Late serial issues claims Profile SQL fields = SUPPLIER=aqbooksellers.name|TITLE=subscription.title|ISSN=subscription.issn|ISSUE NUMBER=serial.serialseq|LATE SINCE=serial.planneddate - Go to serials claims page : /cgi-bin/koha/serials/claims.pl - Choose a vendor and click OK - You see serials to claim, with ISSN column filled with subscription's ISSN - Check all lines - Select "Issues to claim" CSV profile - Click on "Download selected claims" => With patch you have ISSN value - Run UT t/db_dependent/Serials/Claims.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65455|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 66150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66150&action=edit [SIGNED OFF] Bug 17703 - Add ISSN column in serials claims table - fix Bug 11861 added ISSN column in serials claims table and a SQL query in C4::Serials::GetLateOrMissingIssues(). But this SQL query is in a if $supplierid condition, the same change must be done if $serialid to allow ISSN in CVS export of claims. This patch rewrites the method to have a common SQL query with conditions only on WHERE. Removes the order input arg since it is never used, order in TT is managed by DataTable and CSV export is generated with the order of selected rows. Test plan: - Make sure you have a subscription with some late or missing issues - Go to Tool > CSV profils - Create a profile : Profile name = Issues to claim Profile type = SQL Usage = Late serial issues claims Profile SQL fields = SUPPLIER=aqbooksellers.name|TITLE=subscription.title|ISSN=subscription.issn|ISSUE NUMBER=serial.serialseq|LATE SINCE=serial.planneddate - Go to serials claims page : /cgi-bin/koha/serials/claims.pl - Choose a vendor and click OK - You see serials to claim, with ISSN column filled with subscription's ISSN - Check all lines - Select "Issues to claim" CSV profile - Click on "Download selected claims" => With patch you have ISSN value - Run UT t/db_dependent/Serials/Claims.t Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- please provide a test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ISSN column in serials |Always add ISSN in serials |claims table - fix |claims issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 101994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101994&action=edit Bug 17703: Always add ISSN in serials claims issues Bug 11861 added ISSN column in serials claims table and a SQL query in C4::Serials::GetLateOrMissingIssues(). But this SQL query is in a if $supplierid condition, the same change must be done if $serialid to allow ISSN in CVS export of claims. This patch rewrites the method to have a common SQL query with conditions only on WHERE. Removes the order input arg since it is never used, order in TT is managed by DataTable and CSV export is generated with the order of selected rows. Test plan: - Make sure you have a subscription with some late or missing issues - Go to Tool > CSV profils - Create a profile : Profile name = Issues to claim Profile type = SQL Usage = Late serial issues claims Profile SQL fields = SUPPLIER=aqbooksellers.name|TITLE=subscription.title|ISSN=subscription.issn|ISSUE NUMBER=serial.serialseq|LATE SINCE=serial.planneddate - Go to serials claims page : /cgi-bin/koha/serials/claims.pl - Choose a vendor and click OK - You see serials to claim, with ISSN column filled with subscription's ISSN - Check all lines - Select "Issues to claim" CSV profile - Click on "Download selected claims" => With patch you have ISSN value Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66150|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 101996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101996&action=edit Bug 17703: add unit test Run : prove t/db_dependent/Serials/Claims.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101994|0 |1 is obsolete| | --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 101997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101997&action=edit Bug 17703: Always add ISSN in serials claims issues Bug 11861 added ISSN column in serials claims table and a SQL query in C4::Serials::GetLateOrMissingIssues(). But this SQL query is in a if $supplierid condition, the same change must be done if $serialid to allow ISSN in CVS export of claims. This patch rewrites the method to have a common SQL query with conditions only on WHERE. Removes the order input arg since it is never used, order in TT is managed by DataTable and CSV export is generated with the order of selected rows. Test plan: - Make sure you have a subscription with some late or missing issues - Go to Tool > CSV profils - Create a profile : Profile name = Issues to claim Profile type = SQL Usage = Late serial issues claims Profile SQL fields = SUPPLIER=aqbooksellers.name|TITLE=subscription.title|ISSN=subscription.issn|ISSUE NUMBER=serial.serialseq|LATE SINCE=serial.planneddate - Go to serials claims page : /cgi-bin/koha/serials/claims.pl - Choose a vendor and click OK - You see serials to claim, with ISSN column filled with subscription's ISSN - Check all lines - Select "Issues to claim" CSV profile - Click on "Download selected claims" => With patch you have ISSN value Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 --- Comment #12 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 102000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102000&action=edit Bug 17703: Add unit tests Run : prove t/db_dependent/Serials/Claims.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101997|0 |1 is obsolete| | --- Comment #13 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 102001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102001&action=edit Bug 17703: Always add ISSN in serials claims issues Bug 11861 added ISSN column in serials claims table and a SQL query in C4::Serials::GetLateOrMissingIssues(). But this SQL query is in a if $supplierid condition, the same change must be done if $serialid to allow ISSN in CVS export of claims. This patch rewrites the method to have a common SQL query with conditions only on WHERE. Removes the order input arg since it is never used, order in TT is managed by DataTable and CSV export is generated with the order of selected rows. Test plan: - Make sure you have a subscription with some late or missing issues - Go to Tool > CSV profils - Create a profile : Profile name = Issues to claim Profile type = SQL Usage = Late serial issues claims Profile SQL fields = SUPPLIER=aqbooksellers.name|TITLE=subscription.title|ISSN=subscription.issn|ISSUE NUMBER=serial.serialseq|LATE SINCE=serial.planneddate - Go to serials claims page : /cgi-bin/koha/serials/claims.pl - Choose a vendor and click OK - You see serials to claim, with ISSN column filled with subscription's ISSN - Check all lines - Select "Issues to claim" CSV profile - Click on "Download selected claims" => With patch you have ISSN value Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101996|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 --- Comment #14 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #8)
please provide a test.
Here it is. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102000|0 |1 is obsolete| | --- Comment #15 from David Nind <david@davidnind.com> --- Created attachment 102197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102197&action=edit Bug 17703: Add unit tests Run : prove t/db_dependent/Serials/Claims.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102001|0 |1 is obsolete| | --- Comment #16 from David Nind <david@davidnind.com> --- Created attachment 102199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102199&action=edit Bug 17703: Always add ISSN in serials claims issues Bug 11861 added ISSN column in serials claims table and a SQL query in C4::Serials::GetLateOrMissingIssues(). But this SQL query is in a if $supplierid condition, the same change must be done if $serialid to allow ISSN in CVS export of claims. This patch rewrites the method to have a common SQL query with conditions only on WHERE. Removes the order input arg since it is never used, order in TT is managed by DataTable and CSV export is generated with the order of selected rows. Test plan: - Make sure you have a subscription with some late or missing issues - Go to Tool > CSV profils - Create a profile : Profile name = Issues to claim Profile type = SQL Usage = Late serial issues claims Profile SQL fields = SUPPLIER=aqbooksellers.name|TITLE=subscription.title|ISSN=subscription.issn|ISSUE NUMBER=serial.serialseq|LATE SINCE=serial.planneddate - Go to serials claims page : /cgi-bin/koha/serials/claims.pl - Choose a vendor and click OK - You see serials to claim, with ISSN column filled with subscription's ISSN - Check all lines - Select "Issues to claim" CSV profile - Click on "Download selected claims" => With patch you have ISSN value Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Tests are failing for me. t/db_dependent/Serials/Claims.t .. 2/20 # Failed test 'subscription 1 should have 1 issue in late' # at t/db_dependent/Serials/Claims.t line 172. # got: '0' # expected: '1' # Failed test 'return of GetLateOrMissingIssues() contains biblioitems.issn' # at t/db_dependent/Serials/Claims.t line 173. # got: undef # expected: '123456789' # Looks like you failed 2 tests of 20. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102197|0 |1 is obsolete| | --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 119444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119444&action=edit Bug 17703: Add unit tests Run : prove t/db_dependent/Serials/Claims.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119444|0 |1 is obsolete| | --- Comment #19 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 119445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119445&action=edit Bug 17703: Add unit tests Run : prove t/db_dependent/Serials/Claims.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102199|0 |1 is obsolete| | --- Comment #20 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 119446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119446&action=edit Bug 17703: Always add ISSN in serials claims issues Bug 11861 added ISSN column in serials claims table and a SQL query in C4::Serials::GetLateOrMissingIssues(). But this SQL query is in a if $supplierid condition, the same change must be done if $serialid to allow ISSN in CVS export of claims. This patch rewrites the method to have a common SQL query with conditions only on WHERE. Removes the order input arg since it is never used, order in TT is managed by DataTable and CSV export is generated with the order of selected rows. Test plan: - Make sure you have a subscription with some late or missing issues - Go to Tool > CSV profils - Create a profile : Profile name = Issues to claim Profile type = SQL Usage = Late serial issues claims Profile SQL fields = SUPPLIER=aqbooksellers.name|TITLE=subscription.title|ISSN=subscription.issn|ISSUE NUMBER=serial.serialseq|LATE SINCE=serial.planneddate - Go to serials claims page : /cgi-bin/koha/serials/claims.pl - Choose a vendor and click OK - You see serials to claim, with ISSN column filled with subscription's ISSN - Check all lines - Select "Issues to claim" CSV profile - Click on "Download selected claims" => With patch you have ISSN value Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 --- Comment #21 from Fridolin Somers <fridolin.somers@biblibre.com> --- I've removed from unit test : +use C4::Serials; This is already managed by : use_ok('C4::Serials'); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 --- Comment #22 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #17)
Tests are failing for me.
t/db_dependent/Serials/Claims.t .. 2/20 # Failed test 'subscription 1 should have 1 issue in late' # at t/db_dependent/Serials/Claims.t line 172. # got: '0' # expected: '1'
# Failed test 'return of GetLateOrMissingIssues() contains biblioitems.issn' # at t/db_dependent/Serials/Claims.t line 173. # got: undef # expected: '123456789' # Looks like you failed 2 tests of 20.
Works for me, can you retest please ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Still failing, same errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 --- Comment #24 from Fridolin Somers <fridolin.somers@biblibre.com> ---
Failed test 'subscription 1 should have 1 issue in late' Stange, my patch does not impact this test o_O
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hum, retested today and the tests pass on a fresh install. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- root@kohadevbox:koha(bug17703-qa)$ prove t/db_dependent/Serials/Claims.t t/db_dependent/Serials/Claims.t .. 16/20 # Failed test 'subscription 1 should have 1 issue in late' # at t/db_dependent/Serials/Claims.t line 171. # got: '0' # expected: '1' # Failed test 'return of GetLateOrMissingIssues() contains biblioitems.issn' # at t/db_dependent/Serials/Claims.t line 172. # got: undef # expected: '123456789' # Looks like you failed 2 tests of 20. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Always add ISSN in serials |Always export ISSN in |claims issues |serials claims issues CSV -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org