[Bug 24848] New: Help link from label creator batch/layout/template points to card creator in manual
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848 Bug ID: 24848 Summary: Help link from label creator batch/layout/template points to card creator in manual Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Clicking the help button from various points within label-manage.pl takes one to the patron card creator area of the manual. It should point to the relevant label bits instead. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andrew@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 100714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100714&action=edit Bug 24848: Improve manual links for the label creator Some of the manual links in the label creator tool were not working correctly or pointing to the wrong pages. A problem is the label-manage.pl file. This can show different data depending on an added parameter. Example: /cgi-bin/koha/labels/label-manage.pl?label_element=template But it appears that parameters will be ignored when creating links to the manual. So this patch links to the beginning of the label creator section in the manual for now. To test: - Go to the lable creator - Try the various pages of the tool - Note: All 'New ...' links should point to the correct section in the manual (batches, templates, ...) Except: Barcode range. This feature is new and not yet documented in the manual. Link goes to label creator section. - Note: All 'Manage ...' links should point to the beginning of the 'label creator' section in the manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The solution is not perfect - label-manage.pl is a problem still (see patch description). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|andrew@bywatersolutions.com |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry Andrew for stealing this one - noticed too late. :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24873 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24873 [Bug 24873] Linking between files and manual pages should support URL parameters (label-manage.pl) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Not a problem at all! Thanks for the patch! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100714|0 |1 is obsolete| | --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 100899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100899&action=edit Bug 24848: Improve manual links for the label creator Some of the manual links in the label creator tool were not working correctly or pointing to the wrong pages. A problem is the label-manage.pl file. This can show different data depending on an added parameter. Example: /cgi-bin/koha/labels/label-manage.pl?label_element=template But it appears that parameters will be ignored when creating links to the manual. So this patch links to the beginning of the label creator section in the manual for now. To test: - Go to the lable creator - Try the various pages of the tool - Note: All 'New ...' links should point to the correct section in the manual (batches, templates, ...) Except: Barcode range. This feature is new and not yet documented in the manual. Link goes to label creator section. - Note: All 'Manage ...' links should point to the beginning of the 'label creator' section in the manual Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100899|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 101108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101108&action=edit Bug 24848: Improve manual links for the label creator Some of the manual links in the label creator tool were not working correctly or pointing to the wrong pages. A problem is the label-manage.pl file. This can show different data depending on an added parameter. Example: /cgi-bin/koha/labels/label-manage.pl?label_element=template But it appears that parameters will be ignored when creating links to the manual. So this patch links to the beginning of the label creator section in the manual for now. To test: - Go to the lable creator - Try the various pages of the tool - Note: All 'New ...' links should point to the correct section in the manual (batches, templates, ...) Except: Barcode range. This feature is new and not yet documented in the manual. Link goes to label creator section. - Note: All 'Manage ...' links should point to the beginning of the 'label creator' section in the manual Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101108|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101110&action=edit Bug 24848: Improve manual links for the label creator Some of the manual links in the label creator tool were not working correctly or pointing to the wrong pages. A problem is the label-manage.pl file. This can show different data depending on an added parameter. Example: /cgi-bin/koha/labels/label-manage.pl?label_element=template But it appears that parameters will be ignored when creating links to the manual. So this patch links to the beginning of the label creator section in the manual for now. To test: - Go to the lable creator - Try the various pages of the tool - Note: All 'New ...' links should point to the correct section in the manual (batches, templates, ...) Except: Barcode range. This feature is new and not yet documented in the manual. Link goes to label creator section. - Note: All 'Manage ...' links should point to the beginning of the 'label creator' section in the manual Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Kyle: we're clashing now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #10 from Joy Nelson <joy@bywatersolutions.com> --- backported to 19.11.x for 19.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.05 |20.05.00, 19.11.05, released in| |19.05.10 CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24848 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #12 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Not an issue in 18.11, not backporting to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org