[Bug 29965] New: MARC preview for authority search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29965 Bug ID: 29965 Summary: MARC preview for authority search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org Bug 12533 added a MARC preview for authority search results to the cataloguing authority finder plugin. This modal would be useful for the general authority search results as sometimes you want to compare authorities in the results list. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29965 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12533 Status|NEW |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12533 [Bug 12533] Improve authority search result display -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29965 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 129918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129918&action=edit Bug 29965: Preview MARC in authority search results This enhancement makes the authority MARC preview modal available for the general authority search results. To test: 1) Do a catalog search and edit a biblio record 2) Go to one of the authority tags (i.e. 1xx, 6xx, 7xx) and open the authority finder plugin 3) Do an authority search 4) Click on one of the search result headings to open the modal. Confirm it opens as expected. 5) Exit the biblio editor and go to Authorities 6) Do an authority search 7) Click on the MARC preview button to open the modal. Confirm it opens as expected. Sponsored-by: Education Services Australia SCIS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29965 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement makes the release notes| |authority MARC preview | |modal available for the | |general authority search | |results. Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29965 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I think for consistency the preview button should be in the Actions menu (see cataloging search). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29965 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29965 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129918|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 129983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129983&action=edit Bug 29965: Preview MARC in authority search results This enhancement makes the authority MARC preview modal available for the general authority search results. To test: 1) Do a catalog search and edit a biblio record 2) Go to one of the authority tags (i.e. 1xx, 6xx, 7xx) and open the authority finder plugin 3) Do an authority search 4) Click on one of the search result headings to open the modal. Confirm it opens as expected. 5) Exit the biblio editor and go to Authorities 6) Do an authority search 7) Click on the Actions dropdown, then the MARC preview button, to open the modal. Confirm it opens as expected. Sponsored-by: Education Services Australia SCIS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29965 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29965 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129983|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 130635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130635&action=edit Bug 29965: Preview MARC in authority search results This enhancement makes the authority MARC preview modal available for the general authority search results. To test: 1) Do a catalog search and edit a biblio record 2) Go to one of the authority tags (i.e. 1xx, 6xx, 7xx) and open the authority finder plugin 3) Do an authority search 4) Click on one of the search result headings to open the modal. Confirm it opens as expected. 5) Exit the biblio editor and go to Authorities 6) Do an authority search 7) Click on the Actions dropdown, then the MARC preview button, to open the modal. Confirm it opens as expected. Sponsored-by: Education Services Australia SCIS Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29965 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30131 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30131 [Bug 30131] Centralize "marc preview" buttons and links -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29965 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130635|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 130880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130880&action=edit Bug 29965: Preview MARC in authority search results This enhancement makes the authority MARC preview modal available for the general authority search results. To test: 1) Do a catalog search and edit a biblio record 2) Go to one of the authority tags (i.e. 1xx, 6xx, 7xx) and open the authority finder plugin 3) Do an authority search 4) Click on one of the search result headings to open the modal. Confirm it opens as expected. 5) Exit the biblio editor and go to Authorities 6) Do an authority search 7) Click on the Actions dropdown, then the MARC preview button, to open the modal. Confirm it opens as expected. Sponsored-by: Education Services Australia SCIS Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29965 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 130881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130881&action=edit Bug 29965: (follow-up) Move repeated JS to its own file Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29965 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 130882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130882&action=edit Bug 29965: (follow-up) Use a new class for the preview With previous patches everythign worked, however, clicking the heading in authority search results now launched the preview instead of taking you to the authority details This patch uses a new class to launch the modal and conditionally applies it to authority results as we expect different behaviours when searching from the popup vs authority module To test: 1 - Repeate previous tests, confirm they pass 2 - Search for authorities in the authority module 3 - COnfirm clicking on heading takes you to detail page for authority Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29965 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- I added a bit, could use another QA eye -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29965 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29965 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130880|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 130907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130907&action=edit Bug 29965: Preview MARC in authority search results This enhancement makes the authority MARC preview modal available for the general authority search results. To test: 1) Do a catalog search and edit a biblio record 2) Go to one of the authority tags (i.e. 1xx, 6xx, 7xx) and open the authority finder plugin 3) Do an authority search 4) Click on one of the search result headings to open the modal. Confirm it opens as expected. 5) Exit the biblio editor and go to Authorities 6) Do an authority search 7) Click on the Actions dropdown, then the MARC preview button, to open the modal. Confirm it opens as expected. Sponsored-by: Education Services Australia SCIS Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29965 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130881|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 130908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130908&action=edit Bug 29965: (follow-up) Move repeated JS to its own file Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29965 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130882|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 130909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130909&action=edit Bug 29965: (follow-up) Use a new class for the preview With previous patches everythign worked, however, clicking the heading in authority search results now launched the preview instead of taking you to the authority details This patch uses a new class to launch the modal and conditionally applies it to authority results as we expect different behaviours when searching from the popup vs authority module To test: 1 - Repeate previous tests, confirm they pass 2 - Search for authorities in the authority module 3 - COnfirm clicking on heading takes you to detail page for authority Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29965 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 130910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130910&action=edit Bug 29965: (QA follow-up) Fix translation issue in moved JS code Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29965 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- This is great :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29965 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29965 --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29965 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29965 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |timothy_alexis.vass@ub.lu.s | |e --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 28247 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org