[Bug 12987] New: Update table footer with the visible rows
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 Bug ID: 12987 Summary: Update table footer with the visible rows Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org For instance, on acqui/acqui-home.pl and admin/aqbudgets.pl, it would be great to see the totals in the footer updated with the filtered rows. This patch will offer the possibility to do that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |12986 Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31853&action=edit Bug 12987: Update table footer with the visible rows This patch is the preparation step for others. On acqui/acqui-home.pl and admin/aqbudgets.pl, it will be possible to see the totals in the footer updated with the filtered rows. Test plan: This cannot be tested alone, you have to apply it with others (see the "Blocked" bug reports). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31853|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31854 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31854&action=edit Bug 12987: Update table footer with the visible rows This patch is the preparation step for others. On acqui/acqui-home.pl and admin/aqbudgets.pl, it will be possible to see the totals in the footer updated with the filtered rows. Test plan: This cannot be tested alone, you have to apply it with others (see the "Blocked" bug reports). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12989 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12988 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31976&action=edit Bug 12987: The new format_price include file should be include on using datatables -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 32019 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32019&action=edit Bug 12987: Fix remove all what is not number The regex was wrong, to calculate a total, we should keep number (0-9) and minus sign (-). All others characters should be removed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Last patch is stupid, it does not take into account decimal prices. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32019|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- To test this patch (actually bug 12988 and bug 12989), you need to apply bug 12844 (and bug 12979). I forgot this dependency, that's why it does not work. Bug 12844 removes the currency symbol on the aqbudgets page. The problem arises if the currency symbol is displayed. It could (and will) be fixed later. I cannot fix everything without to be sure these patches will be pushed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12844 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- In the future we might need to extend the IF to handle other ones, but for now that is no reason not to sign off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31854|0 |1 is obsolete| | --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 32094 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32094&action=edit Bug 12987: Update table footer with the visible rows This patch is the preparation step for others. On acqui/acqui-home.pl and admin/aqbudgets.pl, it will be possible to see the totals in the footer updated with the filtered rows. Test plan: This cannot be tested alone, you have to apply it with others (see the "Blocked" bug reports). Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31976|0 |1 is obsolete| | --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 32095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32095&action=edit Bug 12987: The new format_price include file should be include on using datatables Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- More bread crumbs - This can only be tested with another bug, so apply first bug 12984 and then bug 12989. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32094|0 |1 is obsolete| | Attachment #32095|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32812&action=edit [PASSED QA] Bug 12986: Upgrade the DataTables jQuery plugin to the latest version (1.10.2) DataTables 1.10.2 is now available. The footerCallback function does not seem to work correctly with our current version. Test plan: Go on the maximum of pages where DataTables is used and try to catch a bug/regression :) Signed-off-by: Owen Leonard <oleonard@myacpl.org> I tested many many pages with DataTables, taking special care to find pages with different DataTables configurations. I found no errors in the OPAC or staff client. Tested thoroughly in Firefox (latest) on Windows 7. Tested less thoroughly in Chrome (latest) on Windows 7. Tested briefly in Internet Explorer 7 in Vista and Internet Explorer 8 and found no bugs which were related to the DataTables upgrade. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32813&action=edit [PASSED QA] Bug 12987: Update table footer with the visible rows This patch is the preparation step for others. On acqui/acqui-home.pl and admin/aqbudgets.pl, it will be possible to see the totals in the footer updated with the filtered rows. Test plan: This cannot be tested alone, you have to apply it with others (see the "Blocked" bug reports). Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32812|0 |1 is obsolete| | Attachment #32813|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32814 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32814&action=edit [PASSED QA] Bug 12987: Update table footer with the visible rows This patch is the preparation step for others. On acqui/acqui-home.pl and admin/aqbudgets.pl, it will be possible to see the totals in the footer updated with the filtered rows. Test plan: This cannot be tested alone, you have to apply it with others (see the "Blocked" bug reports). Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32815&action=edit [PASSED QA] Bug 12987: The new format_price include file should be include on using datatables Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org