[Bug 25807] New: Upgrade between 19.11 and 20.05 results in corrupted circulation_rules data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25807 Bug ID: 25807 Summary: Upgrade between 19.11 and 20.05 results in corrupted circulation_rules data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com I just did a trial upgrade of a site and it resulted in 2769 rules in the circulation_rules table.. many of them duplicates and generally a corrupt set of data. (We had 246 circulation_rules and just 87 issuingrules prior to the upgrade being run). It appears to be an error in the update query of bug 18936 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25807 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm.. the table looks right.. but the display is wrong... Investigating further. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25807 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |normal --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Reducing priority because although I can replicate it regularly, with the exact same dataset Jonathan cannot. I believe it's something to do with DB version but as yet haven't managed to narrow it down further. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25807 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25807 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Right.. this isn't data related at all.. it's Module version related. I have been running my dev environment with the latest dependencies from CPAN.. it seems Template 3.008 broke support for the [% SET variable UNLESS condition %] syntax which we are using in the smart rules template. See https://github.com/abw/Template2/issues/263 for the bug report upstream -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25807 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Upgrade between 19.11 and |Upgrade between 19.11 and |20.05 results in corrupted |20.05 results in corrupted |circulation_rules data |circulation_rules display -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25807 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Upgrade between 19.11 and |Version 3.008 of Template |20.05 results in corrupted |breaks smart-rules display |circulation_rules display | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25807 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106241&action=edit Bug 25807: Add Template 3.008 to the exclude list This patch adds version 3.008 of Template to the excludes list in our cpanfile. It also adds support for displaying this version on the about page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25807 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25807 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25807 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Test plan 1/ Ensure you have a version of Template installed that is supported (i.e >= 2.22 but not 3.008) 2/ Look at the about page and note `2.22, !3.008` is displayed for the 'Template' module in 'grey' 3/ Update your version of Template to 3.008 (cpanm Template@3.008) 4/ Refresh the about screen and note that 'Template' now displays in 'yellow' 5/ Signoff 6/ Revert your version of Template (so you can work properly again, cpanm Template@2.22) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25807 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25807 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106241|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25807 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 106242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106242&action=edit Bug 25807: Add Template 3.008 to the exclude list This patch adds version 3.008 of Template to the excludes list in our cpanfile. It also adds support for displaying this version on the about page. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25807 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106242|0 |1 is obsolete| | --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 106325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106325&action=edit Bug 25807: Add Template 3.008 to the exclude list This patch adds version 3.008 of Template to the excludes list in our cpanfile. It also adds support for displaying this version on the about page. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25807 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25807 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/abw/Temp | |late2/issues/263 CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25807 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25807 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25807 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|20.11.00 |20.11.00, 20.05.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25807 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #10 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Hey all, this does not apply cleanly on 19.11.x, please rebase if you'd like me to backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org